From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 224E240532 for ; Tue, 25 Jan 2022 07:24:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A269468B0AC; Tue, 25 Jan 2022 09:24:40 +0200 (EET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3EB6068AE78 for ; Tue, 25 Jan 2022 09:24:33 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643095478; x=1674631478; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=Pf5gC2E1NrG//a94cE5HRG2JvrLfMTaIaUxraEaNFMM=; b=R8dHjdbxiXxaO8oa8RRZqS2Bms3y0FaZ8o8vgCQcBQk3Vevu5yppmpTd TGF2eJuyw/Yhib3ES+asdTzNJpMj4M/hvaaH/uGCLyWP3Fia2oNGGaY/o jjlihlGxTOuJUKcdSAxPIS0FlcwJhLkpDjirF2OATqcFEA7rcL5O1miYi HSfz6HeWZKczzTcuFvXfhRdjH8oC57S6WCpw8W8CecHFCFj+wlidkVOzz sD339mFaw0QKe130VXc0zm0rIIHr7G+SrVWYQZN1DloRrdTkB28+whTAJ DMxvc7qWTn99BXGaInt9wgIWA37xInGjMZZVQyJ1sXPKY1fsojQJSw4M1 A==; X-IronPort-AV: E=McAfee;i="6200,9189,10237"; a="270684049" X-IronPort-AV: E=Sophos;i="5.88,314,1635231600"; d="scan'208";a="270684049" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2022 23:24:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,314,1635231600"; d="scan'208";a="477008307" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga003.jf.intel.com with ESMTP; 24 Jan 2022 23:24:31 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 24 Jan 2022 23:24:30 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 24 Jan 2022 23:24:30 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 24 Jan 2022 23:24:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gGD5OfFb388K8qnTc10/A62IkxFL/ls0QQiW0FLujMo2ZE/imD8g++pqQKZf3appIFm0UR2/3igIumFPEYb672gfywrxfrMf8qjWpEvfPulqMHnNFgSAQ+WtfWNfIcUegNmr8pjT8YWbMyKs39cmq7uakrZbfddwyQ1l4kqlr0o0RqaZorG9936On8GUVWPjW0m8d3p7EoFX1SwXUaFTHmoGrdLGIbCgQuDJ/q+9ydlwQTEswNlDPWhLQnUyzAjjcONavbu6MHFiUKi1ax2nQUARqv96mUc8R6CWSwpUKGu+lp375Ve8gP9uosO4Wo3TmcIrqF2ufv6UQVgXVlr9ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Pf5gC2E1NrG//a94cE5HRG2JvrLfMTaIaUxraEaNFMM=; b=K6Uvz9Qew7mZBdlTwWLip3dccj1oLbUREobv335suwktEePjKLFwK36/KN9SodG3DRXbpL1/z2AsuJjuuBfGQV6ntHbTuKev3xXAWVqEkHwcx6KXmhrU7F1q7krNa445ohJuafcB71W6b7vlqtiEdi8nk0CJkXZBV1StYYQad6+F9BKhzJChWZ/2cAZ6RgRUfVmMVecaO635O/CVXUawNZl5JR76ljG7Ytwb44c+p9m65OFjjyanx2noCyr2oj8zm8z49x7tRJSddNUXx2QfssGr6BftuY5j4YFe3pfrHUZL1sma7Cu2LK+CQgG2OHW4FV3KOynHepVhm0AptW8mcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by SN6PR11MB2813.namprd11.prod.outlook.com (2603:10b6:805:61::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.10; Tue, 25 Jan 2022 07:24:27 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::d436:c6ab:6e71:8843]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::d436:c6ab:6e71:8843%5]) with mapi id 15.20.4888.020; Tue, 25 Jan 2022 07:24:27 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH V2 1/3] libavcodec/qsvenc: Add max slice size support to hevc_qsv Thread-Index: AQHYEbsYjIdbrEvV/0uJl2Oro2MwIKxzVbEA Date: Tue, 25 Jan 2022 07:24:27 +0000 Message-ID: References: <20220125071237.58735-1-wenbin.chen@intel.com> In-Reply-To: <20220125071237.58735-1-wenbin.chen@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4bdf9830-acad-4ab6-a61f-08d9dfd3b8a3 x-ms-traffictypediagnostic: SN6PR11MB2813:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1417; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JNATz9Lvz311b9SUFP7gXmPwdQfiibbJPQMVcYjemJLIrr9dxBCwBmwAZJxNOwh8mISF3Yfi4+uAB5gh6WFMoz8FEqaTosRr9ZRK0jZPVPaSMSpt8nOHjkoVaWyRmHaT78+BStbyOJBtBXvz3tmfONR9QucIsrv55znWodLFUFd72dZpCTM1syG9EnZjHA3tK7rSACNSpqGFN61ZrzNNZAOl82+IN2wHgghBPXOqUpTgT4rY/NCOdBTO4y/I+jFTZjLMueMI0m9pBOmWbtnNiBjriRFvkFInL14cA74jUWEqH6zBV9kbo27RcgomOMEknqsNmCP3qdrpOCSuSVSw8BtqnhoQvXQiwBqk63gubeHs7ma1JtFyVhRfz1xHdDl8SHLIbCeyUPvG7CUgJhFnEeXOewiJ6Tcy8Vtz4hvDRTwO4knrIGkAtrAbtxj/l+qeaZRCDwuajVNWWgS8pIjrd3D+9Gn+YKc8YChf9iPj9JfYIv5/2RU3oDNuUlrmM2R/FtdGCKrMbnvlv7vUr60HkSWROSqeeRDmgegzNzfgyShWa4IO0NNp8w6dC4EljAu/Qz60BhssZ/QjY/jvehI4+YuFCDzHfQtjc1/KJ/iQstatK5zT6rcyBEwHxa2H+Y92EPYMZeQnSOa76Cbf9MjCuDkxpK3HMpihafZIi7T7twM2JOIcMPFQOCK59NSLcg5UB+oUWk23JLsqsdmKjKnHwBZnKiW0ixoIY6u9M3TQI6c= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(64756008)(83380400001)(66946007)(6916009)(86362001)(186003)(66556008)(6486002)(66476007)(316002)(71200400001)(2906002)(66446008)(91956017)(38070700005)(26005)(38100700002)(76116006)(508600001)(6506007)(6512007)(8936002)(36756003)(2616005)(8676002)(5660300002)(122000001)(82960400001)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?QjhidUJ6a2ZibXQvRzVXUmpPS0VrTEd2YnRBeEs5Ykk3VkRLK1lRbURTU2Z4?= =?utf-8?B?ZGFDa0t6cTNobU85ZjcyYUlSRS95dnVlaG5RcUZ2TEJxSENBNXExQ0lLZ3Bm?= =?utf-8?B?UE1PVnlXZVZXV0Q1THF2Zmlsei9YUXZIVXhmYXpkaHBLTzVTK0RNWTVFZkNF?= =?utf-8?B?bi9GbFplR2UzMnpqa1lPSTBFc09vUDYyNUxCUVpTNVltNFQ4YkpiV3NPT3RS?= =?utf-8?B?REtJWk8xTEMwcG4xa3VEYk5FczYxbm1vZHdvQTM1K045VmxpWDNRZVFHNDFP?= =?utf-8?B?Ti9RWGhZNGpESjJvSkhTWDF3Zm5JczBrVTk5MGVVdC9HVlRVM3Q5R0tBbG92?= =?utf-8?B?YWUxeXh6RHRGQ21MQ2V3QTkwbGk4TkluR0hCaHc5S2NwVHZYUThLdEloMkxl?= =?utf-8?B?K3dCeXZKeDVhaUVaUndhVDRTT0xKMEgyalZwTHF2MS9PZVg4T2ZiUFZZbTFn?= =?utf-8?B?ck11dU1CUnlIcjAxUkdNMWpxeHEvcjEzVFdoVTRQUWMzN2w3SDRBUVJjRGYy?= =?utf-8?B?ZDN1STA2MW9tMzh3VDZPbmdKbzc0NE5wZVVqTmg2VjEzVkFVYUtscGpOVmNa?= =?utf-8?B?WkRvZW10MXNpQndDM0p1WlRMdXdPZEFVL01rTVRFdVh4ajNta1NpdWtkRmNv?= =?utf-8?B?Q3lGZU8zSlUvRStnYlE2RURJNU0xUU0rUW5pNUQxUzFzSzhLTHZKMzNLdkNl?= =?utf-8?B?UUt1UU5sbytRYUF1NnRtMmZQR2Z6NDFkeWwwOXNyc0Uzbk5yaU80WWVQRmw5?= =?utf-8?B?UXgwYlRmOEJhTHlIS1dmWGdudlZWVE85Ry9qVWRxdmRnZkRlaDdyZGFZdVBt?= =?utf-8?B?V0JUK0RFQk83MDJwUzlKNjhWa2xqZFdDbG1jR0ZzUXVnaHB1WkM0V1duemR0?= =?utf-8?B?S1hiQjZaYytIMDRObWtxYXYwcWw0L3k5dCsvTFFkdEozZzVhK1RlVE1lc3Vu?= =?utf-8?B?azI5Q1g4d1RicFloNlBmVnk5MmhhQ1pwVWhsdDdmTVdkQlB4UDNHenppMVpx?= =?utf-8?B?ZVhGSTlkSzRSR0pMTmNaUVZTOXd2Tm4rOXBZTmVLWkxaTmtTMUoyN1htd25I?= =?utf-8?B?OERNK2VWLytETTdHR2V0aDlZK1p4QW1lc1VqTlhMdE1YOE0zWnhWZ2JqOUZi?= =?utf-8?B?d1Vyc3c0SGpKMVJNeDV5dXErM3ZMdk82ZWZTbTgzcDArd2RzTnB3UUhHNWV1?= =?utf-8?B?RGpVdmxqeklQeWFHYWtpWDJFWkdMK1E1ODV5MlZxb3RrenJVVUVnQ2dWRDgr?= =?utf-8?B?UHhITVR2Sm5GYjBWcURWZ2FlVkVtWVlTZkF5RUg0Y01nRVN1VDJPWENqM21p?= =?utf-8?B?dnlUOXdmYlY0YnVvTm5tck5FeldiOWhHcXA5OTdSUHBYSE53eEFsV0tOd2Zp?= =?utf-8?B?UjRweUs3YncyY1NTQlJIQm5SeVpJNkxUUEVuVFlMQjJwOXRJeWlIRGxPSWJQ?= =?utf-8?B?S2VjRVJSYWxDN1VJN0ljdTQ1NGx3amxRTWZ3VFBKOFRMU0JaN1NhdFZmNkhj?= =?utf-8?B?bFgrT3JXR0JEZVNWbVRWZmI3VU5hZEZGeENZZGNxYzBITlB3am1OZnE1bDUr?= =?utf-8?B?Vjk1OXFqRUxqalZpZHZLczlGTHJFMGdnbXphdjNJVWdDVzN0WFJVb085N0tC?= =?utf-8?B?aGgwTG5wRTNFMjJnaHR5TVgrU3NBaW8rMXVyUHNRMmUySmtyZkVvTHVCejY1?= =?utf-8?B?TkJycG5LY0JPQ1llMk9nVzZjN1Fic0FaYmtrMC9UaFV2ejZpbmRhSFh4V0wy?= =?utf-8?B?cGtLc2NoalJlMzZPWUkrT1hxZkVNWlg0ckRETDhPb2hUVFZYM3pTTldqZ3h2?= =?utf-8?B?aEs0a3AxbXRIYmdLY2FYdjNtc1BmMkNXY2tBT09IdTUwSFI5dHBpWEpPcGpH?= =?utf-8?B?dTlzM3IrNWRSckxkc2s1M05oRmpXamo0NCthZlpUMkJPeURGRkhYS3JOUHlO?= =?utf-8?B?ZTlTcWtpOVpGMlQ0SngxV28ydUdsSmkzMHgzb1JoazJLc3hOaWlDQTBqMHpu?= =?utf-8?B?Z0tvZjNQbUpSbkY5UDlpdVV5Q2JmT2FnYTVBTTlEblJ5MXRpQk1PQnBqZnZC?= =?utf-8?B?OHlRNzhrRUkxUjJJa3JqWk9LM0VVTFZiOTdJWEpzSkt0bkFqUkJ6cjJ2OHdz?= =?utf-8?B?MUZxMGhQVGtrVjdvV0xtRW02bXpwbTVQUzAvYlVpRllZR040QUxrUS9CRm9K?= =?utf-8?Q?oIsN/hLvxGisFYNKkO3Zf2w=3D?= Content-ID: <5C23F6156566D44289ADDED192477F62@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4bdf9830-acad-4ab6-a61f-08d9dfd3b8a3 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2022 07:24:27.7212 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rTySfdnkz7+SLPOuJ9F+p+c8hzhGYGgePejPZ443Mu+uCLO2inPQIkEssQPVNy23+ZCjXyTOBQCAQ5QMjyNfwA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2813 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH V2 1/3] libavcodec/qsvenc: Add max slice size support to hevc_qsv X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 2022-01-25 at 15:12 +0800, Wenbin Chen wrote: > Add max_slice_size option to hevc_qsv as well. > > Signed-off-by: Wenbin Chen > --- > doc/encoders.texi | 3 +++ > libavcodec/qsvenc.c | 9 ++++----- > 2 files changed, 7 insertions(+), 5 deletions(-) > > diff --git a/doc/encoders.texi b/doc/encoders.texi > index e3adbf4325..8966610263 100644 > --- a/doc/encoders.texi > +++ b/doc/encoders.texi > @@ -3397,6 +3397,9 @@ Enable rate distortion optimization. > @item @var{max_frame_size} > Maximum encoded frame size in bytes. > > +@item @var{max_slice_size} > +Maximum encoded slice size in bytes. > + > @item @var{p_strategy} > Enable P-pyramid: 0-default 1-simple 2-pyramid(bf need to be set to 0). > > diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c > index 413e5ae8f6..f311cd9ce4 100644 > --- a/libavcodec/qsvenc.c > +++ b/libavcodec/qsvenc.c > @@ -877,11 +877,6 @@ static int init_video_param(AVCodecContext *avctx, > QSVEncContext *q) > if (q->mbbrc >= 0) > q->extco2.MBBRC = q->mbbrc ? MFX_CODINGOPTION_ON : > MFX_CODINGOPTION_OFF; > > -#if QSV_HAVE_MAX_SLICE_SIZE > - if (q->max_slice_size >= 0) > - q->extco2.MaxSliceSize = q->max_slice_size; > -#endif > - > #if QSV_HAVE_TRELLIS > if (avctx->trellis >= 0) > q->extco2.Trellis = (avctx->trellis == 0) ? MFX_TRELLIS_OFF : > (MFX_TRELLIS_I | MFX_TRELLIS_P | MFX_TRELLIS_B); > @@ -907,6 +902,10 @@ static int init_video_param(AVCodecContext *avctx, > QSVEncContext *q) > q->extco2.ExtBRC = q->extbrc ? MFX_CODINGOPTION_ON : > MFX_CODINGOPTION_OFF; > if (q->max_frame_size >= 0) > q->extco2.MaxFrameSize = q->max_frame_size; > +#if QSV_HAVE_MAX_SLICE_SIZE > + if (q->max_slice_size >= 0) > + q->extco2.MaxSliceSize = q->max_slice_size; > +#endif > #if QSV_HAVE_DISABLEDEBLOCKIDC > q->extco2.DisableDeblockingIdc = q->dblk_idc; > #endif Patchset LGTM, will apply. -Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".