From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id A904A4D3C4 for ; Fri, 21 Feb 2025 09:53:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CC0CD68C75A; Fri, 21 Feb 2025 11:53:53 +0200 (EET) Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3277268BEF1 for ; Fri, 21 Feb 2025 11:53:46 +0200 (EET) Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:b231:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4Yzlnh3Hxcz9t33 for ; Fri, 21 Feb 2025 10:53:44 +0100 (CET) Message-ID: Date: Fri, 21 Feb 2025 15:23:42 +0530 MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org References: <20250220100650.2003-1-ffmpeg@gyani.pro> Content-Language: en-US From: Gyan Doshi In-Reply-To: X-Rspamd-Queue-Id: 4Yzlnh3Hxcz9t33 Subject: Re: [FFmpeg-devel] [PATCH] fftools: notify user of flags upon loglevel parse failure X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2025-02-21 02:21 pm, Andreas Rheinhardt wrote: > Gyan Doshi: >> --- >> fftools/opt_common.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/fftools/opt_common.c b/fftools/opt_common.c >> index 317e8458c1..2ac3fd4fb3 100644 >> --- a/fftools/opt_common.c >> +++ b/fftools/opt_common.c >> @@ -1330,6 +1330,11 @@ int opt_loglevel(void *optctx, const char *opt, const char *arg) >> "Possible levels are numbers or:\n", arg); >> for (i = 0; i < FF_ARRAY_ELEMS(log_levels); i++) >> av_log(NULL, AV_LOG_FATAL, "\"%s\"\n", log_levels[i].name); >> + av_log(NULL, AV_LOG_FATAL, "Possible flags are:\n"); >> + av_log(NULL, AV_LOG_FATAL, "\"repeat\"\n"); >> + av_log(NULL, AV_LOG_FATAL, "\"level\"\n"); >> + av_log(NULL, AV_LOG_FATAL, "\"time\"\n"); >> + av_log(NULL, AV_LOG_FATAL, "\"datetime\"\n"); >> return AVERROR(EINVAL); >> } >> > This would all fit into one line. Do you mean a single log call, or also printed on one line? If the former, the remaining values will be misaligned with the first one. If the latter, it's prettier with one value per line, just like the log level values printed just above. Regards, Gyan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".