From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3996B4229E for ; Thu, 31 Mar 2022 21:50:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 31BFC68B285; Fri, 1 Apr 2022 00:50:50 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D466D68A59A for ; Fri, 1 Apr 2022 00:50:43 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 22VLoho2013668-22VLoho3013668; Fri, 1 Apr 2022 00:50:43 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id 46058A1430; Fri, 1 Apr 2022 00:50:43 +0300 (EEST) Date: Fri, 1 Apr 2022 00:50:43 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <20220331172351.550818-1-bavison@riscosopen.org> Message-ID: References: <20220331172351.550818-1-bavison@riscosopen.org> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH v3 00/10] avcodec/vc1: Arm optimisations X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Ben Avison Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 31 Mar 2022, Ben Avison wrote: > The VC1 decoder was missing lots of important fast paths for Arm, especially > for 64-bit Arm. This submission fills in implementations for all functions > where a fast path already existed and the fallback C implementation was > taking 1% or more of the runtime, and adds a new fast path to permit > vc1_unescape_buffer() to be overridden. > > I've measured the playback speed on a 1.5 GHz Cortex-A72 (Raspberry Pi 4) > using `ffmpeg -i -f null -` for a couple of example streams: > > Architecture: AArch32 AArch32 AArch64 AArch64 > Stream: 1 2 1 2 > Before speed: 1.22x 0.82x 1.00x 0.67x > After speed: 1.31x 0.98x 1.39x 1.06x > Improvement: 7.4% 20% 39% 58% > > `make fate` passes on both AArch32 and AArch64. > > Changes in v2: > > * Refactor checkasm tests to convert some macros into functions. > * Remove cast-to-void of checked_call. > * Limit 16-bit values in idctdsp checkasm test to +/-0x100. > * Reinstate ff_add_pixels_clamped_arm. > * Adapt vc1 deblocking filters to specify stride as ptrdiff_t. > * Add align specifiers to a few VLD/VST instructions for AArch32 deblocking > filter, and adapt checkasm test not to test with tighter alignment than is > encountered in normal use. > * Correct unescape buffer memcmp length. > * Update benchmarks for AArch64 idctdsp. Thanks! From a quick readthrough, this version of the patchset seems good to me! I'll run it through some more testing, and push it if everything seems to work fine (tomorrow or so). // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".