Re: [FFmpeg-devel] [FFmpeg-cvslog] doc/filters: clarify behaviour of weights in amix

Re: [FFmpeg-devel] [FFmpeg-cvslog] doc/filters: clarify behaviour of weights in amix

[Anton Khirnov]

I do not see this patch on the mailing list.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [FFmpeg-cvslog] doc/filters: clarify behaviour of weights in amix

[Anton Khirnov]

Quoting Gyan Doshi (2022-08-09 11:22:39)
> I am a docs maintainer so I push these directly.

All patches should go through the mailing list, so other people get the
opportunity to comment on them.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [FFmpeg-cvslog] doc/filters: clarify behaviour of weights in amix

[Gyan Doshi]

On 2022-08-09 02:57 pm, Anton Khirnov wrote:
> Quoting Gyan Doshi (2022-08-09 11:22:39)
>> I am a docs maintainer so I push these directly.
> All patches should go through the mailing list, so other people get the
> opportunity to comment on them.

I do that for more extensive changes.

As the guidelines say,

"Send your changes as patches to the ffmpeg-devel mailing list, and if 
the code maintainers say OK, you may commit. This does not apply to 
files you wrote and/or maintain."

Regards,
Gyan

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [FFmpeg-cvslog] doc/filters: clarify behaviour of weights in amix

[Anton Khirnov]

Quoting Gyan Doshi (2022-08-09 11:36:22)
> 
> 
> On 2022-08-09 02:57 pm, Anton Khirnov wrote:
> > Quoting Gyan Doshi (2022-08-09 11:22:39)
> >> I am a docs maintainer so I push these directly.
> > All patches should go through the mailing list, so other people get the
> > opportunity to comment on them.
> 
> I do that for more extensive changes.
> 
> As the guidelines say,
> 
> "Send your changes as patches to the ffmpeg-devel mailing list, and if 
> the code maintainers say OK, you may commit. This does not apply to 
> files you wrote and/or maintain."

That documentation is outdated, almost nobody pushes directly anymore
without submitting patches to the ML.
I also see no good reason to NOT make the patches public. Being a
maintainer does not make one infallible.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [FFmpeg-cvslog] doc/filters: clarify behaviour of weights in amix

[Gyan Doshi]

On 2022-08-09 03:15 pm, Anton Khirnov wrote:
> Quoting Gyan Doshi (2022-08-09 11:36:22)
>>
>> On 2022-08-09 02:57 pm, Anton Khirnov wrote:
>>> Quoting Gyan Doshi (2022-08-09 11:22:39)
>>>> I am a docs maintainer so I push these directly.
>>> All patches should go through the mailing list, so other people get the
>>> opportunity to comment on them.
>> I do that for more extensive changes.
>>
>> As the guidelines say,
>>
>> "Send your changes as patches to the ffmpeg-devel mailing list, and if
>> the code maintainers say OK, you may commit. This does not apply to
>> files you wrote and/or maintain."
> That documentation is outdated, almost nobody pushes directly anymore
> without submitting patches to the ML.
Patch welcome.

Regards,
Gyan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [FFmpeg-cvslog] doc/filters: clarify behaviour of weights in amix

[Ronald S. Bultje]

On Tue, Aug 9, 2022 at 5:36 PM Gyan Doshi <ffmpeg@gyani.pro> wrote:

>
>
> On 2022-08-09 02:57 pm, Anton Khirnov wrote:
> > Quoting Gyan Doshi (2022-08-09 11:22:39)
> >> I am a docs maintainer so I push these directly.
> > All patches should go through the mailing list, so other people get the
> > opportunity to comment on them.
>
> I do that for more extensive changes.
>
> As the guidelines say,
>
> "Send your changes as patches to the ffmpeg-devel mailing list


and


if
> the code maintainers say OK, you may commit. This does not apply to
> files you wrote and/or maintain."


That should make the intent of the sentence quoted clear.

Ronald

>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [FFmpeg-cvslog] doc/filters: clarify behaviour of weights in amix

[Gyan Doshi]

On 2022-08-09 04:00 pm, Ronald S. Bultje wrote:
> On Tue, Aug 9, 2022 at 5:36 PM Gyan Doshi <ffmpeg@gyani.pro> wrote:
>
>>
>> On 2022-08-09 02:57 pm, Anton Khirnov wrote:
>>> Quoting Gyan Doshi (2022-08-09 11:22:39)
>>>> I am a docs maintainer so I push these directly.
>>> All patches should go through the mailing list, so other people get the
>>> opportunity to comment on them.
>> I do that for more extensive changes.
>>
>> As the guidelines say,
>>
>> "Send your changes as patches to the ffmpeg-devel mailing list
>
> and
>
>
> if
>> the code maintainers say OK, you may commit. This does not apply to
>> files you wrote and/or maintain."
>
> That should make the intent of the sentence quoted clear.

'This' refers to the entire preceding sentence. If it was otherwise, it 
would be incompatible with the 2nd way mentioned at
http://www.ffmpeg.org/developer.html#Contributing

I'm not wedded to the policy as stated in the current docs, but the 
current docs are clear that maintainers can push directly.

Doc patch(es) welcome.

Regards,
Gyan

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [FFmpeg-cvslog] doc/filters: clarify behaviour of weights in amix

[Hendrik Leppkes]

On Tue, Aug 9, 2022 at 12:46 PM Gyan Doshi <ffmpeg@gyani.pro> wrote:
>
>
>
> On 2022-08-09 04:00 pm, Ronald S. Bultje wrote:
> > On Tue, Aug 9, 2022 at 5:36 PM Gyan Doshi <ffmpeg@gyani.pro> wrote:
> >
> >>
> >> On 2022-08-09 02:57 pm, Anton Khirnov wrote:
> >>> Quoting Gyan Doshi (2022-08-09 11:22:39)
> >>>> I am a docs maintainer so I push these directly.
> >>> All patches should go through the mailing list, so other people get the
> >>> opportunity to comment on them.
> >> I do that for more extensive changes.
> >>
> >> As the guidelines say,
> >>
> >> "Send your changes as patches to the ffmpeg-devel mailing list
> >
> > and
> >
> >
> > if
> >> the code maintainers say OK, you may commit. This does not apply to
> >> files you wrote and/or maintain."
> >
> > That should make the intent of the sentence quoted clear.
>
> 'This' refers to the entire preceding sentence. If it was otherwise, it
> would be incompatible with the 2nd way mentioned at
> http://www.ffmpeg.org/developer.html#Contributing
>
> I'm not wedded to the policy as stated in the current docs, but the
> current docs are clear that maintainers can push directly.
>

If several people disagree on the interpretation, its clearly not as
"clear" as you claim it to be.

- Hendrik
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [FFmpeg-cvslog] doc/filters: clarify behaviour of weights in amix

[Gyan Doshi]

On 2022-08-09 04:55 pm, Hendrik Leppkes wrote:
> On Tue, Aug 9, 2022 at 12:46 PM Gyan Doshi <ffmpeg@gyani.pro> wrote:
>>
>>
>> On 2022-08-09 04:00 pm, Ronald S. Bultje wrote:
>>> On Tue, Aug 9, 2022 at 5:36 PM Gyan Doshi <ffmpeg@gyani.pro> wrote:
>>>
>>>> On 2022-08-09 02:57 pm, Anton Khirnov wrote:
>>>>> Quoting Gyan Doshi (2022-08-09 11:22:39)
>>>>>> I am a docs maintainer so I push these directly.
>>>>> All patches should go through the mailing list, so other people get the
>>>>> opportunity to comment on them.
>>>> I do that for more extensive changes.
>>>>
>>>> As the guidelines say,
>>>>
>>>> "Send your changes as patches to the ffmpeg-devel mailing list
>>> and
>>>
>>>
>>> if
>>>> the code maintainers say OK, you may commit. This does not apply to
>>>> files you wrote and/or maintain."
>>> That should make the intent of the sentence quoted clear.
>> 'This' refers to the entire preceding sentence. If it was otherwise, it
>> would be incompatible with the 2nd way mentioned at
>> http://www.ffmpeg.org/developer.html#Contributing
>>
>> I'm not wedded to the policy as stated in the current docs, but the
>> current docs are clear that maintainers can push directly.
>>
> If several people disagree on the interpretation, its clearly not as
> "clear" as you claim it to be.

Yes, but only one person (Ronald) disagreed. Anton said it was outdated.
But your objection is weird considering that Ronald affirmed that the 
intent was clear. That intent just happens to be opposite to what I 
think it is.

This continued discussion is pointless. All this needs is a patch for 
what the new unambiguous policy should be.

Regards,
Gyan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".