From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7A45245D33 for ; Thu, 6 Apr 2023 14:16:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 03E5668BDA6; Thu, 6 Apr 2023 17:15:59 +0300 (EEST) Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9CF7468B60B for ; Thu, 6 Apr 2023 17:15:51 +0300 (EEST) Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-54666385a33so181747b3.0 for ; Thu, 06 Apr 2023 07:15:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680790550; x=1683382550; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=27amAOH0Xp00aPel6Cu0Ijx/G/JD10hUIEebKokiryo=; b=OepohgedMmLkdbPNNEhPuuRxj1uPSZ60d1asn1IAG8OrklbzFshkVqkMYSNGnoL2XN LO3aM2QvHpjne45maZpiroIosh0iZ62t8r9r5XW9OUsXI5AK9d/AUZtuFMlD89uX0CAE zsBBW4M/V/9RNIbhnacMgwhlQjYUPXdpUMkrehskvW9YZGTD/YSCZGeb3d4hMG6eeEN0 Vyyz5SFgGBam3s/L7U92yFI0SrA5GqDfcqr49JwvD8E8LR7lti/o1ocyEMvDsjyoi5Yi /QxBWvadO/p8SlLBpwjDs7+IaHwMnIbqjhunT9hic0poHGPzuNF+KTktfquQMo60G2H4 bKPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680790550; x=1683382550; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=27amAOH0Xp00aPel6Cu0Ijx/G/JD10hUIEebKokiryo=; b=d7hh7ptqWGuZtdJit/Q10S1/dC9eS0yEhwdPuohu1uMEM54xE/DsAtgI8K8wdRS9sh yLA+1I6HCThQ/vOUFoeXjJa4Ufa14VLcrrjpc1X3qNASUnSN2cLihZPXxibkXm3RdGWt OGJOaIU1tCskiXvyRQbm1Hm/FjKCGHl4hTOy8IMfpvg+jtxnBjbasE0GO/FW93ulEfEJ gzRbuLRokgA4gzjGuUnQYcYfnB1pMUkEZJHg1xpGDS/OmUxolUZRk78mpM9WlrrsXunf a9OuhEnaIS4G/bQicJtqfw9+mpqhnf0XVvONJUs0xLe/5E4IwlPbCbyiLUpMf8Hs4Q0A tV5w== X-Gm-Message-State: AAQBX9c03Bc0t4FQUI90q8TufIlbELkHN3T2jwaBy+l0rbRsGF2jDGeo DUNEqlhcseraZYwIqgeHd3x/w2O4ptk= X-Google-Smtp-Source: AKy350bq0T6hBQTx2kJhcQFyfshZ38XxPlzSgHunHXCyX2CBrnry+Nq/d0bJZkjYzt46o/mvZO7wiA== X-Received: by 2002:a81:9b0b:0:b0:53c:70c5:45d2 with SMTP id s11-20020a819b0b000000b0053c70c545d2mr4053521ywg.0.1680790549933; Thu, 06 Apr 2023 07:15:49 -0700 (PDT) Received: from [192.168.1.35] (c-98-224-219-15.hsd1.mi.comcast.net. [98.224.219.15]) by smtp.gmail.com with ESMTPSA id s189-20020a819bc6000000b00545a0818483sm340952ywg.19.2023.04.06.07.15.48 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Apr 2023 07:15:49 -0700 (PDT) Message-ID: Date: Thu, 6 Apr 2023 10:15:48 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Content-Language: en-US-large To: ffmpeg-devel@ffmpeg.org References: <20230330231441.8868-1-michael@niedermayer.cc> <20230330231441.8868-2-michael@niedermayer.cc> <20230402213429.GO1164690@pb2> From: Leo Izen In-Reply-To: <20230402213429.GO1164690@pb2> Subject: Re: [FFmpeg-devel] [PATCH 2/3] avcodec/j2kenc: Add alpha support X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/2/23 17:34, Michael Niedermayer wrote: > On Fri, Mar 31, 2023 at 01:14:40AM +0200, Michael Niedermayer wrote: >> Signed-off-by: Michael Niedermayer >> --- >> libavcodec/j2kenc.c | 28 ++++++++++++++++++---------- >> 1 file changed, 18 insertions(+), 10 deletions(-) >> >> diff --git a/libavcodec/j2kenc.c b/libavcodec/j2kenc.c >> index 97b0da1c976..b23fb73770a 100644 >> --- a/libavcodec/j2kenc.c >> +++ b/libavcodec/j2kenc.c >> @@ -320,8 +320,8 @@ static int put_siz(Jpeg2000EncoderContext *s) >> >> for (i = 0; i < s->ncomponents; i++){ // Ssiz_i XRsiz_i, YRsiz_i >> bytestream_put_byte(&s->buf, s->cbps[i] - 1); >> - bytestream_put_byte(&s->buf, i?1<chroma_shift[0]:1); >> - bytestream_put_byte(&s->buf, i?1<chroma_shift[1]:1); >> + bytestream_put_byte(&s->buf, (i%3)?1<chroma_shift[0]:1); >> + bytestream_put_byte(&s->buf, (i%3)?1<chroma_shift[1]:1); > > i will replace the %3 by +1&2 to avoid slow modulo before applying > > (i % 3) and (i + 1) & 2 aren't the same tho, and won't be nonzero at the same time. `(i + 1) & 2` is equivalent to `(i + 1) % 4`. - Leo Izen (thebombzen) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".