From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D3F4A45E41 for ; Wed, 12 Apr 2023 11:59:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 96A5468BBDD; Wed, 12 Apr 2023 14:59:18 +0300 (EEST) Received: from mail-oa1-f44.google.com (mail-oa1-f44.google.com [209.85.160.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0E59968A7E3 for ; Wed, 12 Apr 2023 14:59:12 +0300 (EEST) Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-1841c57c221so15755236fac.3 for ; Wed, 12 Apr 2023 04:59:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681300750; x=1683892750; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7qogWmittb3DYiN+WijB2ROYjb1nB38zgjwWZbxVQko=; b=KslwGAF71mR7IoSNVXqvZtoyRLtJjE3VbZK2R4gn1UbHnToQKGbkAD5bbN8Ua53hxf Z+v+spGAjfxMh3M0Hlgx+AjKF+VDwVg4zEaZuv/4TRyXq4jm6e4uzfn2vP4zfmj9M/Gb +FLyojI0vFxjZ96ugiAb8/NQfAklNjjXv8xyxVwSuwEzBjLXTeXAH9kVlAfBy7jbaKhQ UrXxOXzrXc7iVgbvYUsAKyQDrAngdoBYlBpRRyKpVTouja6sLCA/EDkMx9Ii0L+K44GH yT2hQENu0A5gVuYlveOvOm/g6s82rOvnEWqxqf1YySnZpR+XlqSHwSA4NuGCGHvGUeh3 GARw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681300750; x=1683892750; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7qogWmittb3DYiN+WijB2ROYjb1nB38zgjwWZbxVQko=; b=GPaXDpL0us2XPL5+H+kWzEHmckppNuLkK5dRjDThMygBGPOqVX5yfMR/TzgD906Ojs 4Yey9TxYGhV6DAVp56sOBEOlcap3Zg5MKQokbwaQ850hx+APCNASzX/McGrVFS0KJe6O f5WLOib5NwxTd0bf9YT/0EKkRKcbq2/aU3gqO5LAQ7PFClKVBM2TTR2aU2nWfZwqCdmA 7biwRFPSNzdv9TMLT2ord6teCXdFNrYW2lWYrRbSuIDCsThIrnorRW9uMXaQAWlh4PPs /i6DSDK9Pw6gJz9xS95HyyqYXbtlMKnlbyMsLQHpSlMWlEjidNllcLhETkmPTZ7haoet z2JQ== X-Gm-Message-State: AAQBX9eUvWmMDjMFCom427mgTOxcnr2QHaxRNBfYAE1p2+XPVGIF8jaI YISRN7DS+ioh+2EwQEVs0gKB/e51Ey8= X-Google-Smtp-Source: AKy350aop0TOFiy4Yo9ZeUCuGHZMy4hsSQXi0NDOC0MEjc9+4fzlTXVKZ4MG0S0W1M9LV+cYY2UpBQ== X-Received: by 2002:a05:6870:240c:b0:184:a61:f3d5 with SMTP id n12-20020a056870240c00b001840a61f3d5mr3312958oap.39.1681300749524; Wed, 12 Apr 2023 04:59:09 -0700 (PDT) Received: from [192.168.0.15] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id l3-20020a9d7a83000000b006a1394ea9f3sm6316172otn.30.2023.04.12.04.59.08 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Apr 2023 04:59:08 -0700 (PDT) Message-ID: Date: Wed, 12 Apr 2023 08:59:11 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230411203851.65044-1-jamrial@gmail.com> <20230411203851.65044-2-jamrial@gmail.com> <168128699197.27013.12977793193161732244@lain.khirnov.net> <168130055249.27013.1669357758963017625@lain.khirnov.net> From: James Almer In-Reply-To: <168130055249.27013.1669357758963017625@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 2/3] avcodec: use the new event flags field instead of setting AVFrame.palette_has_changed X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/12/2023 8:55 AM, Anton Khirnov wrote: > Quoting James Almer (2023-04-12 13:26:48) >> On 4/12/2023 5:09 AM, Anton Khirnov wrote: >>> Quoting James Almer (2023-04-11 22:38:50) >>>> diff --git a/doc/APIchanges b/doc/APIchanges >>>> index 59216231f9..85060768b3 100644 >>>> --- a/doc/APIchanges >>>> +++ b/doc/APIchanges >>>> @@ -4,6 +4,7 @@ API changes, most recent first: >>>> >>>> 2023-04-11 - xxxxxxxxxx - lavc 60.10.100 - avcodec.h >>>> Add event_flags to AVCodecContext. >>>> + Add AVCTX_EVENT_FLAG_PALETTE_HAS_CHANGED. >>> >>> I think we should first figure out how is the field supposed to be >>> useful to our users. Maybe it's not and we can just remove it. >> >> That's fine. I have no idea if it's actually used or useful (You can >> always just memcmp(prev->data[1], cur->data[1], 256) on every frame >> after all), but removing without replacement tends to be controversial, >> hence why i did this. > > E.g. if the field is supposed to be useful in filters, then your change > would break that use case. It's apparently not, as a grep shows hits only in libavcodec. > > More generally I don't think we should be adding new APIs with no > understanding of how they are supposed to be used. Deprecating that > field entirely and waiting for someone to object seems better to me. Event flags are a clear concept already done in lavf, so it's not being done without knowing how they are supposed to be used. But ok, let's just deprecate the field and see if anyone complains. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".