From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 040FD45A59 for ; Mon, 13 Mar 2023 23:19:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D595868BD22; Tue, 14 Mar 2023 01:19:28 +0200 (EET) Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 66B1568BA80 for ; Tue, 14 Mar 2023 01:19:23 +0200 (EET) Received: by mail-qt1-f173.google.com with SMTP id r5so15058857qtp.4 for ; Mon, 13 Mar 2023 16:19:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vimeo.com; s=google; t=1678749561; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NETTcMM3nkAhrLf3ZXtsbKHaMHMeOP8GKfZ+ZK8GKJE=; b=V5EsPGasCFEj5/KNzpno9/dO3oF22LlHNSquLYeQCecfyEePgd8y8Sxx0MElxn4MhA qD0naUviqpoHSAK7j3d+1IY/fJbQyaarcpHu5BBvbZNWCnuSN/7xB7Q50ckrNnoQf4V9 vLhq4MWr+Sx5X0PQR3qkTnqiBsTSfHLIx1dFY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678749561; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NETTcMM3nkAhrLf3ZXtsbKHaMHMeOP8GKfZ+ZK8GKJE=; b=InzmW1EM93c1+rmJheQ0RQxML9QbIt+j7yHBZqH1Yqia96KBl+NPuM+iXWX90qPNjq YEOQLLnKRFZZcxpeMTU+cQ/csJ5AMMkQyr2gXRS6S9B12EdyUKgaO9K0tkHVVNJ6oD/9 N6WkzGDGO45wKf7Ggh8ZhIJLNf5hnouoBvbLQ2U7XgzikPpxgkQZyJn5MkNcV38ldjpq FszC4IqYabTrPsW6e1gn9630YQrXM6cQYQMXO5QmctErjX1vBskuggH85U2Ks5s4CBih pOOeBjZX33afMvpTKDJ4lkGS6LUtEb5g49yJ/WHhwaIW3czDSJ9CaaSEhvTerGNjS56z nROw== X-Gm-Message-State: AO0yUKXgm3zFKlQTY9ZBtWAqsLhCHXXmbRvtcPka5HlDEcCctMOVX809 tHgpzHbyUnAp0Q8TTimR0gzZskilGhaet03aGKUnGQ== X-Google-Smtp-Source: AK7set9WZprCS98DJPYfROgaxDRuMWRk1QCKN9biG8/uKlPps3QfUbNzN5pdyQLbV9eSwrkxucJslg== X-Received: by 2002:a05:622a:4d1:b0:3b8:5bc6:deab with SMTP id q17-20020a05622a04d100b003b85bc6deabmr58570952qtx.8.1678749561429; Mon, 13 Mar 2023 16:19:21 -0700 (PDT) Received: from ?IPV6:2600:4041:6c:7000:1f01:20c:8ba9:815b? ([2600:4041:6c:7000:1f01:20c:8ba9:815b]) by smtp.gmail.com with ESMTPSA id 9-20020a370b09000000b007339c5114a9sm586218qkl.103.2023.03.13.16.19.20 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Mar 2023 16:19:20 -0700 (PDT) Message-ID: Date: Mon, 13 Mar 2023 19:19:20 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Content-Language: en-US, fr-FR To: ffmpeg-devel@ffmpeg.org References: <6f3fc186-0b7f-052c-ecfb-b884eace4fed@vimeo.com> From: =?UTF-8?Q?Rapha=c3=abl_Zumer?= In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v5 2/2] avutil: add HDR10+ dynamic metadata serialization function X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/13/23 18:35, Andreas Rheinhardt wrote: > size being mandatory is different from similar APIs. There is even a > usecase without size: If you simply feed this to something that expects > the data to be serialized and trust the data to be complete, you don't > need the size. OK, I'll amend that. > You are allocating without any padding. This implies that one could not > use this buffer with our GetBit-API or in other places where one needed > a padded buffer. Is there any comparable code that does that? I feel like padding a buffer should be the responsibility of the caller for a public function, otherwise the user has to be aware of the padding to avoid embedding extra payload bytes accidentally (even though it is negligible in size), it is an extra manipulation if padding is not needed, and requires including an extra file to access the padding size. RZ _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".