From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 07B224A594 for ; Sat, 30 Mar 2024 12:49:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6DA3868D3B5; Sat, 30 Mar 2024 14:49:09 +0200 (EET) Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8DD6668D23E for ; Sat, 30 Mar 2024 14:49:02 +0200 (EET) Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-6e740fff1d8so2239182b3a.1 for ; Sat, 30 Mar 2024 05:49:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711802940; x=1712407740; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=3w2ndmaZ1xvMQ9MzZTHUo8U+HelUUXPUrW9IYBd6ro4=; b=TgSpUsQOVj1GHQo1/sbESL+BZI4qWhboDL7jF+FKLTo+3uMTYSZAZKA1+4vjlK2FGt iNKpsD5TBBTBFMwAYNPIueCJMmQoygNDSi8OFWT5A3I7LbSExPCaWyJUI/k1Ut7FkFCV QzGEcCMA3NE/qzhKuV7tYiS1RrSJeIqGmH+HESkJ6KRvr6NhjGfdB6ZLn77IZH5utSLW 3qz2eDaEzjd2DXWv6XBuJo2YEZmnHGzq8n14QldamrFzGlYJ/Ry7ai0KvqxtVBhL+e0k KPKFfMemlyF0pV0r0KDZvnM4MdiJHGS1DCFBr9Eck75G0ghgnsJQS47zwboPN5llNEMj 7gyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711802940; x=1712407740; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3w2ndmaZ1xvMQ9MzZTHUo8U+HelUUXPUrW9IYBd6ro4=; b=USNLYJVbqWgIeKcm3B6n2mxDxHfm8KXBGBcpvxLtAOV/4o5BJ1Dp4OGlh1qwr3TJ30 jbcngwc01jImztHd/yGKXElF+pc1qSgO2g3+zRA5/KFTW7iAgOpEy6Jwj8tREZmFuU+m ozZw6mKh76b9hGg3ogaR20a5CX4hiR6BTPTjkDa+BEmgeFDTkyOSgYOdw1TI2W3kTGee ERDsQLY5x/8/M6edqEUlAQRI5VZjyECqyPMh6V+pYGRiMZ6XmTLyLTMAqVKetajiSSpg UbUHtAlZWNrQLJrpI8fca3G+D1Gy92ok1TC12GPhoo6VK04h3NGlJgsLOsmMQV5t6Cm3 J0JQ== X-Gm-Message-State: AOJu0Ywnh4lOrX5HfvMi6TBawd98HHNsO5TfBZW+gN0kSvahWdUrXWKY +jUYotGfzD8twa6XJRe0Svbrm81YEyMtLHMOKZ1mZdd5O70KPS7SQD5B0Llc X-Google-Smtp-Source: AGHT+IHxMSelO/UfhWe9WrmwoJ49wK/2np5ifq0XcH2bs2RD2JRkUVNDNnWayk44T0DhlBEmWFLQKw== X-Received: by 2002:a05:6a20:914a:b0:1a5:6b5b:c0c5 with SMTP id x10-20020a056a20914a00b001a56b5bc0c5mr4588100pzc.14.1711802939633; Sat, 30 Mar 2024 05:48:59 -0700 (PDT) Received: from [192.168.0.15] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id p1-20020a170903248100b001dd675cb6fbsm5153954plw.298.2024.03.30.05.48.58 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 30 Mar 2024 05:48:59 -0700 (PDT) Message-ID: Date: Sat, 30 Mar 2024 09:49:07 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240329083509.10130-1-anton@khirnov.net> Content-Language: en-US From: James Almer In-Reply-To: <20240329083509.10130-1-anton@khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH] lavf/movenc: mark mov/mp4 as supporting VFR X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/29/2024 5:35 AM, Anton Khirnov wrote: > --- > libavformat/movenc.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c > index b97c479cc4..30cfbf6e74 100644 > --- a/libavformat/movenc.c > +++ b/libavformat/movenc.c > @@ -8230,11 +8230,11 @@ const FFOutputFormat ff_mov_muxer = { > .write_packet = mov_write_packet, > .write_trailer = mov_write_trailer, > .deinit = mov_free, > + .p.flags = AVFMT_GLOBALHEADER | AVFMT_TS_NEGATIVE | AVFMT_VARIABLE_FPS > #if FF_API_ALLOW_FLUSH > - .p.flags = AVFMT_GLOBALHEADER | AVFMT_ALLOW_FLUSH | AVFMT_TS_NEGATIVE, > -#else > - .p.flags = AVFMT_GLOBALHEADER | AVFMT_TS_NEGATIVE, > + | AVFMT_ALLOW_FLUSH > #endif > + , > .p.codec_tag = (const AVCodecTag* const []){ > ff_codec_movvideo_tags, ff_codec_movaudio_tags, ff_codec_movsubtitle_tags, 0 > }, > @@ -8282,11 +8282,11 @@ const FFOutputFormat ff_mp4_muxer = { > .write_packet = mov_write_packet, > .write_trailer = mov_write_trailer, > .deinit = mov_free, > + .p.flags = AVFMT_GLOBALHEADER | AVFMT_TS_NEGATIVE | AVFMT_VARIABLE_FPS > #if FF_API_ALLOW_FLUSH > - .p.flags = AVFMT_GLOBALHEADER | AVFMT_ALLOW_FLUSH | AVFMT_TS_NEGATIVE, > -#else > - .p.flags = AVFMT_GLOBALHEADER | AVFMT_TS_NEGATIVE, > + | AVFMT_ALLOW_FLUSH > #endif > + , > .p.codec_tag = mp4_codec_tags_list, > .check_bitstream = mov_check_bitstream, > .p.priv_class = &mov_isobmff_muxer_class, There's a custom check for these muxers in avformat_transfer_internal_stream_timing_info() that would afaict be disabled with this change. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".