From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DBBE047254 for ; Fri, 1 Dec 2023 18:19:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E7F1B68CF75; Fri, 1 Dec 2023 20:19:41 +0200 (EET) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F1A5568CF18 for ; Fri, 1 Dec 2023 20:19:34 +0200 (EET) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 3B1IJYbX027010-3B1IJYbY027010; Fri, 1 Dec 2023 20:19:34 +0200 Received: from foo.martin.st (host-97-144.parnet.fi [77.234.97.144]) by mail9.parnet.fi (Postfix) with ESMTPS id 28F23A1425; Fri, 1 Dec 2023 20:19:34 +0200 (EET) Date: Fri, 1 Dec 2023 20:19:33 +0200 (EET) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <9dc635d0-a01d-43a8-aeff-bec37d6143a1@myais.com.cn> Message-ID: References: <9dc635d0-a01d-43a8-aeff-bec37d6143a1@myais.com.cn> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH 5/6] lavc/aarch64: new optimization for 8-bit hevc_qpel_bi_v X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: jdek@itanimul.li Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, 18 Nov 2023, Logan.Lyu wrote: > +function ff_hevc_put_hevc_qpel_bi_v48_8_neon, export=1 > + mov x8, #32 > + str x8, [sp, #-80]! Why are you storing an immediate constant on the stack here? > + stp x4, x5, [sp, #16] > + stp x2, x3, [sp, #32] > + stp x0, x1, [sp, #48] > + stp x7, x30, [sp, #64] > + bl X(ff_hevc_put_hevc_qpel_bi_v32_8_neon) > + ldp x4, x5, [sp, #16] > + ldp x2, x3, [sp, #32] > + ldp x0, x1, [sp, #48] > + ldr x7, [sp, #64] > + add sp, sp, #64 > + add x0, x0, #32 > + add x2, x2, #32 > + add x4, x4, #64 > + bl X(ff_hevc_put_hevc_qpel_bi_v16_8_neon) > + ldr x30, [sp, #8] > + add sp, sp, #16 > + ret > +endfunc > + > +function ff_hevc_put_hevc_qpel_bi_v64_8_neon, export=1 > + b X(ff_hevc_put_hevc_qpel_bi_v32_8_neon) > +endfunc > function ff_hevc_put_hevc_pel_uni_pixels4_8_neon, export=1 The X(ff_hevc..) above for the b instruction is misindented. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".