From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: jdek@itanimul.li
Subject: Re: [FFmpeg-devel] [PATCH 5/6] lavc/aarch64: new optimization for 8-bit hevc_qpel_bi_v
Date: Fri, 1 Dec 2023 20:19:33 +0200 (EET)
Message-ID: <ed297df2-5111-62df-70cc-577e67f860d@martin.st> (raw)
In-Reply-To: <9dc635d0-a01d-43a8-aeff-bec37d6143a1@myais.com.cn>
On Sat, 18 Nov 2023, Logan.Lyu wrote:
> +function ff_hevc_put_hevc_qpel_bi_v48_8_neon, export=1
> + mov x8, #32
> + str x8, [sp, #-80]!
Why are you storing an immediate constant on the stack here?
> + stp x4, x5, [sp, #16]
> + stp x2, x3, [sp, #32]
> + stp x0, x1, [sp, #48]
> + stp x7, x30, [sp, #64]
> + bl X(ff_hevc_put_hevc_qpel_bi_v32_8_neon)
> + ldp x4, x5, [sp, #16]
> + ldp x2, x3, [sp, #32]
> + ldp x0, x1, [sp, #48]
> + ldr x7, [sp, #64]
> + add sp, sp, #64
> + add x0, x0, #32
> + add x2, x2, #32
> + add x4, x4, #64
> + bl X(ff_hevc_put_hevc_qpel_bi_v16_8_neon)
> + ldr x30, [sp, #8]
> + add sp, sp, #16
> + ret
> +endfunc
> +
> +function ff_hevc_put_hevc_qpel_bi_v64_8_neon, export=1
> + b X(ff_hevc_put_hevc_qpel_bi_v32_8_neon)
> +endfunc
> function ff_hevc_put_hevc_pel_uni_pixels4_8_neon, export=1
The X(ff_hevc..) above for the b instruction is misindented.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-12-01 18:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-18 2:07 Logan.Lyu
2023-12-01 18:19 ` Martin Storsjö [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed297df2-5111-62df-70cc-577e67f860d@martin.st \
--to=martin@martin.st \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=jdek@itanimul.li \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git