From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A42764C7FD for ; Tue, 6 Aug 2024 16:43:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D159468D949; Tue, 6 Aug 2024 19:43:26 +0300 (EEST) Received: from smtp.forwardemail.net (smtp.forwardemail.net [164.92.70.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BAEFE68D949 for ; Tue, 6 Aug 2024 19:43:19 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: From: References: To: Subject: MIME-Version: Date: Message-ID; q=dns/txt; s=fe-e1b5cab7be; t=1722962594; bh=9wxMlTtDOZx+UZq+vv0cB0hFNHmahG5N4AAShnhnUQ4=; b=oR2jHKcFHAYOHNwqYqjJpDMzo+iVe4Xe8Vl2NWxMEeHhMsInLJbeXmjQbNM10+L9rcbeOxc7Z pGSoxN8HkVlzd/isfT8GzM7ToRWwdPDHcbpEFvAhMOenh6PH6GAvRb9OdK3IyTTF+9GtOrfLxRn NcIEjRWV2rGeMaD8lAlnof3UiBouR5h8sQNW6644U0h7DZ91FM0CnjEe6DNOt8qI64UpT609X7x ygxbMO7lo9wHvxh01CnAR64hewchYRwY5FTnvYPQmnYAaYBgFmXegl+AOrjoigB95j7tDg7czn6 SJBFeQwLhrRNBvvJG1GgoCsMCapd/tG8aPh30UvzwGNQ== Message-ID: Date: Tue, 6 Aug 2024 18:43:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Lynne , FFmpeg development discussions and patches References: <20240806090607.43240-1-jonas@kwiboo.se> <20240806090607.43240-2-jonas@kwiboo.se> Content-Language: en-US From: Jonas Karlman In-Reply-To: X-Report-Abuse-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Complaints-To: abuse@forwardemail.net X-ForwardEmail-Version: 0.4.40 X-ForwardEmail-Sender: rfc822; jonas@kwiboo.se, smtp.forwardemail.net, 164.92.70.200 X-ForwardEmail-ID: 66b252a05073518727c22799 Subject: Re: [FFmpeg-devel] [PATCH v2 1/8] avutil/hwcontext: Add hwdevice type for V4L2 Request API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi Lynne, On 2024-08-06 14:46, Lynne via ffmpeg-devel wrote: > On 06/08/2024 11:06, Jonas Karlman wrote: >> Add a hwdevice type for V4L2 Request API with transfer_data_from support >> for AV_PIX_FMT_DRM_PRIME, based on AV_HWDEVICE_TYPE_DRM. >> >> AVV4L2RequestDeviceContext.media_fd can be set by the application or a >> media device path can be supplied when hwdevice is created. When none >> is supplied it default to -1 and hwaccel will auto-detect a media device >> with a capable video device. >> >> Signed-off-by: Jonas Karlman >> --- >> configure | 7 + >> libavutil/Makefile | 3 + >> libavutil/hwcontext.c | 4 + >> libavutil/hwcontext.h | 1 + >> libavutil/hwcontext_internal.h | 1 + >> libavutil/hwcontext_v4l2request.c | 261 ++++++++++++++++++++++++++++++ >> libavutil/hwcontext_v4l2request.h | 41 +++++ >> 7 files changed, 318 insertions(+) >> create mode 100644 libavutil/hwcontext_v4l2request.c >> create mode 100644 libavutil/hwcontext_v4l2request.h >> [snip] >> diff --git a/libavutil/hwcontext_v4l2request.h b/libavutil/hwcontext_v4l2request.h >> new file mode 100644 >> index 0000000000..0fe42f97b4 >> --- /dev/null >> +++ b/libavutil/hwcontext_v4l2request.h >> @@ -0,0 +1,41 @@ >> +/* >> + * This file is part of FFmpeg. >> + * >> + * FFmpeg is free software; you can redistribute it and/or >> + * modify it under the terms of the GNU Lesser General Public >> + * License as published by the Free Software Foundation; either >> + * version 2.1 of the License, or (at your option) any later version. >> + * >> + * FFmpeg is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >> + * Lesser General Public License for more details. >> + * >> + * You should have received a copy of the GNU Lesser General Public >> + * License along with FFmpeg; if not, write to the Free Software >> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA >> + */ >> + >> +#ifndef AVUTIL_HWCONTEXT_V4L2REQUEST_H >> +#define AVUTIL_HWCONTEXT_V4L2REQUEST_H >> + >> +/** >> + * @file >> + * An API-specific header for AV_HWDEVICE_TYPE_V4L2REQUEST. >> + */ >> + >> +/** >> + * V4L2 Request API device details. >> + * >> + * Allocated as AVHWDeviceContext.hwctx >> + */ >> +typedef struct AVV4L2RequestDeviceContext { >> + /** >> + * File descriptor of media device. >> + * >> + * Defaults to -1 for auto-detect. >> + */ >> + int media_fd; >> +} AVV4L2RequestDeviceContext; >> + >> +#endif /* AVUTIL_HWCONTEXT_V4L2REQUEST_H */ > > Any reason you're not using hwcontext_drm.h? > The DRM hwdevice/hwcontext requires a DRM/DRI device, however V4L2 decoding does not require a DRM/DRI device at all to do decode. This became fully apparent on a Rockchip RK3588 device that at the time did not have gpu or display support in mainline, yet it had a working AV1 decoder. Using a DRM hwdevice/hwcontext required an application to supply a path to a none existing DRI device. Instead a separate new hwdevice type is introduced, for now it can be used to define a specific media device to use /dev/mediaX, in future it could be extended to support options to specify what /dev/videoX device to use for decoding. These hwaccels only want to produce AV_PIX_FMT_DRM_PRIME output buffers and does not want to be tied to any DRM/DRI device, if there is better ways to do this, please advise. Regards, Jonas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".