Re: [FFmpeg-devel] [PATCH] lavc/libopenh264: Drop openh264 runtime version checks

[James Almer <jamrial@gmail.com>]

On 12/8/2023 4:07 PM, Kalev Lember wrote:
> On Fri, Dec 8, 2023 at 4:59 PM James Almer <jamrial@gmail.com> wrote:
> 
>> Does the configure check ensure a new enough openh264 version is the
>> minimum supported?
>>
> 
> Hm, I'd say that configure minimum version check is mostly orthogonal to
> the patch here.
> 
> This patch just removes a check that made it error out if the build time
> and runtime versions didn't perfectly match (as in, 1.0.0 at build time and
> 1.0.1 at run time would have resulted in erroring out). Basically just
> makes it behave like with all other libraries :)

I understand that, but you said "This should no longer be an issue with 
newer openh264 releases", meaning this used to be a problem until the 
project started being more careful about breakages, so shouldn't we bump 
the minimum required version to one where it's know there will be no 
issues at runtime if the runtime library is ABI incompatible with the 
link time one?
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".