From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CE48040353 for ; Wed, 19 Jan 2022 15:23:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5550A68B0C2; Wed, 19 Jan 2022 17:23:36 +0200 (EET) Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 037D368B0B7 for ; Wed, 19 Jan 2022 17:23:30 +0200 (EET) Received: by mail-ot1-f54.google.com with SMTP id t4-20020a05683022e400b00591aaf48277so3480095otc.13 for ; Wed, 19 Jan 2022 07:23:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=o2WL2Thz12fjY6FxrwrK0zEgtkNdJhADZdVzoCZaX1I=; b=beYrMlKFbDtms4GDKPskNnaLBPideZwaitf6fcwQASruMDWqo1egmxOEB1dMtSIsR0 sLb+obuq0mtbRVac7bdPxhTejPq/LmimmEGPC68WSAQemSBN+ggNBLwKmzWjyQwaVpMn jWMUEj5BgOYIPsvoZ89hcTFSLHXpUgWbiTSnQG1vlL23RjCG+yDGqZv6MIiWYOsG0sdP n0mYO1GPj9FvK5YVpamZGa3UXW5QJWUgb9K5wpg57n4lNWUtQQBh6x1+89QnphVhDq29 /dM/CrpULn8ReTJGgi8/KCycr6SCKp/EhPmDSpRj/CZsXrTJsltbHxLb4vOmhDVLuPbS n54g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=o2WL2Thz12fjY6FxrwrK0zEgtkNdJhADZdVzoCZaX1I=; b=5NO+WXbBlk5tP7oLSB/vwhWzIybO/TrDG6CLFdzX5bUzwAqU2DIjauZdCmzBvCjaMN PJVhqRlaomWl2mAtAcY3KWh1sIM4KxCtLXwcLOM9/DCNu2Yo9yZnKJOgHbmPXY7u3zrE RMclL02Uh3pl6ww8Z7nrArHd987mMh+0g7MXXnoFWp0DfgHUp0VXhjADNqsEhKk4ir08 l+4bD1xjsFbUSsjqS2doh8c6jsrShucz2oUqSusRqA7G2KZmup0JKVTa3sN6ionFTiSW ZM51B5D0jbaWKQfgfuTADKD6hpAKcRLSri+bntGSDEiNU1o+BUetvP2Ls7mA2xIWV0rL oulQ== X-Gm-Message-State: AOAM531fE0H1cr5g1+sI6k9BnwKXzbAOcikepY1kg5eNW0+LT5Mz0kVs 0ETcQF6RhRpSIxUYYIsK8/qxcWWjhSo= X-Google-Smtp-Source: ABdhPJyifUyE8fq0nZSNkxq6Spurx8eSoinRROE7tMT8Zt8z0TQDvqtkwGFUkPH/lm34kqPYLbOUzQ== X-Received: by 2002:a9d:7852:: with SMTP id c18mr10386127otm.174.1642605808186; Wed, 19 Jan 2022 07:23:28 -0800 (PST) Received: from [192.168.0.13] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id ay14sm49991oib.5.2022.01.19.07.23.26 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Jan 2022 07:23:27 -0800 (PST) Message-ID: Date: Wed, 19 Jan 2022 12:23:26 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <3335e1d2-14ee-8e3c-2e81-a6a077f7ee47@gmail.com> <20220119134846.19557-1-anton@khirnov.net> From: James Almer In-Reply-To: <20220119134846.19557-1-anton@khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH] configure: link to libatomic when it's present X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 1/19/2022 10:48 AM, Anton Khirnov wrote: > C11 atomics in some configurations (e.g. 64bit operations on ppc64 with > GCC) require linking to libatomic. > > Fixes #9275 > --- > configure | 25 ++++++++++++++++--------- > 1 file changed, 16 insertions(+), 9 deletions(-) > > diff --git a/configure b/configure > index 1413122d87..3059c154df 100755 > --- a/configure > +++ b/configure > @@ -3794,20 +3794,20 @@ cws2fws_extralibs="zlib_extralibs" > > # libraries, in any order > avcodec_deps="avutil" > -avcodec_suggest="libm" > +avcodec_suggest="libm stdatomic" > avdevice_deps="avformat avcodec avutil" > -avdevice_suggest="libm" > +avdevice_suggest="libm stdatomic" > avfilter_deps="avutil" > -avfilter_suggest="libm" > +avfilter_suggest="libm stdatomic" > avformat_deps="avcodec avutil" > -avformat_suggest="libm network zlib" > -avutil_suggest="clock_gettime ffnvcodec libm libdrm libmfx opencl user32 vaapi vulkan videotoolbox corefoundation corevideo coremedia bcrypt" > +avformat_suggest="libm network zlib stdatomic" > +avutil_suggest="clock_gettime ffnvcodec libm libdrm libmfx opencl user32 vaapi vulkan videotoolbox corefoundation corevideo coremedia bcrypt stdatomic" > postproc_deps="avutil gpl" > -postproc_suggest="libm" > +postproc_suggest="libm stdatomic" > swresample_deps="avutil" > -swresample_suggest="libm libsoxr" > +swresample_suggest="libm libsoxr stdatomic" > swscale_deps="avutil" > -swscale_suggest="libm" > +swscale_suggest="libm stdatomic" > > avcodec_extralibs="pthreads_extralibs iconv_extralibs dxva2_extralibs" > avfilter_extralibs="pthreads_extralibs" > @@ -6324,7 +6324,14 @@ check_headers asm/types.h > # it seems there are versions of clang in some distros that try to use the > # gcc headers, which explodes for stdatomic > # so we also check that atomics actually work here > -check_builtin stdatomic stdatomic.h "atomic_int foo, bar = ATOMIC_VAR_INIT(-1); atomic_store(&foo, 0); foo += bar" > +# > +# some configurations also require linking to libatomic, so try > +# both with -latomic and without > +for LATOMIC in "-latomic" ""; do > + check_builtin stdatomic stdatomic.h \ > + "atomic_int foo, bar = ATOMIC_VAR_INIT(-1); atomic_store(&foo, 0); foo += bar" \ > + $LATOMIC && eval stdatomic_extralibs="\$LATOMIC" && break > +done LGTM now, thanks. > > check_lib advapi32 "windows.h" RegCloseKey -ladvapi32 > check_lib bcrypt "windows.h bcrypt.h" BCryptGenRandom -lbcrypt && _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".