From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EDCC647487 for ; Tue, 10 Oct 2023 11:57:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5897668CAD7; Tue, 10 Oct 2023 14:57:46 +0300 (EEST) Received: from mail-oa1-f51.google.com (mail-oa1-f51.google.com [209.85.160.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 20EFA68C974 for ; Tue, 10 Oct 2023 14:57:40 +0300 (EEST) Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-1e12f41e496so3716744fac.3 for ; Tue, 10 Oct 2023 04:57:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696939058; x=1697543858; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oZ0VVh2/yEC6xHIyIWvVmeaNX1voUXz3LH1UL6xgbmk=; b=ia0/G7S6YozKGn8zpVKdqcC5qERYWXDnZenBM7X1TOaZrx4+BY5J8AXPy34e0vMPjI rCWhEXVhMHNm2/4/pazSsMX/KS0lIilyxbcL61TqpwS8rhxFSOI7SJFSCNXN+Z8+QksF /Q7rw/lb4+yZL5+jqTdUZI8sask+8qpAQiYTCN3i91t+IGsmg7HO2SKhbl7goGbIj6Rr y4fngQKxZuC78lwVoFEpab1CJAaCX19a972I5CfZOF0luRjaeu24VzKlhcMRA8dYIRq1 WjoJq6fwRvwk2SoDC+KO3p8aDn9J130Q9mKLZapz8hoQJPHWrk7/ya+MuQFMl1s8JI4F iq6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696939058; x=1697543858; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oZ0VVh2/yEC6xHIyIWvVmeaNX1voUXz3LH1UL6xgbmk=; b=jC6FhrldathmVfFRBAUEblForQP6ijDfYOO8YgkMxra+pfG058IfaXBLVr9Pj2PcB6 J7yTEaXtW8kBiY8rVn7okWcSPjP5j2lyNx/rSBsGTjY0LR6BESI0/5Y2wcTmkA4k7yHg 1olmv1TfjOcgrSkiQgvnah4wvTvJ3PiwlnBLrTuIUckNihtAP3NKNjMBaajCxf0s9Z4K SrM8tMeJt0RtEFbK8K1pKH4WHu0/mi2LNISNRD76dxViYqm8trvAIqn7F4OHaQLVpQM0 cU9LMMp5pghbseZrOLVXLDYutTOarzoNKHs6YKuP1FkA+BNNfOVo42w9SZ55ujzA2viP 7T8Q== X-Gm-Message-State: AOJu0YyHRjrVpBvGExw7cmjEVXKFiH/V5Nn2NO4i1nq3dBufxlWBiywF iuXE8g3kNm+zef7orWB0idWJjo2I9xw= X-Google-Smtp-Source: AGHT+IEKdNDO7wM9hmNFjMJ3NwC+dGKGAA5EKOvS5SYWACwR67//aTVQ+blBR9pcgs/egapKpBVBFA== X-Received: by 2002:a05:6358:8a2:b0:14b:86a3:b3f0 with SMTP id m34-20020a05635808a200b0014b86a3b3f0mr20211758rwj.5.1696939057816; Tue, 10 Oct 2023 04:57:37 -0700 (PDT) Received: from [192.168.0.16] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id rj6-20020a17090b3e8600b00276e8e4f1fbsm11907476pjb.1.2023.10.10.04.57.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Oct 2023 04:57:37 -0700 (PDT) Message-ID: Date: Tue, 10 Oct 2023 08:58:00 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20231007162503.1057-1-jamrial@gmail.com> <169693664668.6638.10128181560102102339@lain.khirnov.net> <169693887584.6638.1972986298885513458@lain.khirnov.net> From: James Almer Autocrypt: addr=jamrial@gmail.com; keydata= xsBNBFjZtqABCADLW+vdEoZaJZDsIO6geYFTOcn1unsEHefj9zn+3oTHlDFFzO47mzHsSfbK 9JE2xpOJEVnC8FAF5Sayi/pVwV+mtQUV3n5dgVeVBYF9GUQwOGFCpK8X54RRqhkgknbunOEE 0CtgAJgmpFmmmHgq02GvEspx1h/rh4apqwQR6QX4Favb+x9+i9ytVpwVcBX94vo2toyP7h/K BWfadQmb8ltgE1kshfg+SQs/H5bTV5Z1DuEASf02ZL/1qYB/sdTgWPLv9XMUHHsRFmMY8TMx wJSkP+Af3AiYQPJYz1B1D4tt98T/NoiVdin10zATakPjV8hXaobuRmxgakkUASXudydDABEB AAHNH0phbWVzIEFsbWVyIDxqYW1yaWFsQGdtYWlsLmNvbT7CwJIEEwEIADwCGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheAFiEEd1EujP2UoWlX5pp6FGMBrXN2WeAFAmJoLUUCGQEACgkQ FGMBrXN2WeAFVQf9GtGhniRs1PzNUOgJktCnv6j4BbLieaIPYPEFXKDHOgjqQE2zVMYXnoXl Jam928ii902a8OY06r9ywn/R8ApD1/3NY/v64O71CY9scz5XyH2au8wIZ6HwFy3/f7sqjdGD uctY8Qs7rjT7NkoC5lmgMu2v2k03dGtM9AAf5AK5gU+H0EUw7vmKKiXzUqt5kvBuf4CEwXvH AQT1SMJ52rIlDWB7FQFyZeUbOAK2IgY/KNedfK6nsgd/eQVnlofPd2XoddE7kP6iys7jJefw DD3g3rZyDTq7in5dyk5glaNpWZpbHGBs+9SCYLnfQ8XvWqPFOD+gj0plamKANgOvavKTxM7A TQRY2bagAQgA69YtILj8kYxmqPr/M8+MXT7wVoOWVW9lvSmPquCELaDy/NIS7D06VC5EuE/6 JlJXZMTn37NLlyWhzwOgXuXw5w2tyoQQBuvqGiXJijuXwXH7HKdzrc6rpYtAqt5w05hzNrFS KrS0izG64VpWrfproy3BsL+8TBm9brLhhNPynVRqVukbbGzlATTzNQGZ14TTi2/dL6DkMQnM qn4jX9UEe4GdGQBP50bUJSSmeiIkyNLWA+znuN2PZEz930ZwNrF9GtDVw7mzcmpCZ7spldE2 tutbpy9D1bIqxyqBrYDSezyzL2adR1qgHyOTMCHg2AYNkrIQHrSyJxKTpZ1/hqOp8wARAQAB wsBfBBgBAgAJBQJY2bagAhsMAAoJEBRjAa1zdlnghekH/0Yb0iYJ74oID2f/Fj+AJKS2ekQF P2xOr8lpGzgp/+yWUvPtqbX0A33anBJdYwxaAC0NataX3tfZ+oJkzXqfmqhIHMPYHdZesJA2 Bk9hU/33mDl5s5U66/z0uelWzwKVHoQ2O6or4+qF3HJFSJLCe9uvWJ3zXf9F342Ftj73sfx+ 3xkw/IXsN1RqbYqDlzpoEQ99SIEfY/8Jjwnd3sIPfqkuyeaYfe6GJDqKawdCEP1oRRlbXEAp TJgYz8r3nPhGv9cdHNDCk44ISbsqVuxIEnLqi4fTPZaGupiQhT+srl268TTAp2TQW7+6Ce/b NPQorMquzS/LZoyALpmsYi/miMc= In-Reply-To: <169693887584.6638.1972986298885513458@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 0/7] Container level frame cropping parameters X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 10/10/2023 8:54 AM, Anton Khirnov wrote: > Quoting James Almer (2023-10-10 13:44:19) >> On 10/10/2023 8:17 AM, Anton Khirnov wrote: >>> Quoting James Almer (2023-10-07 18:24:56) >>>> This is a simple set to add support to stream wide, container level cropping >>>> parameters, as featured in formats like Matroska and ISOBMFF. It's needed for >>>> things like AV1 streams generated by certain hardware encoders that produce >>>> dimension aligned output, and unlike H26x, can't export cropping info within >>>> the bitstream. >>>> In this set i add the packet side data type, mux and demux support to Matroska, >>>> and handling code to ffmpeg and ffplay. Missing is support for clap boxes in >>>> ISOBMFF, and exporting the relevant side data from encoders like AMF. >>>> >>>> It's a rebased and updated version to the set i sent a month ago. >>> >>> Why is there no lavc-decoder handling? I would expect cropping side data >>> submitted to lavc to be somehow propagated to decoded frames. >>> Though there is a question of how to combine side data with the >>> codec-level cropping. >> >> I thought about adding lavc support alongside the CLI handling, yeah. >> And it should be a matter of adding the values to the existing ones in >> frame->crop_* as exported by decoders, which av_frame_apply_cropping() >> will then handle. >> >> And the reason i add support to the CLI by including a filter instead of >> leaving it up to lavc is that av_frame_apply_cropping() may not do exact >> cropping if AV_CODEC_FLAG_UNALIGNED is not set. > > I intend to have the CLI always set AVCodecContext.apply_cropping=0 and > have it handled by lavfi for this exact reason, just didn't get to > actually doing it yet. Feel free and welcome to do it yourself. The cropping filter doesn't look at the frame cropping fields, though. It in fact exports cropping into them if you pass it hw frames. It only looks at input arguments. So it doesn't seem like that can be done without changing the filter. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".