* [FFmpeg-devel] [PATCH v1] avcodec/apv_encoder: Updated APV encoder to set the encoder output to OAPV_CFG_VAL_AU_BS_FMT_NONE format (the only AU without bitstream format) [not found] <CGME20250509115214eucas1p2aa8808b7a9cc51ee9659b2a22d9b0390@eucas1p2.samsung.com> @ 2025-05-09 11:52 ` Dawid Kozinski 2025-05-09 15:10 ` James Almer 0 siblings, 1 reply; 5+ messages in thread From: Dawid Kozinski @ 2025-05-09 11:52 UTC (permalink / raw) To: ffmpeg-devel; +Cc: Dawid Kozinski Signed-off-by: Dawid Kozinski <d.kozinski@samsung.com> --- libavcodec/liboapvenc.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/libavcodec/liboapvenc.c b/libavcodec/liboapvenc.c index 0c95489bc9..d338b33e2d 100644 --- a/libavcodec/liboapvenc.c +++ b/libavcodec/liboapvenc.c @@ -307,6 +307,18 @@ static av_cold int liboapve_init(AVCodecContext *avctx) return AVERROR_EXTERNAL; } + { + int size, value; + + value = OAPV_CFG_VAL_AU_BS_FMT_NONE; + size = 4; + ret = oapve_config(apv->id, OAPV_CFG_SET_AU_BS_FMT, &value, &size); + if(OAPV_FAILED(ret)) { + av_log(avctx, AV_LOG_ERROR, "Failed to set config for using encoder output format\n"); + return AVERROR_EXTERNAL; + } + } + apv->ifrms.frm[FRM_IDX].imgb = apv_imgb_create(avctx); if (apv->ifrms.frm[FRM_IDX].imgb == NULL) return AVERROR(ENOMEM); -- 2.34.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH v1] avcodec/apv_encoder: Updated APV encoder to set the encoder output to OAPV_CFG_VAL_AU_BS_FMT_NONE format (the only AU without bitstream format) 2025-05-09 11:52 ` [FFmpeg-devel] [PATCH v1] avcodec/apv_encoder: Updated APV encoder to set the encoder output to OAPV_CFG_VAL_AU_BS_FMT_NONE format (the only AU without bitstream format) Dawid Kozinski @ 2025-05-09 15:10 ` James Almer 2025-06-11 10:48 ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics 0 siblings, 1 reply; 5+ messages in thread From: James Almer @ 2025-05-09 15:10 UTC (permalink / raw) To: ffmpeg-devel [-- Attachment #1.1.1: Type: text/plain, Size: 1370 bytes --] On 5/9/2025 8:52 AM, Dawid Kozinski wrote: > Signed-off-by: Dawid Kozinski <d.kozinski@samsung.com> > --- > libavcodec/liboapvenc.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/libavcodec/liboapvenc.c b/libavcodec/liboapvenc.c > index 0c95489bc9..d338b33e2d 100644 > --- a/libavcodec/liboapvenc.c > +++ b/libavcodec/liboapvenc.c > @@ -307,6 +307,18 @@ static av_cold int liboapve_init(AVCodecContext *avctx) > return AVERROR_EXTERNAL; > } > > + { > + int size, value; > + > + value = OAPV_CFG_VAL_AU_BS_FMT_NONE; > + size = 4; > + ret = oapve_config(apv->id, OAPV_CFG_SET_AU_BS_FMT, &value, &size); > + if(OAPV_FAILED(ret)) { > + av_log(avctx, AV_LOG_ERROR, "Failed to set config for using encoder output format\n"); > + return AVERROR_EXTERNAL; > + } > + } > + > apv->ifrms.frm[FRM_IDX].imgb = apv_imgb_create(avctx); > if (apv->ifrms.frm[FRM_IDX].imgb == NULL) > return AVERROR(ENOMEM); Before we start adding support for recent API additions, liboapv needs to have versioning. See https://github.com/AcademySoftwareFoundation/openapv/issues/86 Otherwise, we have no way to ensure certain symbols are present and compilation will fail if you don't have the correct git master snapshot. [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 495 bytes --] [-- Attachment #2: Type: text/plain, Size: 251 bytes --] _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH v1] avcodec/apv_encoder: Updated APV encoder to set the encoder output to OAPV_CFG_VAL_AU_BS_FMT_NONE format (the only AU without bitstream format) 2025-05-09 15:10 ` James Almer @ 2025-06-11 10:48 ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics 0 siblings, 0 replies; 5+ messages in thread From: Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics @ 2025-06-11 10:48 UTC (permalink / raw) To: 'FFmpeg development discussions and patches' > -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of James > Almer > Sent: piątek, 9 maja 2025 17:11 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v1] avcodec/apv_encoder: Updated APV > encoder to set the encoder output to OAPV_CFG_VAL_AU_BS_FMT_NONE > format (the only AU without bitstream format) > > On 5/9/2025 8:52 AM, Dawid Kozinski wrote: > > Signed-off-by: Dawid Kozinski <d.kozinski@samsung.com> > > --- > > libavcodec/liboapvenc.c | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/libavcodec/liboapvenc.c b/libavcodec/liboapvenc.c index > > 0c95489bc9..d338b33e2d 100644 > > --- a/libavcodec/liboapvenc.c > > +++ b/libavcodec/liboapvenc.c > > @@ -307,6 +307,18 @@ static av_cold int liboapve_init(AVCodecContext > *avctx) > > return AVERROR_EXTERNAL; > > } > > > > + { > > + int size, value; > > + > > + value = OAPV_CFG_VAL_AU_BS_FMT_NONE; > > + size = 4; > > + ret = oapve_config(apv->id, OAPV_CFG_SET_AU_BS_FMT, &value, > &size); > > + if(OAPV_FAILED(ret)) { > > + av_log(avctx, AV_LOG_ERROR, "Failed to set config for using encoder > output format\n"); > > + return AVERROR_EXTERNAL; > > + } > > + } > > + > > apv->ifrms.frm[FRM_IDX].imgb = apv_imgb_create(avctx); > > if (apv->ifrms.frm[FRM_IDX].imgb == NULL) > > return AVERROR(ENOMEM); > > Before we start adding support for recent API additions, liboapv needs to have > versioning. See > https://protect2.fireeye.com/v1/url?k=8526c4a4-dabdfc59-85274feb- > 000babff317b-2be214fc02c42325&q=1&e=e91a51df-ab42-4926-bc0b- > f20830c7e3c6&u=https%3A%2F%2Fgithub.com%2FAcademySoftwareFoundatio > n%2Fopenapv%2Fissues%2F86 > Otherwise, we have no way to ensure certain symbols are present and > compilation will fail if you don't have the correct git master snapshot. Versioning for liboapv has been added. Therefore I resubmit this patch on the top of patchwork. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <CGME20250611105023eucas1p1a29ae053c112d4bfe1aa7d44f803149f@eucas1p1.samsung.com>]
* [FFmpeg-devel] [PATCH v1] avcodec/apv_encoder: Updated APV encoder to set the encoder output to OAPV_CFG_VAL_AU_BS_FMT_NONE format (the only AU without bitstream format) [not found] <CGME20250611105023eucas1p1a29ae053c112d4bfe1aa7d44f803149f@eucas1p1.samsung.com> @ 2025-06-11 10:50 ` Dawid Kozinski 2025-06-11 11:36 ` Zhao Zhili 0 siblings, 1 reply; 5+ messages in thread From: Dawid Kozinski @ 2025-06-11 10:50 UTC (permalink / raw) To: ffmpeg-devel; +Cc: Dawid Kozinski Signed-off-by: Dawid Kozinski <d.kozinski@samsung.com> --- libavcodec/liboapvenc.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/libavcodec/liboapvenc.c b/libavcodec/liboapvenc.c index 0c95489bc9..d338b33e2d 100644 --- a/libavcodec/liboapvenc.c +++ b/libavcodec/liboapvenc.c @@ -307,6 +307,18 @@ static av_cold int liboapve_init(AVCodecContext *avctx) return AVERROR_EXTERNAL; } + { + int size, value; + + value = OAPV_CFG_VAL_AU_BS_FMT_NONE; + size = 4; + ret = oapve_config(apv->id, OAPV_CFG_SET_AU_BS_FMT, &value, &size); + if(OAPV_FAILED(ret)) { + av_log(avctx, AV_LOG_ERROR, "Failed to set config for using encoder output format\n"); + return AVERROR_EXTERNAL; + } + } + apv->ifrms.frm[FRM_IDX].imgb = apv_imgb_create(avctx); if (apv->ifrms.frm[FRM_IDX].imgb == NULL) return AVERROR(ENOMEM); -- 2.34.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH v1] avcodec/apv_encoder: Updated APV encoder to set the encoder output to OAPV_CFG_VAL_AU_BS_FMT_NONE format (the only AU without bitstream format) 2025-06-11 10:50 ` Dawid Kozinski @ 2025-06-11 11:36 ` Zhao Zhili 0 siblings, 0 replies; 5+ messages in thread From: Zhao Zhili @ 2025-06-11 11:36 UTC (permalink / raw) To: FFmpeg development discussions and patches; +Cc: Dawid Kozinski > On Jun 11, 2025, at 18:50, Dawid Kozinski <d.kozinski@samsung.com> wrote: > > Signed-off-by: Dawid Kozinski <d.kozinski@samsung.com> > --- > libavcodec/liboapvenc.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/libavcodec/liboapvenc.c b/libavcodec/liboapvenc.c > index 0c95489bc9..d338b33e2d 100644 > --- a/libavcodec/liboapvenc.c > +++ b/libavcodec/liboapvenc.c > @@ -307,6 +307,18 @@ static av_cold int liboapve_init(AVCodecContext *avctx) > return AVERROR_EXTERNAL; > } > > + { > + int size, value; > + > + value = OAPV_CFG_VAL_AU_BS_FMT_NONE; > + size = 4; > + ret = oapve_config(apv->id, OAPV_CFG_SET_AU_BS_FMT, &value, &size); > + if(OAPV_FAILED(ret)) { > + av_log(avctx, AV_LOG_ERROR, "Failed to set config for using encoder output format\n"); > + return AVERROR_EXTERNAL; > + } > + } > + Declaration after statement is allowed now, so brace can be removed. > apv->ifrms.frm[FRM_IDX].imgb = apv_imgb_create(avctx); > if (apv->ifrms.frm[FRM_IDX].imgb == NULL) > return AVERROR(ENOMEM); > -- > 2.34.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-06-11 11:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20250509115214eucas1p2aa8808b7a9cc51ee9659b2a22d9b0390@eucas1p2.samsung.com>
2025-05-09 11:52 ` [FFmpeg-devel] [PATCH v1] avcodec/apv_encoder: Updated APV encoder to set the encoder output to OAPV_CFG_VAL_AU_BS_FMT_NONE format (the only AU without bitstream format) Dawid Kozinski
2025-05-09 15:10 ` James Almer
2025-06-11 10:48 ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
[not found] <CGME20250611105023eucas1p1a29ae053c112d4bfe1aa7d44f803149f@eucas1p1.samsung.com>
2025-06-11 10:50 ` Dawid Kozinski
2025-06-11 11:36 ` Zhao Zhili
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git