From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v1] avcodec/apv_encoder: Updated APV encoder to set the encoder output to OAPV_CFG_VAL_AU_BS_FMT_NONE format (the only AU without bitstream format)
Date: Fri, 9 May 2025 12:10:50 -0300
Message-ID: <ec514b97-8a71-42d1-a948-4a63a2954a6f@gmail.com> (raw)
In-Reply-To: <20250509115201.374984-1-d.kozinski@samsung.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 1370 bytes --]
On 5/9/2025 8:52 AM, Dawid Kozinski wrote:
> Signed-off-by: Dawid Kozinski <d.kozinski@samsung.com>
> ---
> libavcodec/liboapvenc.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/libavcodec/liboapvenc.c b/libavcodec/liboapvenc.c
> index 0c95489bc9..d338b33e2d 100644
> --- a/libavcodec/liboapvenc.c
> +++ b/libavcodec/liboapvenc.c
> @@ -307,6 +307,18 @@ static av_cold int liboapve_init(AVCodecContext *avctx)
> return AVERROR_EXTERNAL;
> }
>
> + {
> + int size, value;
> +
> + value = OAPV_CFG_VAL_AU_BS_FMT_NONE;
> + size = 4;
> + ret = oapve_config(apv->id, OAPV_CFG_SET_AU_BS_FMT, &value, &size);
> + if(OAPV_FAILED(ret)) {
> + av_log(avctx, AV_LOG_ERROR, "Failed to set config for using encoder output format\n");
> + return AVERROR_EXTERNAL;
> + }
> + }
> +
> apv->ifrms.frm[FRM_IDX].imgb = apv_imgb_create(avctx);
> if (apv->ifrms.frm[FRM_IDX].imgb == NULL)
> return AVERROR(ENOMEM);
Before we start adding support for recent API additions, liboapv needs
to have versioning. See
https://github.com/AcademySoftwareFoundation/openapv/issues/86
Otherwise, we have no way to ensure certain symbols are present and
compilation will fail if you don't have the correct git master snapshot.
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-05-09 15:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250509115214eucas1p2aa8808b7a9cc51ee9659b2a22d9b0390@eucas1p2.samsung.com>
2025-05-09 11:52 ` Dawid Kozinski
2025-05-09 15:10 ` James Almer [this message]
2025-06-11 10:48 ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
[not found] <CGME20250611105023eucas1p1a29ae053c112d4bfe1aa7d44f803149f@eucas1p1.samsung.com>
2025-06-11 10:50 ` Dawid Kozinski
2025-06-11 11:36 ` Zhao Zhili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec514b97-8a71-42d1-a948-4a63a2954a6f@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git