From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7E6AB40FB8 for ; Mon, 14 Mar 2022 14:07:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 552ED68AB2E; Mon, 14 Mar 2022 16:07:38 +0200 (EET) Received: from mail-oi1-f171.google.com (mail-oi1-f171.google.com [209.85.167.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 32B3A68A5E3 for ; Mon, 14 Mar 2022 16:07:31 +0200 (EET) Received: by mail-oi1-f171.google.com with SMTP id 12so17381434oix.12 for ; Mon, 14 Mar 2022 07:07:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=z3bEuRpu76Xx4zSCkeLRUHIvf5oj/x0tComsEm8ta/I=; b=TCGXdSXP/k1rwEUshjq8q+IeSeerdYEK9BXmSJTZ295ZlPCZnYJ3RYImyci3MdoWPt XQspdbhhcb9DjKkWS1KE9HVN42zCKTptDSMILBog9brGmNm9Fn7zEiOE815TmB1mXo6I 7ZKvlAhFBZ55W7fU/6ktXB1dXzS2rORgDThT67lVmRE/h1ToMX7qQN/TS6iBAMNdSMY/ i9QA8ZNGJmzzm9HYtuAMy6OlPSrTIOapb38nQI0hwxoI2AEzXSAzBs5lVQUiAufVgHWI VmbhfEXqS+oS5zSeEAlVPwFNU9g1WiqBxhxT8mWE1co4pZZAsjxb/iom97+iBGoe32EG /i3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=z3bEuRpu76Xx4zSCkeLRUHIvf5oj/x0tComsEm8ta/I=; b=8E+L5n/f7b+ion92Nhg4DnbKNHaQC7RTH+vGvmYpakTnovx4Nix4C1YWDvh8i2a6aZ xAFHS/6E6sDTjb3yC/nE7fKwukpmlJ8PcX/sRoeoCtm3ojjUBL1ZCNp0on8pWMzBXRwl s4/8lLGpokzsAOinH68O1+wPu6/2gIpOyG5ZZZPu2frwqJYxIhOPwkbXOV2DEIhmjL27 yoCOCrCCNofYxEuaLoHCGPE6uAO/ua1bvGekNaBo7kOPyOe1B7Pr52hiW05SQwLf2CPZ Wm+E18efmvGhSH2IQA6BnDPGGieIA4IpEdgwK84s41zZWiPVOOgJdXZWHDfm/FEGVT9O LViA== X-Gm-Message-State: AOAM532vNipbYgjNUi5RCMA58fEQyO5IUo3npwivIKtPSdm0tMicbmmb xA8pUGGiCBJ5SnjTA+kChWJ4J/ZsUnFRCg== X-Google-Smtp-Source: ABdhPJxhbZhrxttnc5WsRJcNwi/4Fh5QG/3P5bQztQKBc/+FYItbHbWf9dFpFYRl/rexCsZaWwiWLw== X-Received: by 2002:a05:6808:1201:b0:2d9:a01a:48b8 with SMTP id a1-20020a056808120100b002d9a01a48b8mr20255933oil.259.1647266849325; Mon, 14 Mar 2022 07:07:29 -0700 (PDT) Received: from [192.168.0.13] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id w4-20020a4adec4000000b0032109de628esm7377329oou.6.2022.03.14.07.07.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Mar 2022 07:07:28 -0700 (PDT) Message-ID: Date: Mon, 14 Mar 2022 11:07:38 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220312235227.19626-1-michael@niedermayer.cc> <20220314140441.GY2829255@pb2> From: James Almer In-Reply-To: <20220314140441.GY2829255@pb2> Subject: Re: [FFmpeg-devel] [PATCH 1/4] avcodec/vp9_superframe_split_bsf: Check in size X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/14/2022 11:04 AM, Michael Niedermayer wrote: > On Sun, Mar 13, 2022 at 04:03:42PM -0300, James Almer wrote: >> >> >> On 3/12/2022 8:52 PM, Michael Niedermayer wrote: >>> Fixes: Out of array read >>> Fixes: 45137/clusterfuzz-testcase-minimized-ffmpeg_BSF_VP9_SUPERFRAME_SPLIT_fuzzer-4984270639202304 >>> >>> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >>> Signed-off-by: Michael Niedermayer >>> --- >>> libavcodec/vp9_superframe_split_bsf.c | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/libavcodec/vp9_superframe_split_bsf.c b/libavcodec/vp9_superframe_split_bsf.c >>> index ed0444561a..6af555c078 100644 >>> --- a/libavcodec/vp9_superframe_split_bsf.c >>> +++ b/libavcodec/vp9_superframe_split_bsf.c >>> @@ -51,6 +51,11 @@ static int vp9_superframe_split_filter(AVBSFContext *ctx, AVPacket *out) >>> return ret; >>> in = s->buffer_pkt; >>> + if (in->size == 0) { >> >> !in->size > > I favor checking "== 0" when its about the value 0 and !X when its about > something being not set / not allocated. > but i can change it if you prefer > > thx I suggested it for the sake of consistence. Most AVPacket.size checks use !X to check for 0. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".