From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTPS id D1E3D4EA9F
	for <ffmpegdev@gitmailbox.com>; Fri, 13 Jun 2025 07:32:17 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id ADCD468C121;
	Fri, 13 Jun 2025 10:32:13 +0300 (EEST)
Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com
 [209.85.167.43])
 by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id D825E68BFC6
 for <ffmpeg-devel@ffmpeg.org>; Fri, 13 Jun 2025 10:32:06 +0300 (EEST)
Received: by mail-lf1-f43.google.com with SMTP id
 2adb3069b0e04-55394ee39dfso1837335e87.1
 for <ffmpeg-devel@ffmpeg.org>; Fri, 13 Jun 2025 00:32:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=martin-st.20230601.gappssmtp.com; s=20230601; t=1749799926; x=1750404726;
 darn=ffmpeg.org; 
 h=mime-version:references:message-id:in-reply-to:subject:cc:to:from
 :date:from:to:cc:subject:date:message-id:reply-to;
 bh=QbQ6Ldlo6q9BsLam09sG0coNiVveTPAyua2v9vk/kPE=;
 b=a4trQQyXT7wEFtGfWdpiA4zWhoWqqsNa6LL+ULa9cayaN8kmiqvkPepkZTyzdTyzw9
 BTWJRYVBuOwjL9NWrgHW9/qStZsgX/k1h8s7cWb+IaYMDKq8KkMq/2PS6AXhl3rBp9iZ
 LZ1kssLXaK2sUND3QUU6hsezsZ8smIK8RkoveX0QDo+pW8a0gfceF5aWQrirjqDtSlbC
 C8G0u4uDiEhCMVyOKx0CdBgYLlF/28kJQWKVYUoN5QkOpYGu61N5qgZ+qWe63LZsGqvU
 pvrJgfDgwjFXaME44z6zyj/zrPSFv+VGlxGCnLfQCWXpE980csnv9QOiDnZcvm/O4VWR
 Hkpw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1749799926; x=1750404726;
 h=mime-version:references:message-id:in-reply-to:subject:cc:to:from
 :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=QbQ6Ldlo6q9BsLam09sG0coNiVveTPAyua2v9vk/kPE=;
 b=PSM1vuEnOu8/esqWDcdgwRKd8s36Ji/D5hsJkI3SlIzCZBA7lG/6HVUfr0bghpUuom
 8m7NqpenlTqW844TfTwuM/MPgLU3NtELjsp3yCBm0oq2DaVKPjxpn7LPjkdxrLa7zc7J
 OlWBszsenX4aTZpvyNhLH/tzOLPPRf/vkJtVY1WQUtFUfzJFOBJ2kyczBHrcErqQxo2j
 jSG1xR9EFtbtixVE3AdowiH1yLq/ggys9u2k2o2VOYXDIBqtQM+4rqdWPcvPsKNi3qKJ
 UeTuQsWVjgIbvc9PFQUrVXwOBVC69w/fuqIUeM433fIpEy92IO65O6z6emBjKiJ/Bgkm
 Dm1Q==
X-Gm-Message-State: AOJu0YwNq028gPm7jtThjw7e2ThI9BFeR5zo+fq/eQZkBLxbSjCZRd04
 Cqm6DOF1G7dHALoPz2gbVRPov2/qeK5dOGbtBnLTv81OkiL0/rdkoxA6qcHkCnE5LEM7Rg0Rd3N
 kuLrxZA==
X-Gm-Gg: ASbGncuDr1M4H4nWIWxGJxpqw+hMAKsMHT9Pkg7fnIoPXpvBpl2xVH8Wf3fLWRGQVMc
 +h4J+AWqxeUnN3j7Epz/miLjb+h+c5/Z4vqj6HC6/JJ7RMiry+C6eZSIEbBF0s15cfbyBgV+mQ/
 XLbsE8TawVlocrtu4XrgJAgfePmwVcJH9SHUMzsQaiir4fi3peH6HLbCrhwabDbTMxPoQZXvP4X
 yuvOifc6kUhxIx84ffKNll2Y2e1G9O5alM1tpuiPGSc1XvhZSSLcz8zA73V6Wl0TTtD+dMAB7jh
 b+wCkwYMz0MowXRto8ldu4i2wiMv8/P9zMkuokNU0qCu33hj1QzIE56AUuS0r0cAdoD7aI4jn6y
 Rpz0vjeSl68o/bL6tIObazEIRilgIkSTNYp5BXMUt9snsdKP35H/gHWcLFEHD3SL0h4iS
X-Google-Smtp-Source: AGHT+IETBcJIiH4wu7fBpATKKM1iOxY2gZLOoA9yNfAofA1Wf7zsCdhOJeAQ1eElUMzaUT/ElXAg2w==
X-Received: by 2002:a05:6512:2356:b0:553:243c:c1d3 with SMTP id
 2adb3069b0e04-553b0eceb70mr381528e87.18.1749799925658; 
 Fri, 13 Jun 2025 00:32:05 -0700 (PDT)
Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net
 (tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2])
 by smtp.gmail.com with ESMTPSA id
 2adb3069b0e04-553ac1164ecsm352691e87.37.2025.06.13.00.32.04
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 13 Jun 2025 00:32:05 -0700 (PDT)
Date: Fri, 13 Jun 2025 10:32:02 +0300 (EEST)
From: =?ISO-8859-15?Q?Martin_Storsj=F6?= <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <tencent_4C46930F885333EC536295CCA9186EA04505@qq.com>
Message-ID: <ec2ed897-2952-3973-b173-111d2aeaf69e@martin.st>
References: <tencent_4C46930F885333EC536295CCA9186EA04505@qq.com>
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCH] avformat/movenc: Fix editlist with
 hybrid_fragmented
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Zhao Zhili <zhilizhao@tencent.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/ec2ed897-2952-3973-b173-111d2aeaf69e@martin.st/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Fri, 13 Jun 2025, Zhao Zhili wrote:

> From: Zhao Zhili <zhilizhao@tencent.com>
>
> The segment_duration must not be set to zero when writing the moov
> atom for the second time. This is related to edit lists in standard
> MP4 files.
> ---
> libavformat/movenc.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> index cd5b45f6fe..a651d6d618 100644
> --- a/libavformat/movenc.c
> +++ b/libavformat/movenc.c
> @@ -4036,8 +4036,13 @@ static int mov_write_edts_tag(AVIOContext *pb, MOVMuxContext *mov,
>     /* For fragmented files, we don't know the full length yet. Setting
>      * duration to 0 allows us to only specify the offset, including
>      * the rest of the content (from all future fragments) without specifying
> -     * an explicit duration. */
> -    if (mov->flags & FF_MOV_FLAG_FRAGMENT)
> +     * an explicit duration.
> +     *
> +     * For hybrid_fragmented during mov_write_trailer (mov->moov_written != 0),
> +     * don't reset duration to zero.
> +     */
> +    if (mov->flags & FF_MOV_FLAG_FRAGMENT &&
> +        !(mov->flags & FF_MOV_FLAG_HYBRID_FRAGMENTED && mov->moov_written))
>         duration = 0;
>
>     /* duration */
> -- 
> 2.46.0

LGTM, this sounds reasonable to me.

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".