From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1AB6D496AA for ; Mon, 18 Mar 2024 21:10:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9723B68D355; Mon, 18 Mar 2024 23:10:35 +0200 (EET) Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CA26268D248 for ; Mon, 18 Mar 2024 23:10:28 +0200 (EET) Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-341808b6217so506992f8f.3 for ; Mon, 18 Mar 2024 14:10:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20230601.gappssmtp.com; s=20230601; t=1710796228; x=1711401028; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CV5VdXOZJzy24TgRoc8c/khyPJITCF6j0fTOn/PZYLY=; b=i7IYNEDHx10P7+wjFHMXQuatDLV0OPm+BVJv+LjWThJU4Gk/NFrFsMJS7MqY9oFBTv 7pDvj3WZ2uBVT0KFt6LbT8fbSX6ScoNH/uFVjqLPglzI1GaBHfbyWlpIu1CtSnXsjDBX /c+qJe/GYaWGXukTucnbEqXvNof+7LEHxDb4lmHdegZrH13fFBIQhDz3y6k/E1N20Ouo cB8nugZy3BevUTtMMR+WD7MsLbvdOw1X5tn2HJObQjVYP9/i0QVdwNOZe6+/nI9jSu8f 6y20JIBzD0H5ugrppZqG8h/PKUjA5loO1xDLmkG0szn2xlAaiidjxPas9UZi2ecKE2/u hprg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710796228; x=1711401028; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CV5VdXOZJzy24TgRoc8c/khyPJITCF6j0fTOn/PZYLY=; b=QujPIvqGcfoVl7D0C63D7hnWduOWRM7q2ZlJIS3GaN7+qvvYD18CVvNEZEEjDVTyLP 1VtnlG8cv0Y+MB+PVWRhJeuZ2lF/Ea6MHjrMhiVwipLMzcSKstX6TKKzEQ88YLRMswis n/6KkOry7YrQRKswcOUdIpRR2ebNE23L44s4r8JgP4wOyDqQAmRdBqCuwi7qbcfYWxsO 5R4EXWEqzW9eWaZndwPGCFPBknfarZxm9oBnE2UM3L3p0EoF5U2Pm4YeTENazFpHRMDy ux/oWYFlzMElu52eYdl60DDkp7EzltP2YqRnBztlFxn8flgm0CV/uMOOTvpxr/wdB5Np GlxA== X-Gm-Message-State: AOJu0YyhwMS16F7/ElQ62dOAVEf4/yQPPHm8EwerMnKukx1Dfxs0Kxhg zwPJcTYpUXVRy5UjFcWl6NAy55vwZMkJsfFz+9ialVXLg/YCtcSgjfj7Zn7k9NQxll5DtrMv6uM U X-Google-Smtp-Source: AGHT+IExMxx3nx2xV4MZVXSoot38c0RUCf6tt5RTfq4umCp0BtZ9gCOiE7bhaZw/put8rVZvgKY7vw== X-Received: by 2002:a5d:6d8f:0:b0:33d:7e76:3080 with SMTP id l15-20020a5d6d8f000000b0033d7e763080mr463629wrs.53.1710796227885; Mon, 18 Mar 2024 14:10:27 -0700 (PDT) Received: from [192.168.0.15] (cpc92302-cmbg19-2-0-cust1183.5-4.cable.virginm.net. [82.1.212.160]) by smtp.gmail.com with ESMTPSA id ay25-20020a5d6f19000000b0033e3cb02cefsm10765019wrb.86.2024.03.18.14.10.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Mar 2024 14:10:27 -0700 (PDT) Message-ID: Date: Mon, 18 Mar 2024 21:11:00 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240318042111.21983-1-fei.w.wang@intel.com> From: Mark Thompson In-Reply-To: <20240318042111.21983-1-fei.w.wang@intel.com> Subject: Re: [FFmpeg-devel] [PATCH v3 1/2] lavc/vaapi_encode_h265: Map HEVC AV REXT profile to VA REXT profile X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 18/03/2024 04:21, fei.w.wang-at-intel.com@ffmpeg.org wrote: > From: Fei Wang > > There is no Main8/10 profile defined in HEVC REXT profiles. Use Main12 > which is compatible with 8/10bit. > > Signed-off-by: Fei Wang > --- > libavcodec/vaapi_encode_h265.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/vaapi_encode_h265.c b/libavcodec/vaapi_encode_h265.c > index c4aabbf5ed..43755e2188 100644 > --- a/libavcodec/vaapi_encode_h265.c > +++ b/libavcodec/vaapi_encode_h265.c > @@ -1305,12 +1305,12 @@ static av_cold int vaapi_encode_h265_configure(AVCodecContext *avctx) > > static const VAAPIEncodeProfile vaapi_encode_h265_profiles[] = { > { AV_PROFILE_HEVC_MAIN, 8, 3, 1, 1, VAProfileHEVCMain }, > - { AV_PROFILE_HEVC_REXT, 8, 3, 1, 1, VAProfileHEVCMain }, > #if VA_CHECK_VERSION(0, 37, 0) > { AV_PROFILE_HEVC_MAIN_10, 10, 3, 1, 1, VAProfileHEVCMain10 }, > - { AV_PROFILE_HEVC_REXT, 10, 3, 1, 1, VAProfileHEVCMain10 }, > #endif > #if VA_CHECK_VERSION(1, 2, 0) > + { AV_PROFILE_HEVC_REXT, 8, 3, 1, 1, VAProfileHEVCMain12 }, > + { AV_PROFILE_HEVC_REXT, 10, 3, 1, 1, VAProfileHEVCMain12 }, > { AV_PROFILE_HEVC_REXT, 12, 3, 1, 1, VAProfileHEVCMain12 }, > { AV_PROFILE_HEVC_REXT, 8, 3, 1, 0, VAProfileHEVCMain422_10 }, > { AV_PROFILE_HEVC_REXT, 10, 3, 1, 0, VAProfileHEVCMain422_10 }, What are you actually trying to do here? See 61aea246627787e80edd1f2eae01df63688dda68: these allow support for the Main Intra and Main 10 Intra profiles using Main and Main 10 encoders respectively (since they need not use any additional rext features). Changing this to require a Main 12 encoder and marking the streams as requiring such a Main 12 decoder to decode when they don't does not seem helpful. Thanks, - Mark _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".