Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Mark Thompson <sw@jkqxz.net>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/cbs_jpeg: Fix size of huffman symbol table array
Date: Sat, 30 Apr 2022 18:16:55 +0100
Message-ID: <ebaf462b-b789-8e19-d4f4-eef9e8996878@jkqxz.net> (raw)
In-Reply-To: <AM7PR03MB66606E1CA7B99EBF74E10A778F2D9@AM7PR03MB6660.eurprd03.prod.outlook.com>

On 08/02/2022 09:41, Andreas Rheinhardt wrote:
> L[i] can be in the range of 0-255, see table B.5 of ITU T.81.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>   libavcodec/cbs_jpeg.h                 | 2 +-
>   libavcodec/cbs_jpeg_syntax_template.c | 4 ++--
>   2 files changed, 3 insertions(+), 3 deletions(-)

Do you have a valid file showing this?  Not all values are allowed.

I guess I must have written it, but I have no idea where 224 came from.  As far as I know the worst case is in AC tables: 10 category values * 16 run lengths + 2 special cases = 162 (which could indeed all be dumped in the same code length if you want to be pathological).

- Mark
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2022-04-30 17:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-08  9:41 Andreas Rheinhardt
2022-02-11  9:28 ` Andreas Rheinhardt
2022-04-30 17:16 ` Mark Thompson [this message]
2022-04-30 18:38   ` Andreas Rheinhardt
2022-04-30 19:18     ` Mark Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ebaf462b-b789-8e19-d4f4-eef9e8996878@jkqxz.net \
    --to=sw@jkqxz.net \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git