From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9180D44ABB for ; Wed, 7 Dec 2022 01:55:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5DA79680106; Wed, 7 Dec 2022 03:55:29 +0200 (EET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B1D1568B0D6 for ; Wed, 7 Dec 2022 03:55:22 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670378128; x=1701914128; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=5eMEMhFRUl1Ea0b6z/l13OCB5ErND3y1P5sZZ0UV61I=; b=fD1Yp77Zjgg+spASlOPK5xX4B/SNjOIy54NS7X/EfPJaMSK9VlumW/Ea Ty/aWt4bheMuadxDdLmG2WlFWDUyKNe3cLxU30HJLwSx+kuDu2zhdGUNB zXHP5D6GxWAtb5PnXurDLlbXdZWiOA1tOJ9RGDqPRNiw+/Y+eCVVLyx7t 4vKzyzJ3bAGO8tMRpNTEOGgZSj/cyf1BqXoJPDQYOcQzTH8BoywR6RMad DS59BJOzOt4xeMWmKmF6ovgHhZpYvpp7UbN2kDH24l+xLmiR1fldzxjC7 A8QE4MYwrQogV7CLk4HlOfA6mIXbzPy+IklfnzwjWCXuUeUV/O1X1IMG9 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10553"; a="315495803" X-IronPort-AV: E=Sophos;i="5.96,223,1665471600"; d="scan'208";a="315495803" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2022 17:55:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10553"; a="788710575" X-IronPort-AV: E=Sophos;i="5.96,223,1665471600"; d="scan'208";a="788710575" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 06 Dec 2022 17:55:19 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 6 Dec 2022 17:55:19 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 6 Dec 2022 17:55:19 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.48) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 6 Dec 2022 17:55:18 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j5+jU5Bx3AFBXTrAYSmYgSuKzaQ/quUcPVvAx4vP+HKzHfZkPVCq9WJ53mblVaPxpzTHJ7elYpHxqZFJNITqcF9SVVgmhUngmzw/2g9pPH7vacsNC6ilfV1hzdn1Z5nM1hnPRmR6IK+zD7UusxKvUeUj0goMj69dDKSbPhnSiKL4rxku1H0gOmG0UlLw/zeN3jMwWUep2Ga209bgobLbXjhs0K2VYeLCsgX5+woEPfbPQRAeAO2gH6LG+e64VdbTuAATjufCYZOpadFu/Ygs1rLyKwxFvrawkbfPELjEqvcwbQeR0AObJRCFxAmTTxmEWL07wU2yxDqKNyEGQSTZQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5eMEMhFRUl1Ea0b6z/l13OCB5ErND3y1P5sZZ0UV61I=; b=fSus+LOOiQJxvnVUm+ZEV+hVJiILZHfooyVi5nkXK7BI2I2O5/axYI+V02QYpE2U7quCBXNY16zLKEJMr9C7T1OvMK3xXglbhK7HNDfFeFtzhAXLgwFFld03eRon7K8vQ68JKsCloYamZrEZigOc+cUVqSabEc9WFSUkR0Md3mblvWhNZ9fUsZH8+Xh0xpvCcb8E3QFjpgJndypStZbFQ7ckB/bxAgR4+FbZ152hQVjOOMb+PeLm8guLBahA1TuhuXX/Q3m2VEbVDa3FY1lKAVodOxu2PqlEYIr8NavjX/2ubb4KvKGcD67WlcyHuW9ASnLQRM9ZVhPawoCp1bV0Ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by CO1PR11MB4979.namprd11.prod.outlook.com (2603:10b6:303:99::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Wed, 7 Dec 2022 01:55:17 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::e3ef:177c:4008:7ee9]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::e3ef:177c:4008:7ee9%5]) with mapi id 15.20.5880.014; Wed, 7 Dec 2022 01:55:16 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" , "briannorris@chromium.org" Thread-Topic: [PATCH v2] lavu/hwcontext_vaapi: Skip 'vgem' driver Thread-Index: AQHZCPqkYKEK0fbwhku8Xs1wmvrDo65hq/CA Date: Wed, 7 Dec 2022 01:55:16 +0000 Message-ID: References: <20221205143317.v2.1.I9025996c33e0a4fe6133de948af3f3e75c214475@changeid> In-Reply-To: <20221205143317.v2.1.I9025996c33e0a4fe6133de948af3f3e75c214475@changeid> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5515:EE_|CO1PR11MB4979:EE_ x-ms-office365-filtering-correlation-id: cfa38889-f63f-4517-1a14-08dad7f616b5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0yXL42nCxdEckyTVa03a3IhJYSr/c3AkPvDJf33sFa2LD6NoS8hPz5BXvwBEmCOqgt6hPNm4G0b5RL4gm9IB4XgSk9vMabzFzXLcNoWM0wH5QCu0elzzXP2oIjrnK3sITySfLadQw/k4npzDc3U3vQhj1eCraFjVxT7bmXbos9JI6b8dyCtz2yp7zAlrw9NjhgZrCd6/dj0JI6+SkNJ7LQ5enaE2QFUafzO2Mbd6rnRTwOJb8k5abGq9tnavYI0fk9QIfs1SaNfhm3BFjnZ3RXzsDewsRD257294UxROlnnUHANH5LfVLF+b+Rw/EO7IFvHtxx+Dde53CAXiPWr4IQfLOWvJsUVXcQr5Gm2IvWWqYDX716f+ojSPBDcxE6wtUaHT5yAEJL2TT8QtnT8lX5qt8WB5Qsy8z2As60KrXvQaB/sGF5d2nPKYXHrP/LbOrkgouWh5B6DgqBqt9GpjzwxZyw3m0CYB9mipdOaprBrHekJ8aiv3MI+ehTbvU0Y1jDtRTNbkPwGcAuTF5NIK/j0UpNpHmNIO5QmDIOAUeFDWRm9U+XMFln2ZIhtfIgRc6/+vRr0ttny4+A8szlqiXWaR9Ujk1Lgp6Q3vJZPTwcn14yAC73qnsIWPl4nsosEjvWtMPYHv9rCSSyIMTTf6yYWClVEB93phHacCOKTA8zSx345hnmkMGIQJzIfOLakHAmUPk60/E3spBrtaBspWd2FxkVK39rKdE3zPD63oidA= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39860400002)(376002)(346002)(396003)(136003)(366004)(451199015)(83380400001)(122000001)(86362001)(8936002)(5660300002)(91956017)(82960400001)(2906002)(38070700005)(41300700001)(8676002)(478600001)(186003)(26005)(64756008)(6506007)(6512007)(66946007)(110136005)(66556008)(2616005)(316002)(76116006)(66446008)(66476007)(966005)(6486002)(38100700002)(71200400001)(36756003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?QWxLUjQrWmg3YXZiQWtTTFN1QmlpN2hLbGJ5emVqNElFblpsc2syck1OdFBW?= =?utf-8?B?OWNsU0p2dnJsMGNsVjdVTGhERk5YQUx6YnpVazczOU5kaVAzWDlvaVNBaWRx?= =?utf-8?B?RDliU0RHZUd4b0t0Y0VmeXNoR2xyMmJicFJ0WHdTdDFmUm5IcGtjMXliZTBD?= =?utf-8?B?ZXVRUjNLM1Ntb3MzQzR6QTVnRVQxdXl6SHdYSzlGRU9TTktOVVFpcWc1Y0I4?= =?utf-8?B?ZGZBMTY2QmlDUDY1eE9EOEFtZVBuUmJaOE50TVQybnBmSW9XbCtVWHB5VWN3?= =?utf-8?B?M3BGbklXNncyZEtXKyt2T0JYY1FoVjVtRW8weEEzTkMwU0liV0RZeUhBMndS?= =?utf-8?B?cFhvTEpBVE82Y3J6WHBxZ2hpMGdQNFVtQVNraVJ4SHUwK0xhc2NtNTVRTExk?= =?utf-8?B?NlZGbys1SW9pMjFNYXVzVUp0dHlQWmRuYVdRVytvLzZ6aHh4YW9razh3MW9R?= =?utf-8?B?T1k1SkswSExxQ2JoSjgzcmtGZjVMRWJBNkdMSUp5TENnbHpocjFLdUR5T1Rv?= =?utf-8?B?MGFtMjZxdmp2dDZGbk4vV2M4ZmtVb25HNE9ZcnJjMmFOUnRGbkZYMEJGaXcz?= =?utf-8?B?VzFFcTJzZC9vYmNzMUJwd0U0QWRESTcrbHh4Ylo5eUtrdUp6WlRGajBVZ2tI?= =?utf-8?B?cU4ra3UzeTlFdjRtcGVpWlgzQ1lCdWRhUGpBeTh2YzNHdDhndmZsZ3ZCc3BR?= =?utf-8?B?MjFKbFhmbHk2ZEVWWVl0TURlZWNIaUllbFVmN1FFREt0OVZ6cHFEWnNsc0hj?= =?utf-8?B?OU9CZHRkK0cxdXBKbDZkbUswWGtKQmxnTWVRa253RlB5aHVVd0VBcnFXMG0y?= =?utf-8?B?VjVGK0dnZVRUOUx2b0pDWSt0RnZuR1I2cE4yOGpPcEUwL1MySGkyTmlyUHJ1?= =?utf-8?B?cGdYcGpPTER6aFZUelE3bjNyV0RUMUJGUnVFWGNCc01MSk15VjBwZGZyQlE0?= =?utf-8?B?d0plRzY0bWNEdXJZdkJLSkUyMU8yYUtkR1dobHJ4OUFXVDVYKzNYcEt3VnQw?= =?utf-8?B?SEF5bUNreCs1Um5HVU1Pd2V6dlVRd2FIVHAwTHBDMEdwN0NhT0xiamZhUWZx?= =?utf-8?B?aVlnNnducXRTYkZ4S1RHd3hEdWlJNmlDS1FxdkgvQnRCOXVQUXQ4MXo2MVdq?= =?utf-8?B?V2tuaTFqQmRONEx2ejFqeEpiY1ZnQnJOYncwelROUG5LMlJVN1V3WXJrY21Y?= =?utf-8?B?aDkvTFB1bUlYUWtzVmg3eTBUSENRdTB5UUZ3SEsrdnZVcGdCaVZzRmhLUXkw?= =?utf-8?B?aUgvN3V3WDV0VmZFc213aUhIQ1AyVFFHSFd3cENjdmVxRlBVM1hWbThxVVVR?= =?utf-8?B?dlp0VzBENXJVbEFBSTJId0VLMlUrMWoyTmxQZ2FsN3pJTzJJVGFMSHBqSEo2?= =?utf-8?B?THJZT3o1c1JvYVNxYjUvS3pKYUxzME9sc0FkUUdmL0V0aVBGbzVmdWpaNG4v?= =?utf-8?B?c2h3NzhibjZoM0tlTmg4WlJodEh1cDR1cU9EN0lJZDY3aTREbE9vaEdmd1Q1?= =?utf-8?B?VVVwMFhSYnFTUFRtTmFYTnIvSWRuNUEvb2hmcEZzMy93QXV0d3kxZ2xaNVpr?= =?utf-8?B?cnpTOVQwckhxOFMvSVcyWlBaeVkwRS9oRlVZZmYxWndkODF2YXhBVzYyeCtP?= =?utf-8?B?am45dzg5R2p0K3BqaTVIdXNkUXdTdWZydVJiemM1MXJya2E1ME54MjRMd01I?= =?utf-8?B?d2VrMUg0UnpZRGZQREQrUUYzaUkzQ0pVL3l0VEprdzdHTS9aeHIyNW0zRjhv?= =?utf-8?B?dG0wdC9YNjhodFIyVUpHaWRKaC9hS0ZjYzZ0QmNKY0IxWm1WaTV4dk9nRW5k?= =?utf-8?B?OTZYSDI2TkNERUc1cHlBZWdtVjY5RU1XTHhhUUxxT2IzMDA5NkF0VTNBekZK?= =?utf-8?B?SzZJenVLWUpVL1NEd2Fodk1nRjU3M1kxLzlPeTR1ejNSc1FvMVpyN01iNXI1?= =?utf-8?B?Q2VTT3BLTHBUR2F0L0JFb2wrY01lNW5jQlF0QjdWVG16TFRmUU0rU3ZRejNR?= =?utf-8?B?UkxEYmdoaW5lbTlqY2E4MXVoYmptajg1VENGWCtLS1U1a1NqYXhWWkZ2WUNS?= =?utf-8?B?QTh6TXI1RkJDRUNXQWxQTzhSeWVlQWhZS2RVMTlsNDBNU1ZFZTJIOWhDeUhO?= =?utf-8?B?SG54TGhZNHFiQjhBOGVxRXUzSEdnaWFSdXgxSVBQNlVPc21EQXVWU0JIYndi?= =?utf-8?B?ZEE9PQ==?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cfa38889-f63f-4517-1a14-08dad7f616b5 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2022 01:55:16.8616 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oINERAtZVYvTLZYFCfLj6yRLO4FWsUz+Ov2BTEhmTNp3Whht3kQFW478OMzrBIkYka5zVyFsxmiwmemK0Mx5Zw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4979 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v2] lavu/hwcontext_vaapi: Skip 'vgem' driver X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Ma, 2022-12-05 at 14:33 -0800, Brian Norris wrote: > There can be more than one available render node, and it's not > guaranteed the first node we come across is the correct one. In > particular, 'vgem' devices are common, and are > never VAAPI-enabled and thus not valid here. > > We have a 'kernel_driver' arg already for specifying a single driver we > *do* want, but it doesn't support a negation, nor a list. It's easier > just to automatically skip 'vgem' anyway, to avoid foisting this burden > on users. > > This has precedent in libva-utils already: > > bfb6b98ed62a exclude vgem node and invalid drm node in vainfo > > https://github.com/intel/libva-utils/commit/bfb6b98ed62ac14a840ba62639ab902a23912258 > > Signed-off-by: Brian Norris > --- > > Changes in v2: > - strncmp() -> strcmp() > > libavutil/hwcontext_vaapi.c | 29 ++++++++++++++++++++++------- > 1 file changed, 22 insertions(+), 7 deletions(-) > > diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c > index 4bcde74f6212..938bd5447d5e 100644 > --- a/libavutil/hwcontext_vaapi.c > +++ b/libavutil/hwcontext_vaapi.c > @@ -1700,6 +1700,7 @@ static int vaapi_device_create(AVHWDeviceContext *ctx, > const char *device, > char path[64]; > int n, max_devices = 8; > #if CONFIG_LIBDRM > + drmVersion *info; > const AVDictionaryEntry *kernel_driver; > kernel_driver = av_dict_get(opts, "kernel_driver", NULL, 0); > #endif > @@ -1713,9 +1714,15 @@ static int vaapi_device_create(AVHWDeviceContext *ctx, > const char *device, > break; > } > #if CONFIG_LIBDRM > + info = drmGetVersion(priv->drm_fd); > + if (!info) { > + av_log(ctx, AV_LOG_VERBOSE, > + "Failed to get DRM version for device %d.\n", n); > + close(priv->drm_fd); > + priv->drm_fd = -1; > + continue; > + } > if (kernel_driver) { > - drmVersion *info; > - info = drmGetVersion(priv->drm_fd); > if (strcmp(kernel_driver->value, info->name)) { > av_log(ctx, AV_LOG_VERBOSE, "Ignoring device %d " > "with non-matching kernel driver (%s).\n", > @@ -1730,12 +1737,20 @@ static int vaapi_device_create(AVHWDeviceContext *ctx, > const char *device, > "with matching kernel driver (%s).\n", > n, info->name); > drmFreeVersion(info); > - } else > -#endif > - { > - av_log(ctx, AV_LOG_VERBOSE, "Trying to use " > - "DRM render node for device %d.\n", n); > + break; > + // drmGetVersion() ensures |info->name| is 0-terminated. > + } else if (!strcmp(info->name, "vgem")) { > + av_log(ctx, AV_LOG_VERBOSE, > + "Skipping vgem node for device %d.\n", n); > + drmFreeVersion(info); > + close(priv->drm_fd); > + priv->drm_fd = -1; > + continue; > } > + drmFreeVersion(info); > +#endif > + av_log(ctx, AV_LOG_VERBOSE, "Trying to use " > + "DRM render node for device %d.\n", n); > break; > } > if (n >= max_devices) LGTM, I'll apply this patch if no more comment Thanks Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".