[FFmpeg-devel] [PATCH v2] lavu/hwcontext_vaapi: Skip 'vgem' driver

[FFmpeg-devel] [PATCH v2] lavu/hwcontext_vaapi: Skip 'vgem' driver

[Brian Norris]

There can be more than one available render node, and it's not
guaranteed the first node we come across is the correct one. In
particular, 'vgem' devices are common, and are
never VAAPI-enabled and thus not valid here.

We have a 'kernel_driver' arg already for specifying a single driver we
*do* want, but it doesn't support a negation, nor a list. It's easier
just to automatically skip 'vgem' anyway, to avoid foisting this burden
on users.

This has precedent in libva-utils already:

  bfb6b98ed62a exclude vgem node and invalid drm node in vainfo
  https://github.com/intel/libva-utils/commit/bfb6b98ed62ac14a840ba62639ab902a23912258

Signed-off-by: Brian Norris <briannorris@chromium.org>
---

Changes in v2:
 - strncmp() -> strcmp()

 libavutil/hwcontext_vaapi.c | 29 ++++++++++++++++++++++-------
 1 file changed, 22 insertions(+), 7 deletions(-)

diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c
index 4bcde74f6212..938bd5447d5e 100644
--- a/libavutil/hwcontext_vaapi.c
+++ b/libavutil/hwcontext_vaapi.c
@@ -1700,6 +1700,7 @@ static int vaapi_device_create(AVHWDeviceContext *ctx, const char *device,
             char path[64];
             int n, max_devices = 8;
 #if CONFIG_LIBDRM
+            drmVersion *info;
             const AVDictionaryEntry *kernel_driver;
             kernel_driver = av_dict_get(opts, "kernel_driver", NULL, 0);
 #endif
@@ -1713,9 +1714,15 @@ static int vaapi_device_create(AVHWDeviceContext *ctx, const char *device,
                     break;
                 }
 #if CONFIG_LIBDRM
+                info = drmGetVersion(priv->drm_fd);
+                if (!info) {
+                    av_log(ctx, AV_LOG_VERBOSE,
+                           "Failed to get DRM version for device %d.\n", n);
+                    close(priv->drm_fd);
+                    priv->drm_fd = -1;
+                    continue;
+                }
                 if (kernel_driver) {
-                    drmVersion *info;
-                    info = drmGetVersion(priv->drm_fd);
                     if (strcmp(kernel_driver->value, info->name)) {
                         av_log(ctx, AV_LOG_VERBOSE, "Ignoring device %d "
                                "with non-matching kernel driver (%s).\n",
@@ -1730,12 +1737,20 @@ static int vaapi_device_create(AVHWDeviceContext *ctx, const char *device,
                            "with matching kernel driver (%s).\n",
                            n, info->name);
                     drmFreeVersion(info);
-                } else
-#endif
-                {
-                    av_log(ctx, AV_LOG_VERBOSE, "Trying to use "
-                           "DRM render node for device %d.\n", n);
+                    break;
+                // drmGetVersion() ensures |info->name| is 0-terminated.
+                } else if (!strcmp(info->name, "vgem")) {
+                    av_log(ctx, AV_LOG_VERBOSE,
+                           "Skipping vgem node for device %d.\n", n);
+                    drmFreeVersion(info);
+                    close(priv->drm_fd);
+                    priv->drm_fd = -1;
+                    continue;
                 }
+                drmFreeVersion(info);
+#endif
+                av_log(ctx, AV_LOG_VERBOSE, "Trying to use "
+                       "DRM render node for device %d.\n", n);
                 break;
             }
             if (n >= max_devices)
-- 
2.39.0.rc0.267.gcb52ba06e7-goog

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] lavu/hwcontext_vaapi: Skip 'vgem' driver

[Xiang, Haihao]

On Ma, 2022-12-05 at 14:33 -0800, Brian Norris wrote:
> There can be more than one available render node, and it's not
> guaranteed the first node we come across is the correct one. In
> particular, 'vgem' devices are common, and are
> never VAAPI-enabled and thus not valid here.
> 
> We have a 'kernel_driver' arg already for specifying a single driver we
> *do* want, but it doesn't support a negation, nor a list. It's easier
> just to automatically skip 'vgem' anyway, to avoid foisting this burden
> on users.
> 
> This has precedent in libva-utils already:
> 
>   bfb6b98ed62a exclude vgem node and invalid drm node in vainfo
>   
> https://github.com/intel/libva-utils/commit/bfb6b98ed62ac14a840ba62639ab902a23912258
> 
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
> 
> Changes in v2:
>  - strncmp() -> strcmp()
> 
>  libavutil/hwcontext_vaapi.c | 29 ++++++++++++++++++++++-------
>  1 file changed, 22 insertions(+), 7 deletions(-)
> 
> diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c
> index 4bcde74f6212..938bd5447d5e 100644
> --- a/libavutil/hwcontext_vaapi.c
> +++ b/libavutil/hwcontext_vaapi.c
> @@ -1700,6 +1700,7 @@ static int vaapi_device_create(AVHWDeviceContext *ctx,
> const char *device,
>              char path[64];
>              int n, max_devices = 8;
>  #if CONFIG_LIBDRM
> +            drmVersion *info;
>              const AVDictionaryEntry *kernel_driver;
>              kernel_driver = av_dict_get(opts, "kernel_driver", NULL, 0);
>  #endif
> @@ -1713,9 +1714,15 @@ static int vaapi_device_create(AVHWDeviceContext *ctx,
> const char *device,
>                      break;
>                  }
>  #if CONFIG_LIBDRM
> +                info = drmGetVersion(priv->drm_fd);
> +                if (!info) {
> +                    av_log(ctx, AV_LOG_VERBOSE,
> +                           "Failed to get DRM version for device %d.\n", n);
> +                    close(priv->drm_fd);
> +                    priv->drm_fd = -1;
> +                    continue;
> +                }
>                  if (kernel_driver) {
> -                    drmVersion *info;
> -                    info = drmGetVersion(priv->drm_fd);
>                      if (strcmp(kernel_driver->value, info->name)) {
>                          av_log(ctx, AV_LOG_VERBOSE, "Ignoring device %d "
>                                 "with non-matching kernel driver (%s).\n",
> @@ -1730,12 +1737,20 @@ static int vaapi_device_create(AVHWDeviceContext *ctx,
> const char *device,
>                             "with matching kernel driver (%s).\n",
>                             n, info->name);
>                      drmFreeVersion(info);
> -                } else
> -#endif
> -                {
> -                    av_log(ctx, AV_LOG_VERBOSE, "Trying to use "
> -                           "DRM render node for device %d.\n", n);
> +                    break;
> +                // drmGetVersion() ensures |info->name| is 0-terminated.
> +                } else if (!strcmp(info->name, "vgem")) {
> +                    av_log(ctx, AV_LOG_VERBOSE,
> +                           "Skipping vgem node for device %d.\n", n);
> +                    drmFreeVersion(info);
> +                    close(priv->drm_fd);
> +                    priv->drm_fd = -1;
> +                    continue;
>                  }
> +                drmFreeVersion(info);
> +#endif
> +                av_log(ctx, AV_LOG_VERBOSE, "Trying to use "
> +                       "DRM render node for device %d.\n", n);
>                  break;
>              }
>              if (n >= max_devices)

LGTM, I'll apply this patch if no more comment

Thanks
Haihao

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".