From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 44FC6403CA for ; Wed, 19 Jan 2022 20:52:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EECA368B181; Wed, 19 Jan 2022 22:52:03 +0200 (EET) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7FA0B68B162 for ; Wed, 19 Jan 2022 22:51:57 +0200 (EET) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id E61AAE6276 for ; Wed, 19 Jan 2022 21:51:56 +0100 (CET) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k5s4dmXbyF_P for ; Wed, 19 Jan 2022 21:51:55 +0100 (CET) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id 6EAE5E624A for ; Wed, 19 Jan 2022 21:51:55 +0100 (CET) Date: Wed, 19 Jan 2022 21:51:55 +0100 (CET) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: <20220118220856.34097-1-jamrial@gmail.com> Message-ID: References: <20220118220856.34097-1-jamrial@gmail.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 001/289 v6] Add a new channel layout API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 18 Jan 2022, James Almer wrote: > From: Anton Khirnov > > The new API is more extensible and allows for custom layouts. > More accurate information is exported, eg for decoders that do not > set a channel layout, lavc will not make one up for them. > > Deprecate the old API working with just uint64_t bitmasks. > > Expanded and completed by Vittorio Giovara > and James Almer . > Signed-off-by: Vittorio Giovara > Signed-off-by: James Almer > --- > Changes since last version: > > *av_channel_layout_from_string() and av_channel_layout_describe() now support > a "designation@name" syntax, effectively making both functions reciprocal > when there are custom names in some or all channels. > It's the syntax suggested by Marton and is both extensible if required and > not too ulgy in human readable output if the string is printed verbatim. > > *av_channel_layout_index_from_string() and > av_channel_layout_channel_from_string() also support this syntax now. I have two suggestions. None of them is actually blocking, but since they concern public syntax and API it might be better to decide now. av_channel_layout_index_from_string() without "@" in the string matches both builtin names (designations) and custom names. I suggest for it to only match builtin names. If a user wants to match by custom name, "@name" may be specified without a designation. This keeps the two namespaces separate. av_channel_layout_channel_from_string() is an API which is not used in the codebase. I am not enterely sure about its purpose, so maybe it should be removed for now, and only added later, if some code actually needs it. Thanks, Marton _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".