From: "Tomas Härdin" <git@haerdin.se> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: Re: [FFmpeg-devel] [PATCH] lavc: Replace 181 magic number with ITU_T_T35_COUNTRY_CODE_US Date: Tue, 04 Mar 2025 10:01:43 +0100 Message-ID: <eabed405c6685ddc05bf31e65d3c05b9b6c4dbf7.camel@haerdin.se> (raw) In-Reply-To: <CAHGibzGbUVXq8kZu017LA=GqK05E2q1xzcHo2Ykr34Djh2Ppgw@mail.gmail.com> mån 2025-03-03 klockan 08:55 -0500 skrev Devin Heitmueller: > On Mon, Mar 3, 2025 at 7:25 AM Tomas Härdin <git@haerdin.se> wrote: > > > > Looking at CTA-708 at the moment and noticed this. In the future we > > might want to make it possible for the user to set the country > > code. > > This patch makes finding usage of the US country code easier > > I've got no objection to moving a constant value to a #define for the > purpose of clarity, but there should never be a reason it needs to be > configurable by the user. The country code to be used for CTA-708 is > defined by the standards authority and must be 0xb5 (just as the > provider code must be 0x31). So it's "US" even if something is broadcast in Sweden? T.35 has a whole list of countries, some of which don't exist any more, and some new ones are missing > Even if the captions are intended to > serve other countries, the country code will stay the same (defining > the country code for individual languages goes in the PMT). How is one supposed to mux multiple subtitle languages in MPEGTS + H.264 anyway? This isn't clear at all from what I've read. Country codes, as opposed to language codes, being used in the 708 SEI makes it worse. And what of other container formats that have no PMT? /Tomas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-03-04 9:01 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2025-03-03 12:25 Tomas Härdin 2025-03-03 13:12 ` Andreas Rheinhardt 2025-03-04 9:12 ` Tomas Härdin 2025-03-04 11:31 ` Andreas Rheinhardt 2025-03-03 13:55 ` Devin Heitmueller 2025-03-04 9:01 ` Tomas Härdin [this message] 2025-03-04 15:13 ` Devin Heitmueller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=eabed405c6685ddc05bf31e65d3c05b9b6c4dbf7.camel@haerdin.se \ --to=git@haerdin.se \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git