* [FFmpeg-devel] [PATCH v1 1/2] avcodec/av1dec: Move message of OBU info back to the beginning
@ 2023-12-26 3:31 fei.w.wang-at-intel.com
2023-12-26 3:31 ` [FFmpeg-devel] [PATCH v1 2/2] avcodec/av1dec: Return error for unsupported tile list OBU fei.w.wang-at-intel.com
2023-12-27 5:35 ` [FFmpeg-devel] [PATCH v1 1/2] avcodec/av1dec: Move message of OBU info back to the beginning Xiang, Haihao
0 siblings, 2 replies; 4+ messages in thread
From: fei.w.wang-at-intel.com @ 2023-12-26 3:31 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: fei.w.wang
From: Fei Wang <fei.w.wang@intel.com>
So that can show OBU info even it doesn't have decomposed content.
Signed-off-by: Fei Wang <fei.w.wang@intel.com>
---
libavcodec/av1dec.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c
index da05a0f039..e8041c1f58 100644
--- a/libavcodec/av1dec.c
+++ b/libavcodec/av1dec.c
@@ -1200,11 +1200,12 @@ static int av1_receive_frame_internal(AVCodecContext *avctx, AVFrame *frame)
AV1RawOBU *obu = unit->content;
const AV1RawOBUHeader *header;
+ av_log(avctx, AV_LOG_DEBUG, "Obu idx:%d, obu type:%d.\n", i, unit->type);
+
if (!obu)
continue;
header = &obu->header;
- av_log(avctx, AV_LOG_DEBUG, "Obu idx:%d, obu type:%d.\n", i, unit->type);
switch (unit->type) {
case AV1_OBU_SEQUENCE_HEADER:
--
2.25.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* [FFmpeg-devel] [PATCH v1 2/2] avcodec/av1dec: Return error for unsupported tile list OBU
2023-12-26 3:31 [FFmpeg-devel] [PATCH v1 1/2] avcodec/av1dec: Move message of OBU info back to the beginning fei.w.wang-at-intel.com
@ 2023-12-26 3:31 ` fei.w.wang-at-intel.com
2023-12-27 5:35 ` [FFmpeg-devel] [PATCH v1 1/2] avcodec/av1dec: Move message of OBU info back to the beginning Xiang, Haihao
1 sibling, 0 replies; 4+ messages in thread
From: fei.w.wang-at-intel.com @ 2023-12-26 3:31 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: fei.w.wang
From: Fei Wang <fei.w.wang@intel.com>
Otherwise decoding maybe successful but output result is incorrect.
Signed-off-by: Fei Wang <fei.w.wang@intel.com>
---
libavcodec/av1dec.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c
index e8041c1f58..9b1778dcc4 100644
--- a/libavcodec/av1dec.c
+++ b/libavcodec/av1dec.c
@@ -1202,6 +1202,12 @@ static int av1_receive_frame_internal(AVCodecContext *avctx, AVFrame *frame)
av_log(avctx, AV_LOG_DEBUG, "Obu idx:%d, obu type:%d.\n", i, unit->type);
+ if (unit->type == AV1_OBU_TILE_LIST) {
+ av_log(avctx, AV_LOG_ERROR, "Large scale tile decoding is unsupported.\n");
+ ret = AVERROR_PATCHWELCOME;
+ goto end;
+ }
+
if (!obu)
continue;
--
2.25.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH v1 1/2] avcodec/av1dec: Move message of OBU info back to the beginning
2023-12-26 3:31 [FFmpeg-devel] [PATCH v1 1/2] avcodec/av1dec: Move message of OBU info back to the beginning fei.w.wang-at-intel.com
2023-12-26 3:31 ` [FFmpeg-devel] [PATCH v1 2/2] avcodec/av1dec: Return error for unsupported tile list OBU fei.w.wang-at-intel.com
@ 2023-12-27 5:35 ` Xiang, Haihao
2023-12-28 1:26 ` Wang, Fei W
1 sibling, 1 reply; 4+ messages in thread
From: Xiang, Haihao @ 2023-12-27 5:35 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Wang, Fei W
On Di, 2023-12-26 at 11:31 +0800, fei.w.wang-at-intel.com@ffmpeg.org wrote:
> From: Fei Wang <fei.w.wang@intel.com>
>
> So that can show OBU info even it doesn't have decomposed content.
>
> Signed-off-by: Fei Wang <fei.w.wang@intel.com>
> ---
> libavcodec/av1dec.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c
> index da05a0f039..e8041c1f58 100644
> --- a/libavcodec/av1dec.c
> +++ b/libavcodec/av1dec.c
> @@ -1200,11 +1200,12 @@ static int av1_receive_frame_internal(AVCodecContext
> *avctx, AVFrame *frame)
> AV1RawOBU *obu = unit->content;
> const AV1RawOBUHeader *header;
>
> + av_log(avctx, AV_LOG_DEBUG, "Obu idx:%d, obu type:%d.\n", i, unit-
> >type);
Could you add message to indicate the content of this unit is available or not ?
Thanks
Haihao
> +
> if (!obu)
> continue;
>
> header = &obu->header;
> - av_log(avctx, AV_LOG_DEBUG, "Obu idx:%d, obu type:%d.\n", i, unit-
> >type);
>
> switch (unit->type) {
> case AV1_OBU_SEQUENCE_HEADER:
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH v1 1/2] avcodec/av1dec: Move message of OBU info back to the beginning
2023-12-27 5:35 ` [FFmpeg-devel] [PATCH v1 1/2] avcodec/av1dec: Move message of OBU info back to the beginning Xiang, Haihao
@ 2023-12-28 1:26 ` Wang, Fei W
0 siblings, 0 replies; 4+ messages in thread
From: Wang, Fei W @ 2023-12-28 1:26 UTC (permalink / raw)
To: ffmpeg-devel, Xiang, Haihao
On Wed, 2023-12-27 at 05:35 +0000, Xiang, Haihao wrote:
> On Di, 2023-12-26 at 11:31 +0800, fei.w.wang-at-intel.com@ffmpeg.org
> wrote:
> > From: Fei Wang <fei.w.wang@intel.com>
> >
> > So that can show OBU info even it doesn't have decomposed content.
> >
> > Signed-off-by: Fei Wang <fei.w.wang@intel.com>
> > ---
> > libavcodec/av1dec.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c
> > index da05a0f039..e8041c1f58 100644
> > --- a/libavcodec/av1dec.c
> > +++ b/libavcodec/av1dec.c
> > @@ -1200,11 +1200,12 @@ static int
> > av1_receive_frame_internal(AVCodecContext
> > *avctx, AVFrame *frame)
> > AV1RawOBU *obu = unit->content;
> > const AV1RawOBUHeader *header;
> >
> > + av_log(avctx, AV_LOG_DEBUG, "Obu idx:%d, obu type:%d.\n",
> > i, unit-
> > > type);
>
> Could you add message to indicate the content of this unit is
> available or not ?
Added in V2.
Thanks
Fei
>
> Thanks
> Haihao
>
> > +
> > if (!obu)
> > continue;
> >
> > header = &obu->header;
> > - av_log(avctx, AV_LOG_DEBUG, "Obu idx:%d, obu type:%d.\n",
> > i, unit-
> > > type);
> >
> > switch (unit->type) {
> > case AV1_OBU_SEQUENCE_HEADER:
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-28 1:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-26 3:31 [FFmpeg-devel] [PATCH v1 1/2] avcodec/av1dec: Move message of OBU info back to the beginning fei.w.wang-at-intel.com
2023-12-26 3:31 ` [FFmpeg-devel] [PATCH v1 2/2] avcodec/av1dec: Return error for unsupported tile list OBU fei.w.wang-at-intel.com
2023-12-27 5:35 ` [FFmpeg-devel] [PATCH v1 1/2] avcodec/av1dec: Move message of OBU info back to the beginning Xiang, Haihao
2023-12-28 1:26 ` Wang, Fei W
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git