From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 072ED4F2AB for ; Mon, 16 Jun 2025 07:37:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 20E2E68D9BA; Mon, 16 Jun 2025 10:37:13 +0300 (EEST) Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 078C768D928 for ; Mon, 16 Jun 2025 10:37:07 +0300 (EEST) Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-553b82f3767so1708519e87.3 for ; Mon, 16 Jun 2025 00:37:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1750059426; x=1750664226; darn=ffmpeg.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=hce3je5YDbjreHgMVz/q08YtzAQ+XzG3hznXQg31THk=; b=fsglyBay3R83CkVLNo2rXjTFowPPixSIaVwsUk+C8Q2hSeKwx3zYDJ+nWAM6IB4NGc C236PFRuZTtyZqYfuJiU+wVk8a4HnQPGBEwEXGr+Iv7iMa5Nky3ADopGMLbL5oCBjpgV DKxfkAX6WkXS52kbv1vA4+JLMVS/RmTf+umNOiOPw3FTTRdJ6+6lLW2blB7jY0DBPB4z 6swH4i+s/A255M97uvmnx1XNDz9l1u8vtDx/xw2DerCy2BGe4OAfY1aqYFFpADfgvSvP 99x/R1pGWLgi97wxiEPIx6tAQYmt+UxdyzTNvxVtUVvJsJJNBq/Mm/wrpyl/W87RwAdP 0Wdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750059426; x=1750664226; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hce3je5YDbjreHgMVz/q08YtzAQ+XzG3hznXQg31THk=; b=X3+VswbcBPsBfcca7kJx859tSpCR/fdQNerNdBCuY0IbegIgDbjiDq+d1QxyrTIrXQ KVaRMT5fds1AkIa4o+9SIY7g0d2CThxqzbVLuodXWHuQ++1+rnXaJZqOtN1pd7Cklc4K O6Eg7/+SZcJyFuYaLjwhWOJWw8/eyXoSMJcgLpiCN7BZFAdFgvzCltBVho2GQUHA8I4x unW42gO0SOzAxY18SocRg66dknAJHVxgA/0hRQKstNDS0P4LOOhOTxAUKpKOe6hugyO8 BCLMzpc3i1FT285tner3kSV0eiqlbmAO+bhD3WLyvzVlpAtS92HttXhNa2X9Va+4sPNO Qj8A== X-Gm-Message-State: AOJu0YyCxA32ghFQps+Uczg05mA6NZFhbrbbdndH7Oa11U+fF6AbexqX DXtpzKWcs/3enVn94f3SC6m+ZStT5TTXiYj7/F4s52DNQBzK4DpvkWUA3ox/asTfzO9rdIuSe97 FBNYmQQ== X-Gm-Gg: ASbGncu7/zJA25AtNYpc2yQq4zMFzYreVv+l9kAYw7jqZoihMQx2k5fxYPs+GwQGwlg Um46tKdu7mDUYaU1y05Q7Qs5SbsnzEcOTKycuf7bhErW12VsbGPOYlKoO1o3u4FQowqVAlf9kR8 03M8NIzsVNFYq2bVXcGGojl0gLcfx7yoxGR/Ockj1yd2bmvCsbOnsbZx4wR+2eVprxu+bJHOIT4 g0TyHeZBmDsrHjjlhTn7+uhKBJZcliRvGErLbMsKQJ+lVfUqnG0Wjo/SP87Biz+aaA+hcfE8POu twEtb/P9HVgeaRGT1qFMPRu9HtBiubBsbFSpnYZaIL4Y9tT4F8jv/Tq+CfaERBP/b6FUkQwH0BR 1N2JfTZ6EkZqOuHkSdJdwM9c+EWrPpSwBwLeA11NsjSyNsDZOHKAjSzvSfA== X-Google-Smtp-Source: AGHT+IE9Z6agwz7UvcKhHMAQJWhMimzbcsU44yk2PHTZxsKgk9SXKGn3JTeNKuySmieto4J21pqqgw== X-Received: by 2002:a05:6512:3e07:b0:553:2fa8:8405 with SMTP id 2adb3069b0e04-553b6f4f34bmr2141962e87.56.1750059425660; Mon, 16 Jun 2025 00:37:05 -0700 (PDT) Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net (tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-553ac1da6a1sm1447552e87.179.2025.06.16.00.37.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 00:37:05 -0700 (PDT) Date: Mon, 16 Jun 2025 10:37:04 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <20250614224942.GT5177@pb2> Message-ID: References: <20250613083704.6858-1-jiawei@iscas.ac.cn> <20250614224942.GT5177@pb2> MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH v5] gcc: Don't disable '-ftree-vectorize' if gcc version higher than 13. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Jiawei Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, 15 Jun 2025, Michael Niedermayer wrote: > Hi Martin > > On Fri, Jun 13, 2025 at 11:42:11AM +0300, Martin Storsj=F6 wrote: >> On Fri, 13 Jun 2025, Jiawei wrote: >> >>> This patch modifies the FFmpeg build system to allow GCC to use the >>> `-ftree-vectorize` flag when the compiler version is 13 or newer. >>> Enabling this flag can improve performance through better loop analysis >>> and auto-vectorization (SIMD) opportunities in modern GCC versions. >>> >>> The explicit `-fno-tree-vectorize` flag was originally added in commit >>> 973859f5230e (2009). A previous attempt to enable `-ftree-vectorize` >>> was made in commit cb8646af24bd (2016), but it was reverted in >>> fd6dbc53855f. The reason for the revert was that the inline x86 CABAC >>> assembly code caused compiler errors ??? the compiler would run out of >>> available registers during vectorization, making it unable to compile >>> some functions. >>> >>> In commit 182663a58a7a (2023), the problematic CABAC function was made >>> non-inline. This significantly reduces the risk of register exhaustion >>> caused by inlining large assembly blocks, making the vectorizer safer >>> to enable for other functions. >>> >>> Given improvements in GCC's vectorizer and the mitigation of the >>> original issue, we now re-enable `-ftree-vectorize` for GCC version 13 >>> and above. >>> >>> Version log: >>> Only allow GCC versions >=3D 13 to use -ftree-vectorize. >>> Modify the commit description. >>> Add historical context and rationale for the change. >>> >>> Disscussion see: >>> https://patchwork.ffmpeg.org/project/ffmpeg/patch/20250521061750.54882-= 1-jiawei@iscas.ac.cn/ >>> >>> >>> Signed-off-by: Jiawei >>> --- >>> configure | 6 +++++- >>> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> Thanks; I'm ok with this version. Whoever applies it can touch up the co= mmit >> message to remove the ???? word (maybe just replace it with an "as"), it >> sounds reasonably right like that. > > the patch seems not to be on the mailing list > I have v4 in my inbox but not v5, so if the patch is ok, maybe you are > the only one who can apply it > > Maybe Jiawei is not subscribed to the ML so his mails would go to the > moderation que (i didnt check) That's possible; I don't see v3 or any of the newer versions on the = mailing list archive. Content-wise, the patch is the same since v2 I think, it's just been work = on the commit message. But I guess I can repost a version that I would be ok with getting = applied. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".