From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 95DA540CDD for ; Sat, 9 Apr 2022 18:45:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3D1C668B2FC; Sat, 9 Apr 2022 21:45:11 +0300 (EEST) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7CFF368B2CC for ; Sat, 9 Apr 2022 21:45:05 +0300 (EEST) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id 1FEBBE6801 for ; Sat, 9 Apr 2022 20:45:06 +0200 (CEST) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OFAlTiKcxlyY for ; Sat, 9 Apr 2022 20:45:04 +0200 (CEST) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id 63B5FE598E for ; Sat, 9 Apr 2022 20:45:04 +0200 (CEST) Date: Sat, 9 Apr 2022 20:45:04 +0200 (CEST) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: <20220406051146.1701100-1-tmatth@videolan.org> Message-ID: References: <20220406051146.1701100-1-tmatth@videolan.org> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/1] librtmp: make flashVer case consistent X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 6 Apr 2022, Tristan Matthews wrote: > This is basically a cosmetic change (no functional difference). > > --- > libavformat/librtmp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/librtmp.c b/libavformat/librtmp.c > index 43013e46e0..b23adb9593 100644 > --- a/libavformat/librtmp.c > +++ b/libavformat/librtmp.c > @@ -115,7 +115,7 @@ static int rtmp_open(URLContext *s, const char *uri, int flags) > if (ctx->app) len += strlen(ctx->app) + sizeof(" app="); > if (ctx->tcurl) len += strlen(ctx->tcurl) + sizeof(" tcUrl="); > if (ctx->pageurl) len += strlen(ctx->pageurl) + sizeof(" pageUrl="); > - if (ctx->flashver) len += strlen(ctx->flashver) + sizeof(" flashver="); > + if (ctx->flashver) len += strlen(ctx->flashver) + sizeof(" flashVer="); Actually this whole rtmp_open function should be reworked to use an AVBPrint buffer to generate the rtmp URL. The way it works now - calculating the length first then creating the actual sting - is very ugly. Regards, Marton _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".