From: Lynne via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: Lynne <dev@lynne.ee>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/aacps_tablegen_template: don't redefine CONFIG_HARDCODED_TABLES
Date: Thu, 1 Aug 2024 16:21:14 +0200
Message-ID: <ea66d427-95fb-4c04-b2ac-92cd72b48fc3@lynne.ee> (raw)
In-Reply-To: <20240731143508.8364-1-jamrial@gmail.com>
[-- Attachment #1.1.1.1: Type: text/plain, Size: 690 bytes --]
On 31/07/2024 16:35, James Almer wrote:
> Fixes relevant warnings when compiling with --enable-hardcoded-tables
>
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
> libavcodec/aacps_tablegen_template.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/libavcodec/aacps_tablegen_template.c b/libavcodec/aacps_tablegen_template.c
> index e70edf884b..e05887b9b1 100644
> --- a/libavcodec/aacps_tablegen_template.c
> +++ b/libavcodec/aacps_tablegen_template.c
> @@ -22,6 +22,8 @@
>
> #include <stdlib.h>
> #define BUILD_TABLES
> +#include "config.h"
> +#undef CONFIG_HARDCODED_TABLES
> #define CONFIG_HARDCODED_TABLES 0
> #include "aac_defines.h"
>
Sure, LGTM
[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 624 bytes --]
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-08-01 14:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 14:35 James Almer
2024-08-01 14:21 ` Lynne via ffmpeg-devel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea66d427-95fb-4c04-b2ac-92cd72b48fc3@lynne.ee \
--to=ffmpeg-devel@ffmpeg.org \
--cc=dev@lynne.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git