Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Tomas Härdin" <git@haerdin.se>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2 2/6] libavformat/sdp: remove whitespaces in fmtp
Date: Tue, 14 Nov 2023 21:51:59 +0100
Message-ID: <ea1d8486952afea7a5044750b1c06531f29fc240.camel@haerdin.se> (raw)
In-Reply-To: <1984886.bmAsdmbLKm@basile.remlab.net>

tis 2023-11-14 klockan 18:51 +0200 skrev Rémi Denis-Courmont:
> Le tiistaina 14. marraskuuta 2023, 17.47.07 EET Tomas Härdin a écrit
> :
> > tis 2023-11-07 klockan 15:12 +0100 skrev Michael Riedl:
> > > Whitespaces after semicolon breaks some servers
> > 
> > Which servers? If the spec allows whitespace then the onus is on
> > them
> > to fix their implementations.
> 
> I couldn't find any note to the effect that white spaces are allowed
> to separate 
> format parameters in RFC4566, but maybe I didn't look hard enough.
> 
> I think that most implementations just happen to ignore white-spaces,
> either 
> *because* some broken implementations like FFmpeg do send them, or
> just by 
> implementation accident.

It wouldn't be the first time FFmpeg did something wrong

Anyway I'm not formally against this patch, especially since it's not
something I maintain :)

/Tomas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-11-14 20:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-07 14:12 Michael Riedl
2023-11-14 15:47 ` Tomas Härdin
2023-11-14 16:14   ` Kieran Kunhya
2023-11-14 20:53     ` Tomas Härdin
2023-11-14 21:15       ` Kieran Kunhya
2023-11-14 16:51   ` Rémi Denis-Courmont
2023-11-14 20:51     ` Tomas Härdin [this message]
2023-11-15  2:24   ` Romain Beauxis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea1d8486952afea7a5044750b1c06531f29fc240.camel@haerdin.se \
    --to=git@haerdin.se \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git