From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 075C543643 for ; Sun, 19 Jun 2022 11:56:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D61BD68B581; Sun, 19 Jun 2022 14:56:39 +0300 (EEST) Received: from msg-6.mailo.com (ip-16.mailobj.net [213.182.54.16]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CF42E689B6B for ; Sun, 19 Jun 2022 14:56:33 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1655639793; bh=8GyEd2ww9rm+igbeY7ZuixXAHt/hxfO3/Ut2OrcjWcM=; h=X-EA-Auth:From:To:Date:Subject:MIME-Version:X-Mailer:Message-ID: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=ebb7D+f6jzzHtp0i+OiPILQSZifYYVfyL8sQ2KtFYcJEX5wrSm8/hCQmgqQvHDJL1 DmMqg5ZqgkFpNXpUVZUDjcx1TeIe9A1tSjPJb7f+Qy4pT0bybbfWtiHxhiKMdUgHAq RFh/ZD00JMj2PIiMFGFlq+NiucJwDcVF1qaX4WgU= Received: by www-7.mailo.com with http webmail; Sun, 19 Jun 2022 13:56:33 +0200 (CEST) X-EA-Auth: IXzSt95HZVgl/FfFBcqB3+ke9ERILNCyl7ZRACvIOcyWZQdZMsmfxlWIKtwclM+qMW37QjlkcO+7dzF2NbbfGaS3O/xmx+C9 From: nil-admirari@mailo.com To: ffmpeg-devel@ffmpeg.org Date: Sun, 19 Jun 2022 13:56:33 +0200 (CEST) X-Priority: 3 MIME-Version: 1.0 X-Mailer: COMS/EA22.05/r20220614 Message-ID: In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v17 1/5] libavutil: Add wchartoutf8(), wchartoansi(), utf8toansi() and getenv_utf8() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > This forces allocations and frees in scenarios where this is wholly > unnecessary. This can be avoided by adding a custom deallocator for > strings returned via getenv_utf8: Namely a define/wrapper around av_free > in the _WIN32 and a no-op else. Done: https://ffmpeg.org/pipermail/ffmpeg-devel/2022-June/297804.html Note, however, that the introduction of freeenv_utf8() doubles allocations and deallocations in vf_frei0r.c on Windows: https://ffmpeg.org/pipermail/ffmpeg-devel/2022-June/297802.html These additional memory operations can be avoided only with a whole bunch of new #ifdef _WIN32 and #if HAVE_GETENV, which haven't been done. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".