From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B9C4E42F49 for ; Wed, 15 Jun 2022 20:00:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1028F68B476; Wed, 15 Jun 2022 23:00:18 +0300 (EEST) Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 68B3468B4D2 for ; Wed, 15 Jun 2022 23:00:11 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1655323210; bh=x3T2+XSCpzn2d81NQYPwOZyEU7/xau01zdaq0q95ySo=; h=X-EA-Auth:From:To:Date:Subject:MIME-Version:X-Mailer:Message-ID: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=FL1/6M0xREquVyFOHVjkLdYfS6c4pXXLoTB8Uk0LPSDNdEG2zxsReR1ycQT4VkAHd 6leaXozHtHx0oXF8Txy+8uesGQ+j41MJjniLrGJqwKJHM1L54ndxAWsPiZTXlENva6 ZGYBPG2VtKahNree1qEabU4U6IfNLH5DMqVUk86Q= Received: by www-7.mailo.com with http webmail; Wed, 15 Jun 2022 22:00:10 +0200 (CEST) X-EA-Auth: FOYfhHTvNFkw4SkyQemKFM1QyCMngRfxr1MZZi4RKZtx2BNaSO4auLH4Ox9Bu67u6p78NNQJuWwDK3JegzAgKhoLIiJT0kYx From: nil-admirari@mailo.com To: ffmpeg-devel@ffmpeg.org Date: Wed, 15 Jun 2022 22:00:10 +0200 (CEST) X-Priority: 3 MIME-Version: 1.0 X-Mailer: COMS/EA22.05/r20220614 Message-ID: In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v14 2/5] compat/w32dlfcn.h: Remove MAX_PATH limit and replace LoadLibraryExA with LoadLibraryExW X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > path_size <= INT16_MAX > > (the edge case is already covered by the equals) Done: https://ffmpeg.org/pipermail/ffmpeg-devel/2022-June/297590.html. Don't quite understand what edge case you've meant: INT16_MAX is 32767, which is the maximal path length allowed, + 1 is needed for the terminating null. > I know this line existed before your path, but it would be nice > to clarify check and condition, like: > > // On Win7 an earlier we check if KB2533623 is available Changed the comment. > name_w leaks here Fixed. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".