From: nil-admirari@mailo.com
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v14 4/5] libavformat: Remove MAX_PATH limit and use UTF-8 version of getenv()
Date: Mon, 13 Jun 2022 22:53:24 +0200 (CEST)
Message-ID: <ea-mime-62a7a3c4-4b4c-268eb1cc@www-7.mailo.com> (raw)
In-Reply-To: <DM8P223MB036578A50471AEF16BD4987CBAAB9@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM>
> I like the version check. I don't know about all the derivatives
> of AviSynth, but I assume you have checked that it's valid for
> the common ones (or at least the original non-Plus variant)?
Interface version was changed to 7 in 2020:
https://github.com/AviSynth/AviSynthPlus/commit/40900dc1c54c14ea9f188c7242b88d464d067a44
three years after utf8 was implemented. If I'm not mistaken, there is no way to check
for a particular revision.
> Two ideas came to my mind how this could be done better.
> What's actually needed here is not a string conversion, we need
> a valid and usable filename, and the function could be more
> something like "get_ansi_filename()".
>
> The first thing that this function could do is to convert the
> the filename to ANSI and right back to UTF-8, then compare the
> UTF-8 result with the original UTF-8 string. When both are equal,
> we know that the conversion is safe, otherwise we know that it
> won't work.
>
> Then, we can use the win32 API GetShortFileName(). Which returns
> file and directory names in 8.3 notation which (IIRC) contains
> only letters which are valid in the ANSI code page.
>
> 8.3 file names do not always exist (depending on system config),
> but it's always worth trying.
>
> Should both of these procedures fail, we could at least output
> a useful message, explaining why it doesn't work.
>
> Let me know what you think.
Too much work for something that was fixed on AviSynth+ side two years ago.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-06-13 20:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 16:26 [FFmpeg-devel] [PATCH v14 1/5] libavutil: Add wchartoutf8(), wchartoansi(), utf8toansi() and getenv_utf8() Nil Admirari
2022-06-13 16:26 ` [FFmpeg-devel] [PATCH v14 2/5] compat/w32dlfcn.h: Remove MAX_PATH limit and replace LoadLibraryExA with LoadLibraryExW Nil Admirari
2022-06-13 16:39 ` Soft Works
2022-06-13 17:03 ` nil-admirari
2022-06-13 19:02 ` Soft Works
2022-06-13 20:17 ` Soft Works
2022-06-15 20:00 ` nil-admirari
2022-06-16 0:00 ` Soft Works
2022-06-17 9:33 ` nil-admirari
2022-06-13 16:26 ` [FFmpeg-devel] [PATCH v14 3/5] fftools: Remove MAX_PATH limit and switch to UTF-8 versions of fopen() and getenv() Nil Admirari
2022-06-13 16:26 ` [FFmpeg-devel] [PATCH v14 4/5] libavformat: Remove MAX_PATH limit and use UTF-8 version of getenv() Nil Admirari
2022-06-13 17:47 ` Soft Works
2022-06-13 18:55 ` Hendrik Leppkes
2022-06-13 19:00 ` Soft Works
2022-06-13 19:07 ` Stephen Hutchinson
2022-06-13 20:53 ` nil-admirari [this message]
2022-06-13 21:52 ` Soft Works
2022-06-13 22:01 ` Soft Works
2022-06-13 16:26 ` [FFmpeg-devel] [PATCH v14 5/5] libavfilter/vf_frei0r.c: Use " Nil Admirari
2022-06-13 20:50 ` [FFmpeg-devel] [PATCH v14 1/5] libavutil: Add wchartoutf8(), wchartoansi(), utf8toansi() and getenv_utf8() Martin Storsjö
2022-06-15 20:06 ` nil-admirari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea-mime-62a7a3c4-4b4c-268eb1cc@www-7.mailo.com \
--to=nil-admirari@mailo.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git