From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E4D2D4347D for ; Mon, 13 Jun 2022 16:43:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2B85168B36E; Mon, 13 Jun 2022 19:43:02 +0300 (EEST) Received: from msg-4.mailo.com (ip-15.mailobj.net [213.182.54.15]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BB62168B345 for ; Mon, 13 Jun 2022 19:42:55 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1655138575; bh=CKNo/XyP6WfuAvCt8YOPCz9iHtGLea5xHYORv099iYM=; h=X-EA-Auth:From:To:Date:Subject:MIME-Version:X-Mailer:Message-ID: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=ow2FROy3/7FtZZQsa9GQ2hq94iHuTF9a/Eqw7at7kqh9M1ggaHHCQzV7OuLRyObyA arrwWOLdmuWgNUijpqdPu5tN6xVgE/fhiATfGtQvdTpvqDFabm/U8P6ChGAyj++L6A a2eDmd6bkMRlIX7Vh0D27vba7wQ1cK7ISOUuJHRI= Received: by www-7.mailo.com with http webmail; Mon, 13 Jun 2022 18:42:55 +0200 (CEST) X-EA-Auth: uH8//20B3vZ4frL6Q6iIv0J5TLaw4EJICncDpa37/MxAe5esLXPHIPgXNqpTIDR4ZXps2ox9HCR2Kn0KxuUcDWccLmKeyJS/ From: nil-admirari@mailo.com To: ffmpeg-devel@ffmpeg.org Date: Mon, 13 Jun 2022 18:42:55 +0200 (CEST) X-Priority: 3 MIME-Version: 1.0 X-Mailer: COMS/EA21.01/r20220415 Message-ID: In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v8 0/3] Support long file names on Windows X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > ... > > - defining NO_DSHOW_STRSAFE in libavcodec/mf_utils.h > ... > Or if we'd add the define projectwide in e.g. configure it probably > wouldn't be that bad? Kinda like how we already add > "-D_CRT_SECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_WARNINGS" in MSVC builds. > Then we wouldn't need to worry about missing it somewhere accidentally. Ended up defining NO_DSHOW_STRSAFE in mf_utils.h, just like dshow_capture.h does (these are the only two uses). -D_CRT_SECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_WARNINGS are defined only for MVSC: elif test_${pfx}cpp_condition crtversion.h "defined _VC_CRT_MAJOR_VERSION"; then NO_DSHOW_STRSAFE should cover MinGW as well, and probably others. If you still want global NO_DSHOW_STRSAFE, please point where to add it exactly. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".