From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5440B433BC for ; Thu, 9 Jun 2022 19:19:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8117D68B7B2; Thu, 9 Jun 2022 22:19:09 +0300 (EEST) Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 65EFB68B6DD for ; Thu, 9 Jun 2022 22:19:03 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1654802342; bh=eFD0FWq280KG3dq16CPebCQc+Pil5FqzILsP5Yj+JYo=; h=X-EA-Auth:From:To:Date:Subject:MIME-Version:X-Mailer:Message-ID: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=fTH2Ju0/AaHtQfUfbdyL9LUgx1+6TGVb6wVtrkTg4anyZAHnp7j4pGCEfNDak3ngi LjyvlEektB1iLYo52m7D6IGhu+xE6fXnfPUCez7k7K3g7pIOwMaoH6ja06N/q3MxsT VTzUDnLUMBZBXJjPIFGwVwABep6RmBHyuJ5GLHa8= Received: by www-7.mailo.com with http webmail; Thu, 9 Jun 2022 21:19:02 +0200 (CEST) X-EA-Auth: 33WDNZDn9v+Cp50uc/z/UgTfWijmkMk03mn46M+GMmcMfq4H6Zy3HhOQDZfZOxVByjBiLovgV5pxR2zNMdtzfOwaa1IV/Zti From: nil-admirari@mailo.com To: ffmpeg-devel@ffmpeg.org Date: Thu, 9 Jun 2022 21:19:02 +0200 (CEST) X-Priority: 3 MIME-Version: 1.0 X-Mailer: COMS/EA21.01/r20220415 Message-ID: In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v12 1/4] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: >> I'm wondering why it converts wchar back to ansi instead of utf8 in 4/4 and >> whether it won't fail then, when a path contains non-ANSI chars. > > Yes, that's a preexisting problem there. That patch gets rid of the fixed > path lengths without touching the rest of the charset handling there. > > There's paths from two sources; getenv() and from GetModuleFileName(). > These are passed to plain fopen() (which uses ANSI filenames). > > To make it entirely unicode compliant, we'd need to replace getenv() with > a wrapper that uses _wgetenv() and converts that to utf8, then convert the > GetModuleFileName() output to utf8 too, and switch the fopen() to > fopen_utf8. Actually utf8toansi() was created for AviSynth, which doesn't have a Unicode API. getenv() and plain fopen() are used in cmdutils.c, which is the only file that haven't transitioned to avpriv_fopen_utf8() yet, but utf8toansi() is not used in cmdutils.c. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".