From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9787542AFE for ; Sun, 15 May 2022 19:36:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8E2B568B4C9; Sun, 15 May 2022 22:36:28 +0300 (EEST) Received: from msg-6.mailo.com (ip-16.mailobj.net [213.182.54.16]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AC7AE68B416 for ; Sun, 15 May 2022 22:36:21 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1652643381; bh=F3LngeErFDueDZcykTHZaL8gdZpSLgTN2S8anSY9koc=; h=X-EA-Auth:From:To:Date:Subject:MIME-Version:X-Mailer:Message-ID: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=LavtbOGjCi6Z7o43S0uCKWK0rjLp2KkoLKpkTf4wr2om265UY41BtbbvOZq/LC3TZ CplVi+bWtV75fB6+hYGJpjStfjEM4W5kGcTepUaJMnaneXbV1eb2syvHqVVI/w0Fvd HYnp+G263xI+nhUAi0aHJQBTbBXG/M67yeX8Y2aA= Received: by www-7.mailo.com with http webmail; Sun, 15 May 2022 21:36:21 +0200 (CEST) X-EA-Auth: qspQbIa0GCf8AyMufa/SiVlIf0eoiElWXhdWxtlgQirmjAHEqK0B0F7FCOBhYToifb7hlD0IgU6yftrONf5RBrTGQkc14ZZz From: nil-admirari@mailo.com To: ffmpeg-devel@ffmpeg.org Date: Sun, 15 May 2022 21:36:21 +0200 (CEST) X-Priority: 3 MIME-Version: 1.0 X-Mailer: COMS/EA21.01/r20220415 Message-ID: In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 0/2] Support long file names on Windows X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > I have kept the individual functions separate on purpose, to make it easy to > compare with the .NET impl. (compilers should inlinie those anyway) Calling add_extended_prefix without pre-validation results in error, since it does check for \\?\, \\.\, or \??\; only it's wrapper get_extended_win32_path does. And it's not private, it's in the header. path_normalize is a do nothing function. Keeping the comments about where the code originated from may be useful. Copying the structure of .NET results in problems. These patches are very difficult to review. E.g. stat is not covered: https://ffmpeg.org/pipermail/ffmpeg-devel/2022-May/296448.html. Parts of FFmpeg still use fopen instead of av_fopen_utf8. Some of these uses are in examples or tests or inside #ifdef DEBUG blocks. Others aren't: dvdsubdec.c:620 uses fopen and it is not covered by your previous patchset https://ffmpeg.org/pipermail/ffmpeg-devel/2022-May/296189.html. So please check that all uses of CRT functions that do I/O: https://docs.microsoft.com/en-us/cpp/c-runtime-library/stream-i-o?view=msvc-170 https://docs.microsoft.com/en-us/cpp/c-runtime-library/low-level-i-o?view=msvc-170 https://docs.microsoft.com/en-us/cpp/c-runtime-library/directory-control?view=msvc-170 https://docs.microsoft.com/en-us/cpp/c-runtime-library/file-handling?view=msvc-170 are actually covered (plus WinAPI functions as well). _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".