From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BBDB0423D1 for ; Sun, 15 May 2022 19:13:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2F6C568B49C; Sun, 15 May 2022 22:13:24 +0300 (EEST) Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 701E468B21B for ; Sun, 15 May 2022 22:13:17 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1652641996; bh=IBgqrWXjSnOHPr6ybQqKikUnKf2JBPYOxGb+ITqsc6Q=; h=X-EA-Auth:From:To:Date:Subject:MIME-Version:X-Mailer:Message-ID: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=IOLykS9Tz2lowNwUcBdaAZ5YsEUbugDEkcHcvIpvXeZL1qb5nljYGsZ65TF8TyXBU QSfoMPDfnOl/+NDdmqKxsqESoZdtZEriZAJuQllDlkdymFwyFANNuNlVSVCDPT7zd9 q+sjHcFoWw9RWom9FYiV27So+EOPK/XgqHGa42q0= Received: by www-7.mailo.com with http webmail; Sun, 15 May 2022 21:13:16 +0200 (CEST) X-EA-Auth: zHbDi8ofSfxmnWqZcdSknedwe3ychQiEyHFOoRvgWEYDhZNnAtfE9Yeb5fwFbLO/aUcUj/+uBwVBgWWmqz32NZf3UpVSCV5h From: nil-admirari@mailo.com To: ffmpeg-devel@ffmpeg.org Date: Sun, 15 May 2022 21:13:16 +0200 (CEST) X-Priority: 3 MIME-Version: 1.0 X-Mailer: COMS/EA21.01/r20220415 Message-ID: In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/os_support: Support long file names on Windows X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > diff --git a/libavformat/os_support.h b/libavformat/os_support.h In addition to what you've already added, this file defines stat as: #ifdef _WIN32 ... # ifdef stat # undef stat # endif # define stat _stati64 ... which is 1. not wide-char aware (_wstati64 does exist) 2. not long path aware. Also there is a function: static inline int is_dos_path(const char *path) { #if HAVE_DOS_PATHS if (path[0] && path[1] == ':') return 1; #endif return 0; } Now, DOS paths C:... end up being \\?\C:.... Are you sure it won't break something down the line? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".