From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8CABD42E8A for ; Wed, 11 May 2022 08:57:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9BA7B68B3AB; Wed, 11 May 2022 11:57:25 +0300 (EEST) Received: from msg-4.mailo.com (ip-15.mailobj.net [213.182.54.15]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9B45068B1B8 for ; Wed, 11 May 2022 11:57:19 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1652259438; bh=WoMftZVK3H6q63qTmfuWsUX+SxlMbQi0uh2VVOgSAOI=; h=X-EA-Auth:From:To:Date:Subject:MIME-Version:X-Mailer:Message-ID: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=Qayp4N0BlJmoB5206W/+AYJza7jmCv38YqY0xvZ7BVg5+uUy+WtSbYU5tCYsm0ipK jCcAOAZJ+snzbBefcFd1QR5ed8NcX5C/Tbx22VXfb1tqAhbLZRcJkZ4ofMPISsLsHP qZjLL9+iY5T0yzf4HQ/lV1Q95KA9V8kUN10KT/iU= Received: by www-7.mailo.com with http webmail; Wed, 11 May 2022 10:57:18 +0200 (CEST) X-EA-Auth: WG81LJn5w9z7wBzaaPXeXI4Qzt/rcFQfrLFYuwLErgk8xd5PAzkVpthOaFs8VaoVJJtYcikPZ8NjrcgCboDr1fl2mHbyoe5e From: nil-admirari@mailo.com To: ffmpeg-devel@ffmpeg.org Date: Wed, 11 May 2022 10:57:18 +0200 (CEST) X-Priority: 3 MIME-Version: 1.0 X-Mailer: COMS/EA21.01/r20220415 Message-ID: In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v11 1/6] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > I think that can be changed easily. How about writing the necessary patches yourself? > A path using forward slashes can still be prefixed with '\\?\' It cannot. Only backslashes are valid in \\?\ paths. > The prefixing can be implemented as a function and then be used > in file_open.c. > Other file system related functions like mkdir, rename, rmdir, etc. > are already intercepted in os_support.h, and the prefixing can be > applied there. I haven't found path concat in these headers. What I did find, however, is the use of snprintf with forward slash separators right inside the #ifdef _WIN32: #if defined(_WIN32) || defined (__ANDROID__) || defined(__DJGPP__) if (fd < 0) { snprintf(*filename, len, "./%sXXXXXX", prefix); fd = mkstemp(*filename); } #endif > I have not fully analyzed the situation, > but surely there are just a small number of places that need to > be changed and not 587. 587 was obtained with fgrep snprintf **/*.c | wc -l (became 588 after a recent pull). At least two of these uses of snprintf correspond to path concatenation, and have been already presented here. Not all of them do, but I have no interest in examining the other 586 cases. But if you think that it's easy, well go ahead. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".