From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D3995428E8 for ; Fri, 6 May 2022 16:08:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C13FB68B345; Fri, 6 May 2022 19:08:05 +0300 (EEST) Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B64C868B2A5 for ; Fri, 6 May 2022 19:07:59 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1651853279; bh=dtDOKb5YfrTbUmpKYwKNQ16gZlgWLuKv9WH/CKp4wEY=; h=X-EA-Auth:From:To:Date:Subject:MIME-Version:X-Mailer:Message-ID: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=OSfH8zaecVC7khhK4SjtCx7kQZTK+tbMxeJd8Ihc/s2u0+Tft4sqSgmzlAXAvdOHN N9Yb+VbeliIBGT7hZOIoEaHsy2qGdajkfV5E6R1QUE1jM8ApuYghGq3sy9x1RG67Wo DAsZCp5HKZkAEB/6X6qe6mc4Jl4we/uScKkx8yo0= Received: by www-7.mailo.com with http webmail; Fri, 6 May 2022 18:07:59 +0200 (CEST) X-EA-Auth: 7WHz/jJpDNeBzjv9YER2Ix/KQXZIZP90kJ90L+5S3w6cvEmXxSZYv/gUpHYfCeND6wBhvse11M70LAsu6QWRsCLef9oLiQpC From: nil-admirari@mailo.com To: ffmpeg-devel@ffmpeg.org Date: Fri, 6 May 2022 18:07:59 +0200 (CEST) X-Priority: 3 MIME-Version: 1.0 X-Mailer: COMS/EA21.01/r20220415 Message-ID: In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v11 1/6] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > > As a matter of fact, you are. Your alternative method implies > > ploughing > > through hundreds of C files normalising path handling across the > > entire application, > Almost everybody here knows that this isn't true. I do not. During the review of just this particular patchset it was found that FFmpeg sometimes uses av_fopen_utf8 and sometimes just plain fopen. Plain fopens were already replaced with av_fopen_utf8 and then reverted back. because suddenly it turned out that av_fopen_utf8 is problematic: https://ffmpeg.org/pipermail/ffmpeg-devel/2022-April/295488.html. At least in one place backward slashes are being replaced with forward slashes, which is not compatible with \\?\. But you can easily prove me wrong by showing me your patches. As a starting point: it was already shown how LLVM prefixes paths https://ffmpeg.org/pipermail/ffmpeg-devel/2022-April/295677.html. If that functionality is to be ported into FFmpeg, where exactly should the code go? Is there a Path struct, analogous to LLVM class, that all of FFmpeg is using? Or FFmpeg isn't using any special structs and paths are indistinguishable from ordinary strings? > Why should that be bad news for me? > Those are three very specific cases and we had already covered this. Because none of this is covered. They are covered by my patches, and you're against merging them. > My point is very simple: It should be a solution that will always > work and not just sometimes. Manifest works whether you like it or not. People without the registry setting do not have it for the simple reason of never having to work with long paths. And they most likely will enable it the first time such a need arises. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".