From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CF7EB42532 for ; Sat, 23 Apr 2022 21:17:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DA42A68B41E; Sun, 24 Apr 2022 00:17:39 +0300 (EEST) Received: from msg-6.mailo.com (ip-16.mailobj.net [213.182.54.16]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 13EBB68B301 for ; Sun, 24 Apr 2022 00:17:33 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1650748652; bh=Pr1qOGodyrnOkwFY2Op8UZDpc/lBxp5CNfDMtn7IN24=; h=X-EA-Auth:From:To:Date:Subject:MIME-Version:X-Mailer:Message-ID: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=ETfuf83oRGadskMiStw0GbOI+We+E79q6779aG2ABw3LOUYRX5n5khun8SGTMTiPe 3oBbiXOW6bJcj4h+dCp0+CxptP8wu0yRN5sAc+KgIIlf33WDDO04RvaRTwbjegkQx4 7RXqGsE7zQuH9a7H2Uq2h1tbLQ4m5q9RrCTZVwPU= Received: by www-7.mailo.com with http webmail; Sat, 23 Apr 2022 23:17:32 +0200 (CEST) X-EA-Auth: qMMW3Y6+aoGMAUdJDiSlWR2spOwtGG7rLNjUIWaC2sbz6fxaqm3WruVoril28bFj55CF34oQjyXJM3n4FQpmbkGi65Ado6YT From: nil-admirari@mailo.com To: ffmpeg-devel@ffmpeg.org Date: Sat, 23 Apr 2022 23:17:32 +0200 (CEST) X-Priority: 3 MIME-Version: 1.0 X-Mailer: COMS/EA21.01/r20220415 Message-ID: In-Reply-To: <4aa7a66c-605c-bed5-4d48-27b7481d5a58@martin.st> Subject: Re: [FFmpeg-devel] [PATCH v9 4/6] fftools/cmdutils.c: Remove MAX_PATH limit and replace fopen with av_fopen_utf8 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > > +#include "compat/w32dlfcn.h" > This adds a dependency on nonpublic headers - which I think can be > tolerated as it's only a build-time issue, and fftools are currently built > as part of the rest of the ffmpeg build anyway. Currently the header consist entirely of static inline functions and macros. If it's not OK to use it here, please suggest a better place for get_module_filename(). > > const char *base[3] = { getenv("FFMPEG_DATADIR"), > > getenv("HOME"), > > Hmm, I guess neither of these are commonly set on Windows - otherwise this > would suddenly change to interpret generic environment variables as UTF8. > > ... > > As mentioned elsewhere, I realized that av_fopen_utf8 is problematic, but > that's an orthogonal issue, and the issue is already preexisting, and it's > used for a fairly marginal feature here, so I guess that can be tolerated > too (and if the root cause is fixed, this gets taken care of at the same > time too). Reverted back to fopen(). _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".