From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EF66342520 for ; Sat, 23 Apr 2022 21:06:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0D27268B3E9; Sun, 24 Apr 2022 00:06:26 +0300 (EEST) Received: from msg-6.mailo.com (ip-16.mailobj.net [213.182.54.16]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 700FB68B2C9 for ; Sun, 24 Apr 2022 00:06:20 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1650747980; bh=OqW5igFxwCBQ3loOrrc3aJ3EO9yHsw2r1Myo9DRx6Ss=; h=X-EA-Auth:From:To:Date:Subject:MIME-Version:X-Mailer:Message-ID: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=Yk+BL/Qw3R6viXk5l42y87i3chNYNebVQqbDGOOFFo4R9ZaXHiuSfdZf8SNud7oAO lfWHSBPPOY8kvRuKagOtl1BifunS0DKT5YW+b6GmL5K0el1Ssk6YYfnk/dQhodM70U pU3uxZKDrk36fob0GkLV+0vFa0jdVxT3daJ3zR8k= Received: by www-7.mailo.com with http webmail; Sat, 23 Apr 2022 23:06:20 +0200 (CEST) X-EA-Auth: YCUq0HlFgGvaST1nybs4qHG/oypB1zljJ+Y55Z0Pj3RgQcOu+v9zGx7GllT/8hV/Wson77LlFJIJthqawSRMBw2CL6MuyR7F From: nil-admirari@mailo.com To: ffmpeg-devel@ffmpeg.org Date: Sat, 23 Apr 2022 23:06:20 +0200 (CEST) X-Priority: 3 MIME-Version: 1.0 X-Mailer: COMS/EA21.01/r20220415 Message-ID: In-Reply-To: <0fbd157-156f-d03a-a5d6-2fbd3c38dc78@martin.st> Subject: Re: [FFmpeg-devel] [PATCH v9 1/6] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > However while reviewing this, I noticed a preexisting issue regarding the > av_fopen_utf8 function. This patchset extends the use of that function > into fftools, which isn't great given the issue... Reverted back to fopen(). > The other question is whether it's tolerable to use more non-installed > headers (like libavutil/wchar_filename.h) in fftools. (I'd like to have > this point confirmed with Anton before landing the patchset.) Currently the header consist entirely of static inline functions. If it's not OK to use it here, please suggest a better place for these functions. > We don't generally use 'const' like this in ffmpeg; we use 'const' where > it makes a functional difference (i.e. on the type that pointers point > at), but not for plain scalar values (neither parameters nor local > variables). Removed const from everywhere except pointer arguments. > I think this actually would be more correct to use CP_ACP, not > CP_THREAD_ACP. Changed to CP_ACP. New version of the patch: https://ffmpeg.org/pipermail/ffmpeg-devel/2022-April/295569.html. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".