From: nil-admirari@mailo.com
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v9 1/6] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi
Date: Sat, 23 Apr 2022 23:06:20 +0200 (CEST)
Message-ID: <ea-mime-62646a4c-5a3f-4f93dcdd@www-7.mailo.com> (raw)
In-Reply-To: <0fbd157-156f-d03a-a5d6-2fbd3c38dc78@martin.st>
> However while reviewing this, I noticed a preexisting issue regarding the
> av_fopen_utf8 function. This patchset extends the use of that function
> into fftools, which isn't great given the issue...
Reverted back to fopen().
> The other question is whether it's tolerable to use more non-installed
> headers (like libavutil/wchar_filename.h) in fftools. (I'd like to have
> this point confirmed with Anton before landing the patchset.)
Currently the header consist entirely of static inline functions. If it's not OK to use it here,
please suggest a better place for these functions.
> We don't generally use 'const' like this in ffmpeg; we use 'const' where
> it makes a functional difference (i.e. on the type that pointers point
> at), but not for plain scalar values (neither parameters nor local
> variables).
Removed const from everywhere except pointer arguments.
> I think this actually would be more correct to use CP_ACP, not
> CP_THREAD_ACP.
Changed to CP_ACP.
New version of the patch: https://ffmpeg.org/pipermail/ffmpeg-devel/2022-April/295569.html.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-04-23 21:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 8:07 Nil Admirari
2022-04-15 8:07 ` [FFmpeg-devel] [PATCH v9 2/6] libavformat/avisynth.c: Remove MAX_PATH limit Nil Admirari
2022-04-20 11:32 ` Martin Storsjö
2022-04-23 21:11 ` nil-admirari
2022-04-15 8:07 ` [FFmpeg-devel] [PATCH v9 3/6] compat/w32dlfcn.h: Remove MAX_PATH limit and replace LoadLibraryExA with LoadLibraryExW Nil Admirari
2022-04-20 11:33 ` Martin Storsjö
2022-04-15 8:07 ` [FFmpeg-devel] [PATCH v9 4/6] fftools/cmdutils.c: Remove MAX_PATH limit and replace fopen with av_fopen_utf8 Nil Admirari
2022-04-20 11:39 ` Martin Storsjö
2022-04-23 21:17 ` nil-admirari
2022-04-15 8:07 ` [FFmpeg-devel] [PATCH v9 5/6] fftools: Enable long path support on Windows (fixes #8885) Nil Admirari
2022-04-20 11:46 ` Martin Storsjö
2022-04-23 21:21 ` nil-admirari
2022-04-20 11:31 ` [FFmpeg-devel] [PATCH v9 1/6] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi Martin Storsjö
2022-04-23 21:06 ` nil-admirari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea-mime-62646a4c-5a3f-4f93dcdd@www-7.mailo.com \
--to=nil-admirari@mailo.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git