From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BCF4D41D23 for ; Thu, 17 Feb 2022 16:44:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 751C468B343; Thu, 17 Feb 2022 18:44:47 +0200 (EET) Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 900B968B0E9 for ; Thu, 17 Feb 2022 18:44:40 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1645116279; bh=zCzG+WfU28Qyo4ZbpuUf9XZu88MkqXoP0CqoAhBr7tg=; h=X-EA-Auth:From:To:Date:Subject:MIME-Version:X-Mailer:Message-ID: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=ga4u7l/5MGqZnghPmI2EWQv59vUc0Vn+KPrfWAbCfc06TsJEMPbWZ59KDZ2aDErO6 7Nt8CuSbe1h8S+OXoX6kUlSWQX+5kCeo/oRkt028ayqPEEsA0dK/Cy4FQyhq2h8jJx aRH/hRLKzjW3TyJS0bt/TsWB5EOQiezX4IHpAAYc= Received: by www-7.mailo.com with http webmail; Thu, 17 Feb 2022 17:44:39 +0100 (CET) X-EA-Auth: J5DSsA6M2YOzvgO9qGZXymc+Em507Ixn4pN99WxbfCBU1iQywTlr0YtWM8maAGBUbQ2bZtHl/maUXZfP9xZQtPuWqEs6m1Di From: nil-admirari@mailo.com To: ffmpeg-devel@ffmpeg.org Date: Thu, 17 Feb 2022 17:44:39 +0100 (CET) X-Priority: 3 MIME-Version: 1.0 X-Mailer: COMS/EA21.01/r20211110 Message-ID: In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v3 4/5] fftools/cmdutils.c: Replace MAX_PATH-sized buffers with dynamically sized ones X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > if the path later is going to end up in a codepath that expects it to be UTF8 (please do check!), then we should go that way instead I checked. datadir ends up in (cmdutils.c:2104) base[2] = datadir; and base[*] are later used in (cmdutils.c:2112 or 2116) snprintf(filename, filename_size, "%s%s/%s.ffpreset", base[i], i != 1 ? "" : "/.ffmpeg", preset_name); f = fopen(filename, "r"); On Windows fopen expects ANSI encoded strings, so we cannot change the encoding to UTF-8 without rewriting the rest of the function. I've also overlooked something from your previous comment. > unless passing them to an external API Previous version of the manifest (https://ffmpeg.org/pipermail/ffmpeg-devel/2022-February/293109.html) included UTF-8 which makes CP_ACP the same as CP_UTF8. Unfortunately external APIs must also opt in for such a change, otherwise they won't be able to decode the strings FFmpeg sent them. A new version of the manifest without code page changes is at https://ffmpeg.org/pipermail/ffmpeg-devel/2022-February/293168.html. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".