From: nil-admirari@mailo.com
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v3 4/5] fftools/cmdutils.c: Replace MAX_PATH-sized buffers with dynamically sized ones
Date: Wed, 16 Feb 2022 17:32:02 +0100 (CET)
Message-ID: <ea-mime-620d2702-6980-8774c46@www-7.mailo.com> (raw)
In-Reply-To: <2294ea3c-2be6-e33d-146e-39434c2e570@martin.st>
Previously there was GetModuleFileNameA. wchartoansi is used to match old behaviour. I can replace it with wchartoutf8 if you wish.
> - if (GetModuleFileNameA(GetModuleHandleA(NULL), datadir, sizeof(datadir) - 1))
> + if (wchartoansi(datadir_w, &datadir))
> + datadir = NULL;
From: Martin Storsjö <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v3 4/5] fftools/cmdutils.c: Replace MAX_PATH-sized buffers with dynamically sized ones
Date: 16/02/2022 17:08:12 Europe/Moscow
Why would you use ansi here? Aren't all internal char based paths supposed
to be UTF-8, unless passing them to an external API that expects e.g. ACP
paths?
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-02-16 16:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 15:08 [FFmpeg-devel] [PATCH v3 1/5] libavutil/wchar_filename.h: Add wchartoansi and utf8toansi nihil-admirari
2022-02-16 15:08 ` [FFmpeg-devel] [PATCH v3 2/5] libavformat/avisynth.c: Replace MAX_PATH-sized buffers with dynamically sized ones nihil-admirari
2022-02-16 15:08 ` [FFmpeg-devel] [PATCH v3 3/5] compat/w32dlfcn.h: " nihil-admirari
2022-02-16 15:08 ` [FFmpeg-devel] [PATCH v3 4/5] fftools/cmdutils.c: " nihil-admirari
2022-02-16 16:08 ` Martin Storsjö
2022-02-16 16:32 ` nil-admirari [this message]
2022-02-16 16:50 ` Martin Storsjö
2022-02-17 16:44 ` nil-admirari
2022-02-18 20:09 ` Martin Storsjö
2022-02-19 10:10 ` nil-admirari
2022-02-16 15:08 ` [FFmpeg-devel] [PATCH v3 5/5] fftools: Enable long path support on Windows (fixes #8885) nihil-admirari
2022-02-17 16:29 ` [FFmpeg-devel] [PATCH v4] " nihil-admirari
2022-02-17 20:05 ` [FFmpeg-devel] [PATCH v3 5/5] " Marton Balint
2022-02-18 19:03 ` nil-admirari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea-mime-620d2702-6980-8774c46@www-7.mailo.com \
--to=nil-admirari@mailo.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git