From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4816E49C3E for ; Tue, 5 Mar 2024 15:07:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 23D0768D054; Tue, 5 Mar 2024 17:07:02 +0200 (EET) Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D7DF068D025 for ; Tue, 5 Mar 2024 17:06:55 +0200 (EET) Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-6e5e4b1d1f1so2167470b3a.1 for ; Tue, 05 Mar 2024 07:06:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709651214; x=1710256014; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KSAaoeOFR08gBgElEJ2q5c74NgPzb8zz4u0fnFMPMY8=; b=BhpdmRneIQa6Tui5cxB86y2eFrHfRTsbb/kexia6rXdXgvz7V4sbl1tN00kh2Et+z/ KvUsOUXZcozJB2p5A9xzxltkXEP5k1vMnSnlioyfzkPT/OMSn3btTRn3YdeNcUIfwxve uSWYZvYgVD7EPBE3Ki+ueOQkkroMiOcVldgw0BZCia21SsxJXeZCHnBeVv0cNoMCNLyI xHpe6nXXG6VPDQSR1URRIOUYNyB6ogowyv6iB3PWgW0lmTQ/juJ1HM08hh3TGRJR7jPn TUOtAaMZv3StJrUTWfJfndEclRBp/uEREofSpXhZofjVjkyFi0ONqdxXAv5gNt2vrxR8 bFVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709651214; x=1710256014; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KSAaoeOFR08gBgElEJ2q5c74NgPzb8zz4u0fnFMPMY8=; b=XDyMRNRGAC0v2P2dOttusH4BncuK9xnBmjGo3IS9KYsAi2py7waxHa9zaqm6LR3/qs MbNugvfHRkx3U/rGdLYh5p5j9bd8Jf+5ynUT89lNrgMzvXqctQNBXnui2J6DuR3TFVdM ulZFYpPAqwS+CYp1lwUzbvIMDciip8vUKnveOzw2kI3XIFPr8Hu0OodQdQ1nuasugJ2i kLJ3npnonmJegeDSxRKa3ZOu6USmwRSX0TDccxfSyihzsbpc0r+66rhgPgn68M0WOfSv x1v38nDhDfrl7Kc0EAI6c0D8RrGEvZKyeSnzxEq9G2DRJm57tC45qtyTxGd5V7s7vZPG 8M6w== X-Gm-Message-State: AOJu0YzWEQ8BNgDXrjvXc6zoOuHECuH50iF6a6Z61gisY3NxFXbauhvI kbLDC2WCn/OjJpITd0NnvtBefOnsJFvIwZ6Yvvf4sPL515zyf8n5R2XtBFxL X-Google-Smtp-Source: AGHT+IFoz/GkItQors0JH4mD/tdvMiZYQBMNI+5ZySsBLrOWoNTWYUBG46hHIqU8XvlqfZHfS/JIlw== X-Received: by 2002:a17:903:22ce:b0:1dd:8f6:69bf with SMTP id y14-20020a17090322ce00b001dd08f669bfmr3014589plg.26.1709651213570; Tue, 05 Mar 2024 07:06:53 -0800 (PST) Received: from [192.168.0.14] ([190.194.169.124]) by smtp.gmail.com with ESMTPSA id h4-20020a170902f54400b001d91d515dffsm10647015plf.156.2024.03.05.07.06.52 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Mar 2024 07:06:53 -0800 (PST) Message-ID: Date: Tue, 5 Mar 2024 12:07:05 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240304130657.30631-1-anton@khirnov.net> <20240304130657.30631-7-anton@khirnov.net> <6aeedda4-c8a7-4c4c-a33d-d2225508eeeb@gmail.com> <170964899292.29002.12504993650425451482@lain.khirnov.net> <8bf41fe7-a9f9-4ae4-abfc-31117ddae687@gmail.com> <170965045875.29002.15043263301458990476@lain.khirnov.net> From: James Almer In-Reply-To: <170965045875.29002.15043263301458990476@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 07/29] lavc: add a decoder option for configuring side data preference X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/5/2024 11:54 AM, Anton Khirnov wrote: > Quoting James Almer (2024-03-05 15:35:02) >> On 3/5/2024 11:29 AM, Anton Khirnov wrote: >>> Quoting James Almer (2024-03-05 13:30:58) >>>>> + {"dynamic_hdr10_plus", .default_val.i64 = AV_PKT_DATA_DYNAMIC_HDR10_PLUS, .type = AV_OPT_TYPE_CONST, .flags = A|D, .unit = "side_data_pkt" }, >>>> >>>> This one packet/frame level only, not global. >>> >>> It is in sd_global_map >> >> Then that's a mistake, and I'm probably he culprit. HDR10+ is per frame >> metadata. Static HDR metadata are mastering_display and ccl. > > Ok, dropped from the options table locally. > >> >>> >>>> Is this option meant to also choose which one of those to use? >>> >>> ??? >> >> You can have packet side data at the container level that corresponds to >> the same thinga per frame side data at the bitstream level does. In >> HDR10+ case, Matroska may have it in block additional, and then afaik it >> could be present in the hevc bitstream. >> One of them should have priority, or the user could be given the choice. > > Right, I've thought about this a bit, but then couldn't find any side > data types that some container could export per-packet AND could also be > present in the bitstream. Aside from HDR10+, I'm sure this scenario can also happen with closed captions. > > One possible solution is to rename the option to something like > side_data_prefer_external (better names welcome), and have it switch > between user-supplied (i.e. global or per-packet) and in-bitstream side > data. > > This adds an ambiguity for the hypothetical case where some side data > exists as global and per-packet - then I'd say lavc should default to > per-packet and leave the other case to the caller (should be very rare, > possibly could be handled with a bitstream filter). If a given side data type at the container level were to be duplicated in the header (global) and per packet, then IMO the packet must have priority, given it's the container overriding its own parameters. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".