From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F25194332F for ; Wed, 1 Jun 2022 16:30:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7519F68B6F3; Wed, 1 Jun 2022 19:30:44 +0300 (EEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3F57568B698 for ; Wed, 1 Jun 2022 19:30:36 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654101042; x=1685637042; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=WC3bbbScXOTW+Oz9iYYK5hhpc1mA2/iKGy1fCYTbbVc=; b=bIVE3OPF8h6LimjggCaeu5NdngdlyxQ3riUPMYmKYVd4smH2bppwDas2 OgJy3NVJhPilffcWyXCCD9CWrf32yxaMtyHr3nBY7tMgDheOm0R1i94r9 OmSS3o+kW4rZM05bNPFyYB0ASaCmwd//Ivo5TcOJB0f2SB2IoiwrUYyzx oQsjN6iRWJWNZzf4XdbUNnNmmG5btrQrkjx4tjcpwkcw/174sA2I4gHTX 9/xmjBdFNqEixwWo2Xz7d+lX5O1z+5WxeoU0GgSwu1gU5cg5hdhamjdet gbKwy/QvSZs7X9rpa2fgCKL4AdW52I3CexJ1pPSl+hE6cGCWr/XQpTwGs w==; X-IronPort-AV: E=McAfee;i="6400,9594,10365"; a="301003625" X-IronPort-AV: E=Sophos;i="5.91,268,1647327600"; d="scan'208";a="301003625" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2022 09:30:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,268,1647327600"; d="scan'208";a="756290779" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga005.jf.intel.com with ESMTP; 01 Jun 2022 09:30:05 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 1 Jun 2022 09:30:04 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 1 Jun 2022 09:30:04 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 1 Jun 2022 09:30:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BNuiIw6+y+vmiZne+qHJJm5mIp2tNvLwVzyr+xdlDjE93jBB7lablf6gPzmrZpLSQguBp70MVCF8y+2Ep09GGNZkKK6sROeUZtzwMeg50RMfBaKjyY+zN5uECuSxIoBr0hgwR+A8AM5pxycIkFCvnvnomAAqcsdeqCXHBgH1iiuRqdyECd/6tp5R5d9MwYHhVUD9bF18qrAtzMHeUBn6p48f+YhKitbXXrSYiMc618IC5RztFITHFBUW5edoPUWyiI3jYcDsXHc0KmMLC0FAy7BHuVAo9QnA4HfVr3x8i8TupdHWs6iaBrPx9Of0i2sko9Rz72JxNVZr47CsZNcpew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WC3bbbScXOTW+Oz9iYYK5hhpc1mA2/iKGy1fCYTbbVc=; b=T7E8FKPIk3xBmvZNsZFYG+hCXghAmzVBjJNOftuEIbrDWSWeza7EhXz++DBLb0mEq2JrK7ZRXbxIAeK6GSNO0qRPPsuKFAQdRpvmTP3hs5CrILjardBYSPFlsDzUDq9so3bNsdrRr6A/ltnrzVUM4g20jubnqnAeLEiCXZ/7Td/rYtukITU0w+OmmBaX3YQ7s1KOCQI/YmBX4y1CLVg2oiGBwx1aFxV7/J8xyZfd8wfKAgu6X2sBUmZG8IOrUR+qLth9JZ/nAPEwlwmWzQggq8FseTiCtc72wIaTzDXKIr3IVRtsvox1oMaebGau6xpi/l36gRNMHMcjVCQ1mFm6hQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by DM4PR11MB6334.namprd11.prod.outlook.com (2603:10b6:8:b5::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Wed, 1 Jun 2022 16:30:02 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::2d06:ec38:937a:da73]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::2d06:ec38:937a:da73%6]) with mapi id 15.20.5314.013; Wed, 1 Jun 2022 16:30:02 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH] libavcodec/qsvenc: add ROI support to qsv encoder Thread-Index: AQHYYQ1A5EcMqhzTo02sd4VYDAotlK0655AA Date: Wed, 1 Jun 2022 16:30:02 +0000 Message-ID: References: <20220506054957.2291057-1-wenbin.chen@intel.com> In-Reply-To: <20220506054957.2291057-1-wenbin.chen@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 64d30a5c-0b8a-49ff-7ee0-08da43ebfa98 x-ms-traffictypediagnostic: DM4PR11MB6334:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Gnsro3yUyQ5yi1vbqLSpw3h1WVJ93HgbdsO1Xj8DsM6Ned6g5eOQoHNgL927HQIl9N5LYhG7tX5opfn8BbbXirjMGaiP9+jakgV70V+xGbEn2/oY+/ERD8SSo9C2sq3AYEnBkXh7+mZLFUSNTg0nNXDmA4Uo0vg4rR0tE1HHbfwQjcRpYZDyHspiFqms60SnbkUGKNGqRvevu4Rpe6qgrbp17hG61/ybBxznmqNraRZUjXTcrWSRCVbrdw9s3o94EixyRG0pJI/QH9e0JL8R6Y0hnNHAqTxAZmWXLsSHvA1RzYFPsqszKzsSwZnAGdx+aw8GX1XUTleYPX1lCkwLR8x5T5C2KUC2aENpIkYEEM0BSpqlDkPEUe45E5iCKNKi/zxmXVI1Yzb+3Sek6xCGlwmk6KOuYounH2C2pc3paWvwSoOYgFpIXUYUpCnbF0EniJEFGnOO5dKl9E4AoDl7VlhfbSbG5n8BI8WANI9rADn7zSFKqmBrbr4oLw4t7ffTbmeN5lwwxBCTZpKmSNhNod+iI/gruUkLuEwng5kfexajEAQLJSTGWFnuhumsnaakJROIpWIgL9yUsxLefaViVaKFeYwD/ayPzsQJsl97tRYrPHlPX70JOUaIgmZi8cRqdBZ7diK4GgsuncRhqEeaI7HCvyKiDuY3oqD0UJAUcx4oa232FuJZmDxYWtMnuwY7c3tJwd4e3vtvd8YW7XKzfUHVCoSWAw9oy2jp/FS3gv4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(2616005)(83380400001)(66946007)(186003)(66476007)(66446008)(64756008)(66556008)(76116006)(8676002)(86362001)(2906002)(91956017)(82960400001)(122000001)(38100700002)(8936002)(38070700005)(508600001)(71200400001)(5660300002)(36756003)(6486002)(26005)(6512007)(6916009)(6506007)(316002)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?a0lJZStOLzlqWWRmaGVHNWpmMFQzbDRjMHZBUFc2aWc3eStyUVJEZW1IcXRI?= =?utf-8?B?dmpQU0Vac04rSFRCTEg4S0gxWjFrSmlhakdCVytwZ3VJWDZ2UDk0Y1pNalli?= =?utf-8?B?djU4MDRtY2owbzdCcEhTeEYyZGJGMjR1bzJzWEp6K2pGMUEyQ0dkYmlZdkI3?= =?utf-8?B?cXowYllxVGNlNkkyQ2ZJdEsyOVNBZW9zYjVkaHFUM1dkZkVZMElZZGRYd3hF?= =?utf-8?B?WkQzWGszTW5XY3djNW15OWVNY05qck5XN0VZU3ptRUd1YXFKdU1YUzNUbTlM?= =?utf-8?B?UFZLa3A0T3Y4K1JpL24vbGdFZU9QcWo4QzJvSEV0S0FsQWIvN0Y3V081ejZw?= =?utf-8?B?NGlpd09yREJ0Z3ZSdGFhQmZpWncza2orTWp6OVBON09zeVFrRG9OWC9hSzNM?= =?utf-8?B?eHpKcXN2NFB6ejVWY3Q4bkpzQXNEV2hGM3NXMG41b3Rkc0ppVXI2Rk5qNnZY?= =?utf-8?B?ZCs5WTZDUnVoS0owNnhPdjBSVHd6YmFLSkhWc0dMSStsM21vbDJsUjRSemJz?= =?utf-8?B?bWdwYlVkazdQbDlUc0xrR1FDbjczdFA2TERFRkJkRTFuZmR2MldzK0c3TGVm?= =?utf-8?B?VjQ0YkxPOTRWMUhwNlhCNHkzTXBaVE9HVTRHN053NHc4aDJ5QzB3WVBOSjB6?= =?utf-8?B?REx0MkhqSW9wQzJHdFM0ZGVBM0FaWThpYzk1UWFLSXdtNjk3TEpOUGtHdWs5?= =?utf-8?B?ZC9jdHdnRzdKb3BjYyt3a0svKzA1RzQ2VG01a0oxRGZ1VUlkUS9QemRVdG51?= =?utf-8?B?RUN4T0N4akZib1NUYVFUN2VqUTNwS3Z6YW1ZSXY1TDRBYW9QTUJCM3U1eFlm?= =?utf-8?B?cU5RTW1BSjZGdVF0ejJpLzV1NU5YMTJHaUJlV25KeTlyTFkxK1hFU2pNZFJF?= =?utf-8?B?NWJKUi9iKzZvZEFIVkk2V2k1cFZsNWpUbEFMZ2lWREhiUE00b0pHaXNVVE56?= =?utf-8?B?SEcxQ1h6UXN1bTc1ZGVmNWh1a3NLcjd3SHdYTlRra3lOVGZVVGVaTy9UYVBi?= =?utf-8?B?dlhub3BHY2tIem5keVBScVJkRHFFN0lVbDNTd2I2RzYxZlg2QWNiWjFBOENV?= =?utf-8?B?dzlQRVN6eGJyWVF0QUZoa0FlRE56aFJUWEVvNXk5RVY0cVFISTRmSUFxM0pF?= =?utf-8?B?cEtnaE1Sbm1EcHg5ak42bFZKcm5tZUx0V3JCTGY5K2JGZkdwQTh6MnI0UGoz?= =?utf-8?B?NDNFelRzZkpqbHpsbE1RUFRITllCSVJ3TkkvdXB2NjY3aE56Zk9wSmMxaloy?= =?utf-8?B?MSs4SzFzRzJBQnFoRnZUOCs1LzlBWFl6dUFFdnpnTmw1aVhWeWJaQVd1djhh?= =?utf-8?B?SVlPRmNoVDVnOEFMWnhzKzFWS3NQbXMrK2lDU3I3OVRyeWlJYlJyODNDUndX?= =?utf-8?B?MVVLV2hac3hPVDFBalFHa1pmSHpXRmZtN1N4K2FKMXFYdHA1cWhGMCtTbGRv?= =?utf-8?B?aUluQS9yQStyUWVINEJ3d2RqRk54a3BoRVRUV21sRDZEcFUydHZuelFDU3hH?= =?utf-8?B?WUN0aXo1S0VPWXlDdGN5MEtDN25VNmg1ZC9wWlJUdE5LZTVQbXVSY2JXeWZX?= =?utf-8?B?UTJ5OGlkUTJ2MUNQQVFUbGtyVHl3cTFLeWtPUUVVckhTYzcrYnBJT1pVYjc0?= =?utf-8?B?NUlpeXlkNHRscVp5U0hkQUQ4eDRkeU5IM2gvSzRjTHlhZUJxaDQyUUJnSWdT?= =?utf-8?B?NkxBREl4VTUxZUtUTjhtU1Q2SGVIQUdDQmw4c0IzQ1FjbUpqSXJiVnd3azVN?= =?utf-8?B?VHNkZ1NKcC9kbEtRUlpCNVlhNUVDcFBnNlVpNmVpZGpuVWxyeW5NbnV6d0Qx?= =?utf-8?B?Tmp5bmlzeU1LYWJ6T1NPRnRneFlFcmJIT1FwRDNHWEF2VVBLcTdpN1N6RmZM?= =?utf-8?B?ZmVCRFVJam42cXFscysrWmJkUmtsS0JOTldibXJ4YWVTY2paTm5GT1p3ekFN?= =?utf-8?B?aUliaExJRDhBSXpzMUhaWGI5b0JscmgwM3hIbUNWVnNRcnNUN21mUlJrZXdC?= =?utf-8?B?aXVmTzlhZXNsUUhodU9MN2VCcnVHTE1MVGNxd2ZwSUlhcHZHaWVKZkFQNVBo?= =?utf-8?B?ZGw3WjBuMXdvaG8wcGd3YjliVXMrYVpJUVJ4aGNpcUJEckg3TmFFMkJyYlM4?= =?utf-8?B?Q1p2YzNKeDArWlJXSG1yRVB2bU4zSnRFL2VkUHhNeEhGUGttdVlROVdBTUcx?= =?utf-8?B?SXBNNnVIWlAydnEwOW04azZJUWdyZVNxSnZRa2JnM093cC81djlIT1cvRkFY?= =?utf-8?B?NDA2UEE2T3I0MDgyNXA0bzVwUTJVeEJHdG9UNGtyMWw5Q3pQb05ON0hRN3c2?= =?utf-8?B?UnBjSVdEbEkzak5WTzRSQlpPYlluaWhEZVNnczNTbm95aEYrUjU4VlA0SVVZ?= =?utf-8?Q?biXuYFTJv7Q+9KdU=3D?= Content-ID: <580B09CE1D253444AF7E7B94E9FD533C@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 64d30a5c-0b8a-49ff-7ee0-08da43ebfa98 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jun 2022 16:30:02.6550 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FsjHGXkNjHJO45m8ODW13VwpAkcgfTqNQE6WAwfTRhZPFzIkPlzPpdPRCG8Kzv4QFfsGD2GxeogJQRzplClp2Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6334 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc: add ROI support to qsv encoder X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 2022-05-06 at 13:49 +0800, Wenbin Chen wrote: > Use the mfxEncoderCtrl parameter to enable ROI. Get side data > "AVRegionOfInterest" > from filter "addroi" and use it to configure "mfxExtEncoderROI" which is > the MediaSDK's ROI configuration. > > Signed-off-by: Wenbin Chen > --- > libavcodec/qsv_internal.h | 4 ++ > libavcodec/qsvenc.c | 88 +++++++++++++++++++++++++++++++++++++++ > 2 files changed, 92 insertions(+) > > diff --git a/libavcodec/qsv_internal.h b/libavcodec/qsv_internal.h > index e2aecdcbd6..8131acdae9 100644 > --- a/libavcodec/qsv_internal.h > +++ b/libavcodec/qsv_internal.h > @@ -51,6 +51,9 @@ > #define ASYNC_DEPTH_DEFAULT 4 // internal parallelism > > #define QSV_MAX_ENC_PAYLOAD 2 // # of mfxEncodeCtrl payloads supported > +#define QSV_MAX_ENC_EXTPARAM 2 > + > +#define QSV_MAX_ROI_NUM 256 > > #define QSV_MAX_FRAME_EXT_PARAMS 4 > > @@ -83,6 +86,7 @@ typedef struct QSVFrame { > int num_ext_params; > > mfxPayload *payloads[QSV_MAX_ENC_PAYLOAD]; ///< used for enc_ctrl.Payload > + mfxExtBuffer *extparam[QSV_MAX_ENC_EXTPARAM]; ///< used for > enc_ctrl.ExtParam > > int queued; > int used; > diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c > index fbb22ca436..9abead604b 100644 > --- a/libavcodec/qsvenc.c > +++ b/libavcodec/qsvenc.c > @@ -1501,15 +1501,29 @@ static void free_encoder_ctrl_payloads(mfxEncodeCtrl* > enc_ctrl) > } > } > > +static void free_encoder_ctrl_extparam(mfxEncodeCtrl* enc_ctrl) > +{ > + if (enc_ctrl) { > + int i; > + for (i = 0; i < enc_ctrl->NumExtParam && i < QSV_MAX_ENC_EXTPARAM; > i++) { > + if (enc_ctrl->ExtParam[i]) > + av_freep(&(enc_ctrl->ExtParam[i])); > + } > + enc_ctrl->NumExtParam = 0; > + } > +} > + > static void clear_unused_frames(QSVEncContext *q) > { > QSVFrame *cur = q->work_frames; > while (cur) { > if (cur->used && !cur->surface.Data.Locked) { > free_encoder_ctrl_payloads(&cur->enc_ctrl); > + free_encoder_ctrl_extparam(&cur->enc_ctrl); > //do not reuse enc_ctrl from previous frame > memset(&cur->enc_ctrl, 0, sizeof(cur->enc_ctrl)); > cur->enc_ctrl.Payload = cur->payloads; > + cur->enc_ctrl.ExtParam = cur->extparam; > if (cur->frame->format == AV_PIX_FMT_QSV) { > av_frame_unref(cur->frame); > } > @@ -1547,6 +1561,7 @@ static int get_free_frame(QSVEncContext *q, QSVFrame > **f) > return AVERROR(ENOMEM); > } > frame->enc_ctrl.Payload = frame->payloads; > + frame->enc_ctrl.ExtParam = frame->extparam; > *last = frame; > > *f = frame; > @@ -1648,6 +1663,70 @@ static void print_interlace_msg(AVCodecContext *avctx, > QSVEncContext *q) > } > } > > +static int set_roi_encode_ctrl(AVCodecContext *avctx, const AVFrame *frame, > + mfxEncodeCtrl *enc_ctrl) > +{ > +#if QSV_VERSION_ATLEAST(1, 22) This check can be removed now because the minimal version is 1.28 > + AVFrameSideData *sd = NULL; > + int mb_size; > + > + if (avctx->codec_id == AV_CODEC_ID_H264) { > + mb_size = 16; > + } else if (avctx->codec_id == AV_CODEC_ID_H265) { > + mb_size = 32; > + } else { > + return 0; > + } > + > + if (frame) > + sd = av_frame_get_side_data(frame, > AV_FRAME_DATA_REGIONS_OF_INTEREST); > + > + if (sd) { > + mfxExtEncoderROI *enc_roi = NULL; > + AVRegionOfInterest *roi; > + uint32_t roi_size; > + int nb_roi, i; > + > + roi = (AVRegionOfInterest *)sd->data; > + roi_size = roi->self_size; > + if (!roi_size || sd->size % roi_size) { > + av_log(avctx, AV_LOG_ERROR, "Invalid ROI Data.\n"); > + return AVERROR(EINVAL); > + } > + nb_roi = sd->size / roi_size; > + if (nb_roi > QSV_MAX_ROI_NUM) { > + av_log(avctx, AV_LOG_WARNING, "More ROIs set than " > + "supported by driver (%d > %d).\n", > + nb_roi, QSV_MAX_ROI_NUM); > + nb_roi = QSV_MAX_ROI_NUM; > + } > + > + enc_roi = av_mallocz(sizeof(*enc_roi)); > + if (!enc_roi) > + return AVERROR(ENOMEM); > + enc_roi->Header.BufferId = MFX_EXTBUFF_ENCODER_ROI; > + enc_roi->Header.BufferSz = sizeof(*enc_roi); > + enc_roi->NumROI = nb_roi; > + enc_roi->ROIMode = MFX_ROI_MODE_QP_DELTA; > + for (i = 0; i < nb_roi; i++) { > + roi = (AVRegionOfInterest *)(sd->data + roi_size * i); > + enc_roi->ROI[i].Top = FFALIGN(roi->top, mb_size); > + enc_roi->ROI[i].Bottom = FFALIGN(roi->bottom, mb_size); > + enc_roi->ROI[i].Left = FFALIGN(roi->left, mb_size); > + enc_roi->ROI[i].Right = FFALIGN(roi->right, mb_size); > + enc_roi->ROI[i].DeltaQP = > + roi->qoffset.num * 51 / roi->qoffset.den; > + av_log(avctx, AV_LOG_DEBUG, "ROI: (%d,%d)-(%d,%d) -> %+d.\n", > + roi->top, roi->left, roi->bottom, roi->right, > + enc_roi->ROI[i].DeltaQP); > + } > + enc_ctrl->ExtParam[enc_ctrl->NumExtParam] = (mfxExtBuffer *)enc_roi; You should ensure the runtime supports MFX_EXTBUFF_ENCODER_ROI when adding MFX_EXTBUFF_ENCODER_ROI buffer to enc_ctrl->ExtParam[]. Thanks Haihao > + enc_ctrl->NumExtParam++; > + } > +#endif > + return 0; > +} > + > static int encode_frame(AVCodecContext *avctx, QSVEncContext *q, > const AVFrame *frame) > { > @@ -1714,6 +1793,14 @@ static int encode_frame(AVCodecContext *avctx, > QSVEncContext *q, > q->set_encode_ctrl_cb(avctx, frame, &qsv_frame->enc_ctrl); > } > > + if ((avctx->codec_id == AV_CODEC_ID_H264 || > + avctx->codec_id == AV_CODEC_ID_H265) && > + enc_ctrl) { > + ret = set_roi_encode_ctrl(avctx, frame, enc_ctrl); > + if (ret < 0) > + goto free; > + } > + > pkt.sync = av_mallocz(sizeof(*pkt.sync)); > if (!pkt.sync) > goto nomem; > @@ -1842,6 +1929,7 @@ int ff_qsv_enc_close(AVCodecContext *avctx, > QSVEncContext *q) > while (cur) { > q->work_frames = cur->next; > av_frame_free(&cur->frame); > + free_encoder_ctrl_extparam(&cur->enc_ctrl); > free_encoder_ctrl_payloads(&cur->enc_ctrl); > av_freep(&cur); > cur = q->work_frames; _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".