Re: [FFmpeg-devel] [PATCH 6/7] avformat: add s337m support in mpegts, wav and mxf stereo tracks

Re: [FFmpeg-devel] [PATCH 6/7] avformat: add s337m support in mpegts, wav and mxf stereo tracks

[Tomas Härdin]

ons 2024-12-04 klockan 15:14 +0100 skrev ffnicolasg@sfr.fr:
> --- a/libavformat/mxfdec.c
> +++ b/libavformat/mxfdec.c
> @@ -634,7 +634,7 @@ static int mxf_get_d10_aes3_packet(AVIOContext *pb, AVStream *st, AVPacket *pkt,
>      for (; end_ptr - buf_ptr >= st->codecpar->ch_layout.nb_channels * 4; ) {
>          for (int i = 0; i < st->codecpar->ch_layout.nb_channels; i++) {
>              uint32_t sample = bytestream_get_le32(&buf_ptr);
> -            if (st->codecpar->bits_per_coded_sample == 24)
> +            if (av_get_bits_per_sample(st->codecpar->codec_id) == 24)
>                  bytestream_put_le24(&data_ptr, (sample >> 4) & 0xffffff);
>              else
>                  bytestream_put_le16(&data_ptr, (sample >> 12) & 0xffff);
> @@ -3080,7 +3080,12 @@ static int mxf_parse_structural_metadata(MXFContext *mxf)
>              } else if (st->codecpar->codec_id == AV_CODEC_ID_AAC) {
>                  sti->need_parsing = AVSTREAM_PARSE_FULL;
>              }
> -            st->codecpar->bits_per_coded_sample = av_get_bits_per_sample(st->codecpar->codec_id);
> +            if (st->codecpar->codec_id == AV_CODEC_ID_PCM_S16LE
> +             || st->codecpar->codec_id == AV_CODEC_ID_PCM_S24LE) {
> +                FFStream *const sti = ffstream(st);
> +                sti->request_probe = AVPROBE_SCORE_EXTENSION;
> +                sti->need_parsing  = AVSTREAM_PARSE_FULL;
> +            }

Looks OK

Sorry for the late review

/Tomas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 6/7] avformat: add s337m support in mpegts, wav and mxf stereo tracks

[Nicolas Gaullier]

>De : ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> de la part de Tomas Härdin <git@haerdin.se>
>Envoyé : mercredi 5 février 2025 15:47
>Objet : Re: [FFmpeg-devel] [PATCH 6/7] avformat: add s337m support in mpegts, wav and mxf stereo tracks
>
>Looks OK
>
>Sorry for the late review
>
>/Tomas

Thanks to you, good to know; nevertheless, the patch serie is shelved because of red flags, so there will not be any follow up on the ml at the moment.

Nicolas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".