From: "Tomas Härdin" <git@haerdin.se>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 6/7] avformat: add s337m support in mpegts, wav and mxf stereo tracks
Date: Wed, 05 Feb 2025 15:47:00 +0100
Message-ID: <e8f05991de945d1f5f8c2d3490e41f14912b45a3.camel@haerdin.se> (raw)
In-Reply-To: <20241204141409.859670-7-ffnicolasg@sfr.fr>
ons 2024-12-04 klockan 15:14 +0100 skrev ffnicolasg@sfr.fr:
> --- a/libavformat/mxfdec.c
> +++ b/libavformat/mxfdec.c
> @@ -634,7 +634,7 @@ static int mxf_get_d10_aes3_packet(AVIOContext *pb, AVStream *st, AVPacket *pkt,
> for (; end_ptr - buf_ptr >= st->codecpar->ch_layout.nb_channels * 4; ) {
> for (int i = 0; i < st->codecpar->ch_layout.nb_channels; i++) {
> uint32_t sample = bytestream_get_le32(&buf_ptr);
> - if (st->codecpar->bits_per_coded_sample == 24)
> + if (av_get_bits_per_sample(st->codecpar->codec_id) == 24)
> bytestream_put_le24(&data_ptr, (sample >> 4) & 0xffffff);
> else
> bytestream_put_le16(&data_ptr, (sample >> 12) & 0xffff);
> @@ -3080,7 +3080,12 @@ static int mxf_parse_structural_metadata(MXFContext *mxf)
> } else if (st->codecpar->codec_id == AV_CODEC_ID_AAC) {
> sti->need_parsing = AVSTREAM_PARSE_FULL;
> }
> - st->codecpar->bits_per_coded_sample = av_get_bits_per_sample(st->codecpar->codec_id);
> + if (st->codecpar->codec_id == AV_CODEC_ID_PCM_S16LE
> + || st->codecpar->codec_id == AV_CODEC_ID_PCM_S24LE) {
> + FFStream *const sti = ffstream(st);
> + sti->request_probe = AVPROBE_SCORE_EXTENSION;
> + sti->need_parsing = AVSTREAM_PARSE_FULL;
> + }
Looks OK
Sorry for the late review
/Tomas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next parent reply other threads:[~2025-02-05 14:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241204141409.859670-1-ffnicolasg@sfr.fr>
[not found] ` <20241204141409.859670-7-ffnicolasg@sfr.fr>
2025-02-05 14:47 ` Tomas Härdin [this message]
2025-02-06 10:05 ` Nicolas Gaullier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8f05991de945d1f5f8c2d3490e41f14912b45a3.camel@haerdin.se \
--to=git@haerdin.se \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git