From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E682A432B6 for ; Wed, 27 Jul 2022 13:21:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AFAD768B8B1; Wed, 27 Jul 2022 16:21:51 +0300 (EEST) Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [80.241.56.152]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EDA9368B6D1 for ; Wed, 27 Jul 2022 16:21:44 +0300 (EEST) Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4LtDvV683cz9sSg for ; Wed, 27 Jul 2022 15:21:42 +0200 (CEST) Message-ID: Date: Wed, 27 Jul 2022 18:51:31 +0530 MIME-Version: 1.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220727123631.314004-1-fei.w.wang@intel.com> <20220727123631.314004-2-fei.w.wang@intel.com> From: Gyan Doshi In-Reply-To: <20220727123631.314004-2-fei.w.wang@intel.com> Subject: Re: [FFmpeg-devel] [PATCH v1 2/2] lavfi/overlay_vaapi: Set defalut alpha value as 1.0 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Typo in title. On 2022-07-27 06:06 pm, Fei Wang wrote: > Previous default value 0.0 means 100% transparency for overlaid video, > which make overlaid invisible. Change to 1.0 will let output video much > more clear and less confuse if user doesn't specify alpha value. " The present default value of 0 will render the overlay video invisible. A default of 1.0 is consistent with most common use cases. " > > Signed-off-by: Fei Wang > --- > doc/filters.texi | 2 +- > libavfilter/vf_overlay_vaapi.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/doc/filters.texi b/doc/filters.texi > index 47ac4dc7f4..76168955c6 100644 > --- a/doc/filters.texi > +++ b/doc/filters.texi > @@ -26119,7 +26119,7 @@ Default value is the height of input overlay video. > @item alpha > Set transparency of overlaid video. Allowed range is 0.0 to 1.0, > higher value means lower transparency. > -Default value is @code{0.0}. > +Default value is @code{1.0}. > > @end table > > diff --git a/libavfilter/vf_overlay_vaapi.c b/libavfilter/vf_overlay_vaapi.c > index b3a624ae15..3e6a0de13f 100644 > --- a/libavfilter/vf_overlay_vaapi.c > +++ b/libavfilter/vf_overlay_vaapi.c > @@ -380,7 +380,7 @@ static const AVOption overlay_vaapi_options[] = { > { "h", "Overlay height", > OFFSET(overlay_oh), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, INT_MAX, .flags = FLAGS }, > { "alpha", "Overlay global alpha", > - OFFSET(alpha), AV_OPT_TYPE_FLOAT, { .dbl = 0.0}, 0.0, 1.0, .flags = FLAGS}, > + OFFSET(alpha), AV_OPT_TYPE_FLOAT, { .dbl = 1.0}, 0.0, 1.0, .flags = FLAGS}, > { NULL }, > }; > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".