From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id F23784C699 for ; Mon, 26 May 2025 11:48:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id DD86168D6CC; Mon, 26 May 2025 14:48:31 +0300 (EEST) Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 5B7F768CF5E for ; Mon, 26 May 2025 14:48:25 +0300 (EEST) Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-552206ac67aso2525978e87.2 for ; Mon, 26 May 2025 04:48:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1748260104; x=1748864904; darn=ffmpeg.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=whOqPJwGx77kIioFxPdSoMwXmGSV8hu5j45eM0d/3Js=; b=e+Dh37I9k01xjWEj43SYjcymjApRRRuKxODXWb6JxIUDft8gBNZ9oUEEZhs7zgq2Jb N42a6Asy4fPUu4fu7b1HoGZKbGPggrPsOYN4GsW1EyIg4//FwTGepArogakD4UDAQT9i ulNrEZv4QZSCikf0236jnPMN2ado6ecVSdkxTCdnQoTeKHjCL+HBMmzfd5ciBZ9oZ9q6 XzriUNeXQqsuBhMXWFD6CFSuVWiFGr8L0gr4RFqZjq4RJ0m2+GPxDb90ZGT5NCHOoVeY MGBj0iIJxbwWXjFe8FX/RmyxqAhfv3hP8iRHuks9PBThC1z3aIgatS1ZGFiFnrRq744u 67qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748260104; x=1748864904; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=whOqPJwGx77kIioFxPdSoMwXmGSV8hu5j45eM0d/3Js=; b=jkStPsmGyLCKyVUcNY5nhv2soRYc+5uG1KiRSBgIJSxvsRSYFFbI0NO6ntdPKkmNmy W4JI4Y6EigLIUr3gQfBgXdRr3BHiOH8djqscqh6jBX+QFVyQVhFxUfXQYa7iCLTQLyFs RAQq1HLaylPIF8/bTwRD9Hqx0m1AmRFMlRDjabCJNVopagsKCZ5N55/NAXaH9QkLW8+V LHPYHolPtHtIh0pOrKOxBcaXO+hUwJtApmMTlqM4y2RVqH3JA+vwRmhJM5bTM0W6cfwv alqikD5yMYa4bvg9zwuV3Vk/ZXeyvskgEdu64sD4SjEbcq9MSdMFacrr70GoZvzJKRBw v8TQ== X-Gm-Message-State: AOJu0YzD0dAhrlLynRCwIZHnJTan9vkCG6i1TQPksOecRejFztcPMu7l JhvVZ3ugOZFNB8IXi6X5zBv80FfKuQj5RaHlQ3fnljpEvhLpk6MfyC27n+pQrETLhZp7buFrPIp SwttTXA== X-Gm-Gg: ASbGncugqt5SosikGnAoYB/dMezwIrBtoC2FL8bnO1g1H4FZb+ak+qbQ6KCaj3RJUcT /VTsBJHPBAJ3SODJKrFk8WLjGKxDuMAWYwByILhwC8Ja7nP2juf658xtQXSTj9Xw6aDSWOkjEOy Q/AXHeJRTVnvtY6ZQad91TVrP9vCJNL5PcvpdLlbYW2MSG+xby0QjNKrSnhjLaDlJ19Ci4Nbom7 93Q8BBIxxAnzxf3jSL3LK7NAiXDtCq0nzrPjuWArjaa+2fd8quS3T52X7GXnr4msFjgGhI2aAX8 zGfp5g+Mv2cAhr+PEdwxZpW9QA+OUSu8dVQVsyvyUr8eIjdS+yjW1Wz6Ac3YUehh2f0kCJGOlkH oq+OXSCiRFjHuIZrEkOsP1n0mfRsJKkE7xu2tRj6JYzf/W20= X-Google-Smtp-Source: AGHT+IFDZKCbhSoD6725nnrDimgj4+O87o80LsDqdc2+QY18fn0+guyIZpqwG6kK0OxkodlzjM2B6A== X-Received: by 2002:a05:6512:2208:b0:54a:cc75:3d81 with SMTP id 2adb3069b0e04-5521c7b2c0emr2345027e87.4.1748260104154; Mon, 26 May 2025 04:48:24 -0700 (PDT) Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net (tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55221dd8ebbsm750844e87.152.2025.05.26.04.48.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 May 2025 04:48:23 -0700 (PDT) Date: Mon, 26 May 2025 14:48:22 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <7a95fb9-63c-7ec-52b1-e39dfaba7c0@martin.st> Message-ID: References: <20250523093201.1534-1-coiaprant@gmail.com> <7a95fb9-63c-7ec-52b1-e39dfaba7c0@martin.st> MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] fix(configure): fix detection on windows X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Coia Prant Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-15"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, 25 May 2025, Martin Storsj=F6 wrote: > On Fri, 23 May 2025, Coia Prant wrote: > >> On Windows Arm64 >> `uname -m` returned `x86_64` instead of `aarch64` >> Link: https://github.com/msys2/msys2-runtime/issues/171 >> = >> On x86 32-bit toolchain msys2 environment >> `uname -m` returned `x86_64` instead of `i686` or `x86` >> = >> So check MSYSTEM_CARCH on windows (for arm64 and i686) >> = >> This problem also in VideoLAN/x264 >> Link: https://code.videolan.org/videolan/x264/-/merge_requests/177 >> = >> Signed-off-by: Coia Prant >> --- >> configure | 2 ++ >> 1 file changed, 2 insertions(+) >> = >> diff --git a/configure b/configure >> index 2e69b3c..ed30b6b 100755 >> --- a/configure >> +++ b/configure >> @@ -4157,6 +4157,8 @@ if test "$target_os_default" =3D aix; then >> arch_default=3D$(uname -p) >> strip_default=3D"strip -X32_64" >> nm_default=3D"nm -g -X32_64" >> +elif test "$MSYSTEM_CARCH" !=3D ""; then >> + arch_default=3D"$MSYSTEM_CARCH" >> else >> arch_default=3D$(uname -m) >> fi >> -- = >> 2.49.0.windows.1 > > This approach seems reasonable to me. > > (On i686 vs x86_64, it hasn't been an issue, since they all map into "x86= " = > within ffmpeg, and configure then checks the bitness, but for arm64 it's = > indeed an issue.) > > I can push the patch soon if nobody minds it. Pushed now, with a rewritten commit message explaining the situation a bit = more. But it seems like I lost the reference to = https://github.com/msys2/msys2-runtime/issues/171 while rewriting the = text, sorry about that. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".