* [FFmpeg-devel] [PATCH] checkasm: test with random bw value
@ 2023-11-09 20:26 Rémi Denis-Courmont
2023-11-09 21:32 ` Martin Storsjö
0 siblings, 1 reply; 2+ messages in thread
From: Rémi Denis-Courmont @ 2023-11-09 20:26 UTC (permalink / raw)
To: ffmpeg-devel
With a value of zero, the function is a glorified memory copy.
---
tests/checkasm/sbrdsp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/checkasm/sbrdsp.c b/tests/checkasm/sbrdsp.c
index 2fb14d5bf8..5cc3b33215 100644
--- a/tests/checkasm/sbrdsp.c
+++ b/tests/checkasm/sbrdsp.c
@@ -190,8 +190,8 @@ static void test_hf_gen(void)
for (i = 2; i < 64; i += 2) {
memset(dst0, 0, 128 * 2 * sizeof(INTFLOAT));
memset(dst1, 0, 128 * 2 * sizeof(INTFLOAT));
- call_ref(dst0, low, alpha0, alpha1, 0.0, i, 128);
- call_new(dst1, low, alpha0, alpha1, 0.0, i, 128);
+ call_ref(dst0, low, alpha0, alpha1, bw, i, 128);
+ call_new(dst1, low, alpha0, alpha1, bw, i, 128);
if (!float_near_abs_eps_array((INTFLOAT *)dst0, (INTFLOAT *)dst1, EPS, 128 * 2))
fail();
bench_new(dst1, low, alpha0, alpha1, bw, i, 128);
--
2.42.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [FFmpeg-devel] [PATCH] checkasm: test with random bw value
2023-11-09 20:26 [FFmpeg-devel] [PATCH] checkasm: test with random bw value Rémi Denis-Courmont
@ 2023-11-09 21:32 ` Martin Storsjö
0 siblings, 0 replies; 2+ messages in thread
From: Martin Storsjö @ 2023-11-09 21:32 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Thu, 9 Nov 2023, Rémi Denis-Courmont wrote:
> With a value of zero, the function is a glorified memory copy.
> ---
> tests/checkasm/sbrdsp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/checkasm/sbrdsp.c b/tests/checkasm/sbrdsp.c
> index 2fb14d5bf8..5cc3b33215 100644
> --- a/tests/checkasm/sbrdsp.c
> +++ b/tests/checkasm/sbrdsp.c
> @@ -190,8 +190,8 @@ static void test_hf_gen(void)
> for (i = 2; i < 64; i += 2) {
> memset(dst0, 0, 128 * 2 * sizeof(INTFLOAT));
> memset(dst1, 0, 128 * 2 * sizeof(INTFLOAT));
> - call_ref(dst0, low, alpha0, alpha1, 0.0, i, 128);
> - call_new(dst1, low, alpha0, alpha1, 0.0, i, 128);
> + call_ref(dst0, low, alpha0, alpha1, bw, i, 128);
> + call_new(dst1, low, alpha0, alpha1, bw, i, 128);
> if (!float_near_abs_eps_array((INTFLOAT *)dst0, (INTFLOAT *)dst1, EPS, 128 * 2))
> fail();
> bench_new(dst1, low, alpha0, alpha1, bw, i, 128);
> --
> 2.42.0
LGTM, also tested on i386, x86_64, armv7 and aarch64.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-09 21:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-09 20:26 [FFmpeg-devel] [PATCH] checkasm: test with random bw value Rémi Denis-Courmont
2023-11-09 21:32 ` Martin Storsjö
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git